Skip to content

Comments

Update issue templates (#212)#213

Closed
Dargon789 wants to merge 0 commit intomasterfrom
v3-Update-issue-templates
Closed

Update issue templates (#212)#213
Dargon789 wants to merge 0 commit intomasterfrom
v3-Update-issue-templates

Conversation

@Dargon789
Copy link
Owner

  • Do not set passkey signer as identity signer

  • Use length checks

  • Throw on missing identity signer

  • Encoding requires identity signer to encode

  • Fix test

  • Refactor/types namings tsdoc redundant code (Refactor/types namings tsdoc redundant code 0xsequence/sequence.js#880)

  • refactor types, namings, ts doc

  • fix session response payload

  • change parameter name

  • change parameter name

  • change type in tests

  • improve types and dapp client methods

  • fix session test to use new types

  • refactor

  • refactor implicit sessions array in chain session manager

  • remove unused types

  • remove unused types and add ConnectionError

  • update pnpm lock

  • move reusable session types to wallet-core

  • Update some imports and update some response type names


Bumps the npm_and_yarn group with 1 update in the / directory: happy-dom.
Bumps the npm_and_yarn group with 1 update in the /packages/wallet/dapp-client directory: happy-dom.
Bumps the npm_and_yarn group with 1 update in the /packages/wallet/wdk directory: happy-dom.

Updates happy-dom from 17.6.3 to 20.0.0

Updates happy-dom from 17.6.3 to 20.0.0

Updates happy-dom from 17.6.3 to 20.0.0


updated-dependencies:

  • dependency-name: happy-dom dependency-version: 20.0.0 dependency-type: direct:development dependency-group: npm_and_yarn
  • dependency-name: happy-dom dependency-version: 20.0.0 dependency-type: direct:development dependency-group: npm_and_yarn
  • dependency-name: happy-dom dependency-version: 20.0.0 dependency-type: direct:development dependency-group: npm_and_yarn ...

Bumps the npm_and_yarn group with 1 update in the / directory: happy-dom.

Updates happy-dom from 20.0.0 to 20.0.2


updated-dependencies:

  • dependency-name: happy-dom dependency-version: 20.0.2 dependency-type: direct:development dependency-group: npm_and_yarn ...

Add a security policy document outlining supported versions and vulnerability reporting.

  • Update SECURITY.md

  • Update SECURITY.md


Snyk has created this PR to upgrade @tanstack/react-query from 5.45.1 to 5.64.2.

See this package in npm:
@tanstack/react-query

See this project in Snyk:
https://app.snyk.io/org/dargon789/project/bb845543-cbee-4e11-8cf9-8bfdf9205bf1?utm_source=github&utm_medium=referral&page=upgrade-pr

  • Create config.yml (Create config.yml #46)

  • Update fortify.yml

  • Update .github/ISSUE_TEMPLATE/bug_report.md

  • Update .github/ISSUE_TEMPLATE/feature_request.md


  • Bump the npm_and_yarn group across 3 directories with 1 update

Bumps the npm_and_yarn group with 1 update in the / directory: happy-dom.
Bumps the npm_and_yarn group with 1 update in the /packages/wallet/dapp-client directory: happy-dom.
Bumps the npm_and_yarn group with 1 update in the /packages/wallet/wdk directory: happy-dom.

Updates happy-dom from 17.6.3 to 20.0.2

Updates happy-dom from 17.6.3 to 20.0.2

Updates happy-dom from 17.6.3 to 20.0.2


updated-dependencies:

  • dependency-name: happy-dom dependency-version: 20.0.2 dependency-type: direct:development dependency-group: npm_and_yarn
  • dependency-name: happy-dom dependency-version: 20.0.2 dependency-type: direct:development dependency-group: npm_and_yarn
  • dependency-name: happy-dom dependency-version: 20.0.2 dependency-type: direct:development dependency-group: npm_and_yarn ...

Enhancements:
Include FUNDING.json to display GitHub sponsorship options in the repository

Add initial CircleCI configuration to enable automated builds using a custom Docker executor and a defined workflow.

Build:

Add .circleci/config.yml with version 2.1 specification and custom Docker executor. CI:

Define web3-defi-game-project job with checkout step. Set up my-custom-workflow to run the job.

Summary by Sourcery
Overhaul App.tsx to build a comprehensive Sequence Wallet demo application, replacing wagmi with Sequence SDK integration, adding environment/configuration management, rich wallet operations, and a structured UI with console output for interactive testing

New Features:

Replace wagmi-based hooks with @0xsequence wallet initialization and integration Add environment selection and dynamic wallet URLs via query parameters Implement connect, disconnect, open/close wallet and customizable connection settings Provide extensive demo actions including chain/network switching, account/balance queries, message signing, typed data signing, and transaction sending Introduce a console component and logging for viewing function outputs Add email-based auto-login via modal with validation Enhancements:

Refactor UI to use design-system components and group actions thematically Initialize logger and configure default chain/network Memoize and listen to wallet events such as chain changes

  • Add rc4 contracts

  • Set rc4 as default and add it to lists

  • Session enhanced replay protection

  • New sessions replay protection hashes payload

  • Use the 4337 factory wrapper

  • Update keymachine url in dapp-client constants

  • Update keymachine url in Provider constructor

  • SSR safety (SSR safety 0xsequence/sequence.js#915)

  • SSR safety test

  • Fix CI job

  • Guard dapp-client for SSR (lazy transport, browser checks, gated storage)

  • Fix guard topology (Fix guard topology 0xsequence/sequence.js#918)

  • Use proper guard topology

  • Test and fixes

  • login and setup tests

  • Switch prod manager settings (Switch prod manager settings 0xsequence/sequence.js#917)

  • Add prod guard and identity instrument info

  • Remove completed TODOs

  • Small JS tweaks (Small JS tweaks 0xsequence/sequence.js#919)

  • Fix type exports to built declarations

  • Update repository links to current package paths

  • Improve Next app tooling and React typings

  • Expose primitives CLI bin and use base lint config

  • Update relayer.gen.ts and TransactionPrecondition interface

  • Update api.gen.ts

  • Update metadata.gen.ts

  • Update marketplace.gen.ts

  • Update guard.gen.ts

  • Support multiple identity signers in sessions configuration

  • Device signers can approve implicit sessions

  • Remove invalid test

  • Fix recursion

  • Fix comment

  • Improve test stability by reducing race conditions

  • Do not set passkey signer as identity signer

  • Use length checks

  • Throw on missing identity signer

  • Encoding requires identity signer to encode

  • Fix test

  • Refactor/types namings tsdoc redundant code (Refactor/types namings tsdoc redundant code 0xsequence/sequence.js#880)

  • refactor types, namings, ts doc

  • fix session response payload

  • change parameter name

  • change parameter name

  • change type in tests

  • improve types and dapp client methods

  • fix session test to use new types

  • refactor

  • refactor implicit sessions array in chain session manager

  • remove unused types

  • remove unused types and add ConnectionError

  • update pnpm lock

  • move reusable session types to wallet-core

  • Update some imports and update some response type names



Bumps next from 15.5.5 to 15.5.7.


updated-dependencies:

  • dependency-name: next dependency-version: 15.5.7 dependency-type: direct:production ...


The following vulnerabilities are fixed with an upgrade:

The following vulnerabilities are fixed with an upgrade:

The following vulnerabilities are fixed with an upgrade:

  • Revert "Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/npm_and_yarn-318c02e2da'"

This reverts commit fd0fdf9, reversing changes made to cba7894.

The following vulnerabilities are fixed with an upgrade:

The following vulnerabilities are fixed with an upgrade:

Bumps the npm_and_yarn group with 1 update in the / directory: next.

Updates next from 15.5.7 to 15.5.9


updated-dependencies:

  • dependency-name: next dependency-version: 15.5.9 dependency-type: direct:production dependency-group: npm_and_yarn ...

The following vulnerabilities are fixed with an upgrade:

Bumps the npm_and_yarn group with 1 update in the / directory: next.

Updates next from 15.5.5 to 15.5.9

Updates happy-dom from 17.6.3 to 20.0.11

Updates vite from 7.1.10 to 7.2.7


updated-dependencies:

  • dependency-name: next dependency-version: 15.5.9 dependency-type: direct:production dependency-group: npm_and_yarn
  • dependency-name: happy-dom dependency-version: 20.0.11 dependency-type: direct:development dependency-group: npm_and_yarn
  • dependency-name: vite dependency-version: 7.2.7 dependency-type: indirect dependency-group: npm_and_yarn ...

Bumps next from 15.5.7 to 15.5.9.


updated-dependencies:

  • dependency-name: next dependency-version: 15.5.9 dependency-type: direct:production ...

Snyk has created this PR to upgrade @wagmi/cli from 0.1.15 to 2.8.0.

See this package in npm:
@wagmi/cli

See this project in Snyk:
https://app.snyk.io/org/dargon789/project/bb845543-cbee-4e11-8cf9-8bfdf9205bf1?utm_source=github&utm_medium=referral&page=upgrade-pr

  • Potential fix for code scanning alert no. 82: Workflow does not contain permissions

  • Potential fix for code scanning alert no. 62: Information exposure through a stack trace

  • [Snyk] Upgrade @tanstack/react-query from 5.64.2 to 5.90.11 ([Snyk] Upgrade @tanstack/react-query from 5.64.2 to 5.90.11 #125)

  • fix: upgrade @tanstack/react-query from 5.64.2 to 5.90.11

Snyk has created this PR to upgrade @tanstack/react-query from 5.64.2 to 5.90.11.

See this package in npm:
@tanstack/react-query

See this project in Snyk:
https://app.snyk.io/org/dargon789/project/bb845543-cbee-4e11-8cf9-8bfdf9205bf1?utm_source=github&utm_medium=referral&page=upgrade-pr

  • Update wagmi-project/package.json

Snyk has created this PR to upgrade vite from 5.4.21 to 7.2.4.

See this package in npm:
vite

See this project in Snyk:
https://app.snyk.io/org/dargon789/project/bb845543-cbee-4e11-8cf9-8bfdf9205bf1?utm_source=github&utm_medium=referral&page=upgrade-pr

Snyk has created this PR to upgrade wagmi from 0.12.19 to 3.0.2.

See this package in npm:
wagmi

See this project in Snyk:
https://app.snyk.io/org/dargon789/project/bb845543-cbee-4e11-8cf9-8bfdf9205bf1?utm_source=github&utm_medium=referral&page=upgrade-pr

Snyk has created this PR to upgrade react-dom from 18.3.1 to 19.2.0.

See this package in npm:
react-dom

See this project in Snyk:
https://app.snyk.io/org/dargon789/project/bb845543-cbee-4e11-8cf9-8bfdf9205bf1?utm_source=github&utm_medium=referral&page=upgrade-pr

The following vulnerabilities are fixed with an upgrade:

Snyk has created this PR to upgrade @types/react from 18.3.27 to 19.2.7.

See this package in npm:
@types/react

See this project in Snyk:
https://app.snyk.io/org/dargon789/project/bb845543-cbee-4e11-8cf9-8bfdf9205bf1?utm_source=github&utm_medium=referral&page=upgrade-pr

  • Update wagmi-project/package.json

Bumps the npm_and_yarn group with 1 update in the / directory: express.

Updates express from 4.18.2 to 4.19.2


updated-dependencies:

  • dependency-name: express dependency-type: direct:development dependency-group: npm_and_yarn-security-group ...
  • Create SECURITY.md

  • Set up CI with Azure Pipelines

[skip ci]

  • Create CNAME

  • Create fortify.yml

  • Update issue templates

  • Update CNAME

  • fix: upgrade @tanstack/react-query from 5.45.1 to 5.64.2

Snyk has created this PR to upgrade @tanstack/react-query from 5.45.1 to 5.64.2.

See this package in npm:
@tanstack/react-query

See this project in Snyk:
https://app.snyk.io/org/dargon789/project/bb845543-cbee-4e11-8cf9-8bfdf9205bf1?utm_source=github&utm_medium=referral&page=upgrade-pr

  • Create config.yml (Create config.yml #46)

  • Support multiple identity signers in sessions configuration

  • Device signers can approve implicit sessions

  • Remove invalid test

  • Fix recursion

  • Fix comment

  • Improve test stability by reducing race conditions

  • Do not set passkey signer as identity signer

  • Use length checks

  • Throw on missing identity signer

  • Encoding requires identity signer to encode

  • Fix test

  • Refactor/types namings tsdoc redundant code (Refactor/types namings tsdoc redundant code 0xsequence/sequence.js#880)

  • refactor types, namings, ts doc

  • fix session response payload

  • change parameter name

  • change parameter name

  • change type in tests

  • improve types and dapp client methods

  • fix session test to use new types

  • refactor

  • refactor implicit sessions array in chain session manager

  • remove unused types

  • remove unused types and add ConnectionError

  • update pnpm lock

  • move reusable session types to wallet-core

  • Update some imports and update some response type names


Bumps the npm_and_yarn group with 1 update in the / directory: happy-dom.
Bumps the npm_and_yarn group with 1 update in the /packages/wallet/dapp-client directory: happy-dom.
Bumps the npm_and_yarn group with 1 update in the /packages/wallet/wdk directory: happy-dom.

Updates happy-dom from 17.6.3 to 20.0.2

Updates happy-dom from 17.6.3 to 20.0.2

Updates happy-dom from 17.6.3 to 20.0.2


updated-dependencies:

  • dependency-name: happy-dom dependency-version: 20.0.2 dependency-type: direct:development dependency-group: npm_and_yarn
  • dependency-name: happy-dom dependency-version: 20.0.2 dependency-type: direct:development dependency-group: npm_and_yarn
  • dependency-name: happy-dom dependency-version: 20.0.2 dependency-type: direct:development dependency-group: npm_and_yarn ...

Enhancements:
Include FUNDING.json to display GitHub sponsorship options in the repository

Add initial CircleCI configuration to enable automated builds using a custom Docker executor and a defined workflow.

Build:

Add .circleci/config.yml with version 2.1 specification and custom Docker executor. CI:

Define web3-defi-game-project job with checkout step. Set up my-custom-workflow to run the job.

  • Add rc4 contracts

  • Set rc4 as default and add it to lists

  • Session enhanced replay protection

  • New sessions replay protection hashes payload

  • Use the 4337 factory wrapper

  • Update keymachine url in dapp-client constants

  • Update keymachine url in Provider constructor

  • SSR safety (SSR safety 0xsequence/sequence.js#915)

  • SSR safety test

  • Fix CI job

  • Guard dapp-client for SSR (lazy transport, browser checks, gated storage)

  • Fix guard topology (Fix guard topology 0xsequence/sequence.js#918)

  • Use proper guard topology

  • Test and fixes

  • login and setup tests

  • Switch prod manager settings (Switch prod manager settings 0xsequence/sequence.js#917)

  • Add prod guard and identity instrument info

  • Remove completed TODOs

  • Small JS tweaks (Small JS tweaks 0xsequence/sequence.js#919)

  • Fix type exports to built declarations

  • Update repository links to current package paths

  • Improve Next app tooling and React typings

  • Expose primitives CLI bin and use base lint config

  • Update relayer.gen.ts and TransactionPrecondition interface

  • Update api.gen.ts

  • Update metadata.gen.ts

  • Update marketplace.gen.ts

  • Update guard.gen.ts

  • Support multiple identity signers in sessions configuration

  • Device signers can approve implicit sessions

  • Remove invalid test

  • Fix recursion

  • Fix comment

  • Improve test stability by reducing race conditions

  • Do not set passkey signer as identity signer

  • Use length checks

  • Throw on missing identity signer

  • Encoding requires identity signer to encode

  • Fix test

  • Refactor/types namings tsdoc redundant code (Refactor/types namings tsdoc redundant code 0xsequence/sequence.js#880)

  • refactor types, namings, ts doc

  • fix session response payload

  • change parameter name

  • change parameter name

  • change type in tests

  • improve types and dapp client methods

  • fix session test to use new types

  • refactor

  • refactor implicit sessions array in chain session manager

  • remove unused types

  • remove unused types and add ConnectionError

  • update pnpm lock

  • move reusable session types to wallet-core

  • Update some imports and update some response type names



Bumps next from 15.5.5 to 15.5.7.


updated-dependencies:

  • dependency-name: next dependency-version: 15.5.7 dependency-type: direct:production ...


The following vulnerabilities are fixed with an upgrade:

The following vulnerabilities are fixed with an upgrade:

The following vulnerabilities are fixed with an upgrade:

  • Revert "Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/npm_and_yarn-318c02e2da'"

This reverts commit fd0fdf9, reversing changes made to cba7894.

The following vulnerabilities are fixed with an upgrade:

The following vulnerabilities are fixed with an upgrade:

Bumps the npm_and_yarn group with 1 update in the / directory: next.

Updates next from 15.5.7 to 15.5.9


updated-dependencies:

  • dependency-name: next dependency-version: 15.5.9 dependency-type: direct:production dependency-group: npm_and_yarn ...

The following vulnerabilities are fixed with an upgrade:

Bumps the npm_and_yarn group with 1 update in the / directory: next.

Updates next from 15.5.5 to 15.5.9

Updates happy-dom from 17.6.3 to 20.0.11

Updates vite from 7.1.10 to 7.2.7


updated-dependencies:

  • dependency-name: next dependency-version: 15.5.9 dependency-type: direct:production dependency-group: npm_and_yarn
  • dependency-name: happy-dom dependency-version: 20.0.11 dependency-type: direct:development dependency-group: npm_and_yarn
  • dependency-name: vite dependency-version: 7.2.7 dependency-type: indirect dependency-group: npm_and_yarn ...

Bumps next from 15.5.7 to 15.5.9.


updated-dependencies:

  • dependency-name: next dependency-version: 15.5.9 dependency-type: direct:production ...

The following vulnerabilities are fixed with an upgrade:


  • Update wagmi-project/src/App.tsx

  • Update wagmi-project/src/App.tsx

  • Update wagmi-project/src/App.tsx

  • Update wagmi-project/src/App.tsx

  • 2.3.7 (2.3.7 #131) (2.3.7 (#131) #132)

  • 2.3.7 (2.3.7 #131)

  • fix broken guard private key

  • Expose access to passkey credential list

  • Dapp client direct txn request (Dapp client direct txn request 0xsequence/sequence.js#856)

  • Signature request refactor

  • WIP

  • Refactor

  • Update dapp-client exports (Update dapp-client exports 0xsequence/sequence.js#858)

  • Add hasPermission method to DappClient (Add hasPermission method to DappClient 0xsequence/sequence.js#859)

  • Save discovered passkey credentials upon login

  • Expose name property in PasskeySignupArgs

  • Fix blacklist sort

  • Add multi server script

  • relayer: /SimulateV3 (relayer: /SimulateV3 0xsequence/sequence.js#857)

  • Add await for handleOpenDB scheduleExpiration

  • Update increment to always include native once used

  • Fix session tests

  • Adding lastLoginAt to PasskeyCredential

  • LoginToPasskeyArgs now accept a credentialId which is used to specify which credential to use

  • Adding onSignatureRequestStatus function to register single use callbacks for when a request reaches a terminal state of completed or cancelled

  • When a login is cancelled we can remove the wallet which is logging-in

  • Add RC3 contracts

  • Sessions space restriction

  • Dedupe signers for encoding

  • Support RC3 sessions

  • Tightly increment call validation

  • CLI defaults to RC3 wallet code

  • Rc3 address test

  • Fix hashing tests

  • Add deprecated encoding test

  • wdk: throw errors from otp respond callback (wdk: throw errors from otp respond callback 0xsequence/sequence.js#864)

  • wdk: throw errors from otp respond callback

  • wdk: otp auth error and handler refactor

  • Handle guard 2FA (Handle guard 2FA 0xsequence/sequence.js#861)

  • guard: return a specific error when auth required

  • core: pass guard token to the service

  • wdk: handle prompting for guard 2FA code

  • dapp-client: handle prompting for guard 2FA code

  • guard 2fa tests

  • wdk: separate wallet and sessions guards

  • dapp-client: remove guard 2fa

  • dapp-client: fix imports

  • fix guard tests

  • wdk: remove unneeded promise resolve

  • Update relayer and api gen.ts, force public packages

  • Add standalone fetch queued payloads

  • Replacing GuardRole enum with string union type, as well as replacing guardAddresses Map with Record<GuardRole, Address>

  • Fallback to chain for non-logged in recovery

  • Add Katana, Sandbox Tesnet, Incentiv Testnet v2 (Add Katana, Sandbox Tesnet, Incentiv Testnet v2 0xsequence/sequence.js#873)

  • Update a few remaining dev1 contract addresses to rc3 (Update a few remaining dev1 contract addresses to rc3 0xsequence/sequence.js#874)

  • Remove unnecessary console.error where we already throw error

  • Improve DappClient hasPermission method

  • Wallet db try checksum and lowercase

  • Update dapp client json utils to include Map reviver and replacer

  • Bump next in the npm_and_yarn group across 1 directory

Bumps the npm_and_yarn group with 1 update in the / directory: next.

Updates next from 15.4.2 to 15.4.7


updated-dependencies:

  • dependency-name: next dependency-version: 15.4.7 dependency-type: direct:production dependency-group: npm_and_yarn ...
  • Update type name, update exports for dapp client

  • Expired explicit sessions can't sign

  • Improve session validity test

  • session isValid returns invalid reason

  • InvalidReason is typed

  • Support multiple identity signers in sessions configuration

  • Device signers can approve implicit sessions

  • Remove invalid test

  • Fix recursion

  • Fix comment

  • Improve test stability by reducing race conditions

  • Do not set passkey signer as identity signer

  • Use length checks

  • Throw on missing identity signer

  • Encoding requires identity signer to encode

  • Fix test

  • Refactor/types namings tsdoc redundant code (Refactor/types namings tsdoc redundant code 0xsequence/sequence.js#880)

  • refactor types, namings, ts doc

  • fix session response payload

  • change parameter name

  • change parameter name

  • change type in tests

  • improve types and dapp client methods

  • fix session test to use new types

  • refactor

  • refactor implicit sessions array in chain session manager

  • remove unused types

  • remove unused types and add ConnectionError

  • update pnpm lock

  • move reusable session types to wallet-core

  • Update some imports and update some response type names


Bumps the npm_and_yarn group with 1 update in the / directory: happy-dom.
Bumps the npm_and_yarn group with 1 update in the /packages/wallet/dapp-client directory: happy-dom.
Bumps the npm_and_yarn group with 1 update in the /packages/wallet/wdk directory: happy-dom.

Updates happy-dom from 17.6.3 to 20.0.0

Updates happy-dom from 17.6.3 to 20.0.0

Updates happy-dom from 17.6.3 to 20.0.0


updated-dependencies:

  • dependency-name: happy-dom dependency-version: 20.0.0 dependency-type: direct:development dependency-group: npm_and_yarn
  • dependency-name…

protected path = '/rpc/UserData/'

constructor(hostname: string, fetch: Fetch) {
this.hostname = hostname.replace(/\/*$/, '')

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data

This [regular expression](1) that depends on [library input](2) may run slow on strings with many repetitions of '/'. This [regular expression](1) that depends on [library input](3) may run slow on strings with many repetitions of '/'.
@codesandbox
Copy link

codesandbox bot commented Jan 18, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we are unable to review this pull request

The GitHub API does not allow us to fetch diffs exceeding 300 files, and this pull request has 4796

@snyk-io
Copy link

snyk-io bot commented Jan 18, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@Dargon789 Dargon789 closed this Jan 18, 2026
@Dargon789 Dargon789 force-pushed the v3-Update-issue-templates branch from b5eb15c to 316f9d8 Compare January 18, 2026 13:37
@gemini-code-assist
Copy link

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the project's capabilities by integrating the Sequence v3 wallet contracts and ERC-4337 account abstraction through a new submodule. It enhances development workflows with updated CI/CD configurations, dependency management, and introduces new documentation for the advanced features. The changes aim to modernize the wallet infrastructure, improve security practices, and streamline contributions.

Highlights

  • New Submodule: Signals Implicit Mode: Introduced a new submodule lib/signals-implicit-mode which contains the core Sequence v3 wallet contracts. This includes comprehensive support for ERC-4337 account abstraction, advanced signature schemes (chained and sapient signatures), and detailed session management (explicit and implicit sessions).
  • Foundry Standard Library Integration: The signals-implicit-mode submodule incorporates the entire forge-std library, providing a rich set of Solidity utilities, interfaces, and testing tools for smart contract development.
  • CI/CD and Dependency Updates: Added new CircleCI and Azure Pipelines configurations, updated issue templates, and bumped the next dependency version in documentation and web packages. Changelog entries for various @0xsequence packages indicate beta releases and minor fixes.
  • Security Policy and Funding: A new SECURITY.md file outlines the project's security policy and vulnerability reporting, alongside a FUNDING.json to enable GitHub sponsorship options.
Ignored Files
  • Ignored by pattern: .github/workflows/** (4)
    • .github/workflows/Docker.yml
    • .github/workflows/nextjs.yml
    • .github/workflows/publish-dists.yml
    • .github/workflows/web-sdk.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request includes a very large number of changes, from updating issue templates to vendoring entire libraries, which makes a thorough review challenging. The PR title 'Update issue templates' doesn't fully capture the scope of these changes. For future contributions, it would be helpful to break down large changes into smaller, more focused pull requests with descriptive titles and summaries.

My review focuses on the new configuration files added in this PR. I've identified a few areas for improvement:

  • The Azure Pipelines configuration specifies an end-of-life version of Node.js, which presents a security risk.
  • The CircleCI configuration contains a job name with a likely typo.
  • The SECURITY.md file has a table of supported versions that could be confusing to users.

Please see the specific comments for details and suggestions.

I am having trouble creating individual review comments. Click here to see my feedback.

azure-pipelines.yml (15)

high

The Node.js version is set to 10.x, which reached its end-of-life on April 30, 2021. Using an EOL version is a security risk and can lead to compatibility problems with modern tools and libraries. It is highly recommended to update to a current Long-Term Support (LTS) version, such as 18.x or 20.x.

    versionSpec: '20.x'

.github/.circleci/config.yml (15)

medium

The job name web3-defi-game-project- appears to have a trailing dash, which is likely a typo. This could cause confusion or issues with tooling that parses job names. It's recommended to remove it for clarity. Remember to also update the job reference in the workflows section on line 26.

  web3-defi-game-project:

.github/.circleci/config.yml (26)

medium

This job reference web3-defi-game-project- also contains a trailing dash. It should be removed to match the corrected job name defined on line 15.

      - web3-defi-game-project

SECURITY.md (8-13)

medium

The supported versions table could be confusing for users. It indicates that version 5.1.x is supported, but 5.0.x is not, while the older 4.0.x is also supported. This might be a typo. Clarifying the support policy would help users understand which versions receive security updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant