Skip to content

Comments

Revert "Delete lib/signals-implicit-mode/lib/sequence-v3/script/DeployMocks.s…"#218

Merged
Dargon789 merged 1 commit intomasterfrom
revert-203-Dargon789-patch-1
Jan 19, 2026
Merged

Revert "Delete lib/signals-implicit-mode/lib/sequence-v3/script/DeployMocks.s…"#218
Dargon789 merged 1 commit intomasterfrom
revert-203-Dargon789-patch-1

Conversation

@Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Jan 19, 2026

Reverts #203

Summary by Sourcery

Enhancements:

  • Reintroduce the DeployMocks Solidity script to deploy the Emitter mock contract via the shared singleton deployer.

@vercel
Copy link

vercel bot commented Jan 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
sequence-js-docs Ready Ready Preview, Comment Jan 19, 2026 3:10am
sequence-js-web Ready Ready Preview, Comment Jan 19, 2026 3:10am

@codesandbox
Copy link

codesandbox bot commented Jan 19, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 19, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Restores the DeployMocks Solidity script that deploys the Emitter mock contract via the shared SingletonDeployer helper, reversing its previous deletion.

Sequence diagram for DeployMocks.run deployment flow

sequenceDiagram
  participant DeployMocks
  participant Vm
  participant SingletonDeployer
  participant Emitter

  DeployMocks->>Vm: envUint(PRIVATE_KEY) -> pk
  DeployMocks->>DeployMocks: set salt = bytes32(0)
  DeployMocks->>Emitter: access creationCode
  DeployMocks->>DeployMocks: initCode = abi.encodePacked(Emitter.creationCode)
  DeployMocks->>SingletonDeployer: _deployIfNotAlready(Emitter, initCode, salt, pk)
  SingletonDeployer-->>DeployMocks: returns deployed Emitter address
Loading

Class diagram for restored DeployMocks Solidity script

classDiagram
  class SingletonDeployer {
    <<contract>>
    +_deployIfNotAlready(name string, initCode bytes, salt bytes32, pk uint256) internal
  }

  class Emitter {
    <<contract>>
    +constructor()
  }

  class DeployMocks {
    <<contract>>
    +run() external
  }

  DeployMocks --|> SingletonDeployer
  DeployMocks ..> Emitter : uses_creationCode
Loading

File-Level Changes

Change Details Files
Reintroduce the DeployMocks Solidity deployment script for the Emitter mock using SingletonDeployer.
  • Add DeployMocks contract extending SingletonDeployer
  • Read deployer private key from PRIVATE_KEY environment variable via vm.envUint
  • Construct Emitter init code using its creationCode and abi.encodePacked
  • Call _deployIfNotAlready to deploy or reuse the Emitter singleton with a zero salt
lib/signals-implicit-mode/lib/sequence-v3/script/DeployMocks.s.sol

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io
Copy link

snyk-io bot commented Jan 19, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@gemini-code-assist
Copy link

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request serves to undo a previous commit, effectively restoring the DeployMocks.s.sol script. This script is responsible for deploying an Emitter mock contract, ensuring that this deployment functionality is available again within the project.

Highlights

  • Revert Previous Deletion: This pull request reverts a prior change (Delete lib/signals-implicit-mode/lib/sequence-v3/script/DeployMocks.s… #203) that had removed the DeployMocks.s.sol script.
  • Re-introduction of Deployment Script: The lib/signals-implicit-mode/lib/sequence-v3/script/DeployMocks.s.sol file has been re-added, restoring its functionality for deploying an Emitter mock contract.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Repository owner deleted a comment from vercel bot Jan 19, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reintroduces the DeployMocks.s.sol script. My review includes suggestions to improve the script's quality by removing an unused import and refactoring the contract to use constants for magic strings and a more robust, deterministic salt for deployment. These changes enhance code clarity, maintainability, and safety.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The imported console symbol from SingletonDeployer.s.sol is never used in DeployMocks, so it can be removed to keep the script minimal.
  • Since type(Emitter).creationCode already returns bytes memory, you can pass it directly to _deployIfNotAlready and drop the abi.encodePacked wrapper for slightly simpler and more gas-efficient code.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The imported `console` symbol from `SingletonDeployer.s.sol` is never used in `DeployMocks`, so it can be removed to keep the script minimal.
- Since `type(Emitter).creationCode` already returns `bytes memory`, you can pass it directly to `_deployIfNotAlready` and drop the `abi.encodePacked` wrapper for slightly simpler and more gas-efficient code.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Dargon789 Dargon789 merged commit cbad673 into master Jan 19, 2026
11 of 15 checks passed
@Dargon789 Dargon789 deleted the revert-203-Dargon789-patch-1 branch January 19, 2026 03:18
@Dargon789 Dargon789 linked an issue Jan 19, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[vc]: #0xsequence

1 participant