Revert "Delete lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs dir…"#219
Revert "Delete lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs dir…"#219
Conversation
…libs dir…" This reverts commit 75ae648.
|
|
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Sorry @Dargon789, your pull request is larger than the review limit of 150000 diff characters
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request serves to undo a prior removal of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request reverts a previous commit, reintroducing the erc2470-libs directory. My review focuses on the re-added code. I've found a few issues, including a critical bug in a loop in StdStorage.sol that could cause an infinite loop, a bug in the pre-commit hook that prevents it from running, and several minor issues like typos in documentation and use of deprecated Solidity features. Please see the detailed comments for suggestions.
lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs/lib/forge-std/src/StdStorage.sol
Show resolved
Hide resolved
lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs/.githooks/pre-commit
Outdated
Show resolved
Hide resolved
lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs/README.md
Outdated
Show resolved
Hide resolved
lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs/lib/forge-std/LICENSE-MIT
Show resolved
Hide resolved
lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs/lib/forge-std/README.md
Outdated
Show resolved
Hide resolved
lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs/lib/forge-std/scripts/vm.py
Outdated
Show resolved
Hide resolved
lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs/lib/forge-std/src/StdCheats.sol
Show resolved
Hide resolved
…thooks/pre-commit Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
…DME.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
…/forge-std/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
…/forge-std/scripts/vm.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Reverts #202