Skip to content

Revert "Delete lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs dir…"#219

Merged
Dargon789 merged 5 commits intomasterfrom
revert-202-Dargon789-patch-1
Jan 19, 2026
Merged

Revert "Delete lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs dir…"#219
Dargon789 merged 5 commits intomasterfrom
revert-202-Dargon789-patch-1

Conversation

@Dargon789
Copy link
Owner

Reverts #202

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@codesandbox
Copy link

codesandbox bot commented Jan 19, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@vercel
Copy link

vercel bot commented Jan 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
sequence-js-docs Ready Ready Preview, Comment Jan 19, 2026 3:40am
sequence-js-web Ready Ready Preview, Comment Jan 19, 2026 3:40am

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Dargon789, your pull request is larger than the review limit of 150000 diff characters

@snyk-io
Copy link

snyk-io bot commented Jan 19, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@gemini-code-assist
Copy link

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request serves to undo a prior removal of the erc2470-libs directory, thereby reinstating critical development infrastructure. It restores a suite of Solidity smart contracts, Foundry project configurations, and development tooling, including the forge-std library, which is fundamental for building and testing smart contracts within this project. The reintroduction of these components ensures the project's development environment is complete and functional, supporting robust smart contract development and automated quality assurance.

Highlights

  • Revert of Deletion: This pull request is a direct revert of a previous commit, effectively restoring a significant portion of the codebase that was previously removed.
  • Restoration of ERC-2470 Libs: The lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs directory and its contents have been reinstated. This includes Solidity contracts, Foundry configurations, Git hooks, and documentation related to the ERC-2470 Singleton Deployer.
  • Reintroduction of Forge Standard Library: The forge-std submodule, a comprehensive standard library for Foundry, has been brought back. This library provides essential utilities, testing tools, mock contracts, and interfaces crucial for Solidity development and testing.
  • Re-establishment of CI/CD and Linting: GitHub Actions workflows (.github/workflows) and Git pre-commit hooks (.githooks) are restored, re-enabling automated testing, code quality checks with Solhint, and other CI/CD processes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts a previous commit, reintroducing the erc2470-libs directory. My review focuses on the re-added code. I've found a few issues, including a critical bug in a loop in StdStorage.sol that could cause an infinite loop, a bug in the pre-commit hook that prevents it from running, and several minor issues like typos in documentation and use of deprecated Solidity features. Please see the detailed comments for suggestions.

…thooks/pre-commit

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
…DME.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
…/forge-std/README.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
…/forge-std/scripts/vm.py

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Repository owner deleted a comment from vercel bot Jan 19, 2026
@Dargon789 Dargon789 merged commit 0c613eb into master Jan 19, 2026
10 of 14 checks passed
@Dargon789 Dargon789 deleted the revert-202-Dargon789-patch-1 branch January 19, 2026 03:44
@Dargon789 Dargon789 linked an issue Jan 19, 2026 that may be closed by this pull request
@github-project-automation github-project-automation bot moved this from Todo to Done in web3-Defi-Gamefi Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[vc]: #0xsequence

1 participant