Master ceb95d4

[Dargon789]

No description provided.

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[bolt-new-by-stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[sourcery-ai]

Sorry @Dargon789, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[snyk-io]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[gemini-code-assist]

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on advancing the pre-release versions of various @0xsequence packages, incorporating crucial fixes for Apple authentication, and introducing significant enhancements to the dapp client. The changes aim to improve the robustness of authentication flows and provide developers with more granular control over session configurations and login methods.

Highlights

• Version Updates: All @0xsequence packages have been updated from 3.0.0-beta.5 to 3.0.0-beta.10, reflecting a series of pre-release patch changes.
• Apple Authentication Fixes: Resolved issues with Apple authentication by conditionally omitting the scope parameter during OAuth URL generation for Apple sign-ins in the wallet-wdk package. This includes adding a new test case to verify the absence of the scope parameter for Apple auth.
• Dapp Client Enhancements: The @0xsequence/dapp-client package received several updates, including the addition of 'eoa' (Externally Owned Account) as a new login method. It also now exports new types (TransportMessage, ExplicitSessionParams, NativeTokenSpending, SessionDuration) and utility functions (createExplicitSessionConfig, getNetwork, getRelayerUrl, getRpcUrl, VALUE_FORWARDER_ADDRESS) to facilitate more flexible session management and configuration.
• Explicit Session Configuration Utility: A new utility function, createExplicitSessionConfig, has been introduced in dapp-client to simplify the creation of explicit session configurations. This function allows defining session durations, permissions, and native token spending limits, enhancing control over session lifecycles.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request primarily consists of version bumps for multiple packages to 3.0.0-beta.10, along with corresponding changelog updates. These changes seem to be automated via changesets. There are also a few functional changes, including updates to the dapp-client for EOA login and explicit session configuration, and a fix for Apple authentication in the wdk package.

My review has identified a logic issue in the new createExplicitSessionConfig helper function within the dapp-client. The permission validation is performed prematurely, which would cause it to fail for valid configurations that only specify native token spending permissions. I've provided a suggestion to correct this. The other changes, including the Apple auth fix, appear correct and are accompanied by tests.

[Dargon789]

#241