Skip to content

Comments

V3#257

Merged
Dargon789 merged 694 commits intocodesandboxfrom
v3
Jan 31, 2026
Merged

V3#257
Dargon789 merged 694 commits intocodesandboxfrom
v3

Conversation

@Dargon789
Copy link
Owner

No description provided.

shunkakinoki and others added 30 commits June 5, 2025 03:32
fix: update @0xsequence/anypay-sdk and wallet dependencies to use wor…
OTP will use signer without ui if available
@codesandbox
Copy link

codesandbox bot commented Jan 31, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we are unable to review this pull request

The GitHub API does not allow us to fetch diffs exceeding 300 files, and this pull request has 5509

@vercel

This comment was marked as outdated.

protected path = '/rpc/Builder/'

constructor(hostname: string, fetch: Fetch) {
this.hostname = hostname.replace(/\/*$/, '')

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
protected path = '/rpc/IdentityInstrument/'

constructor(hostname: string, fetch: Fetch) {
this.hostname = hostname.replace(/\/*$/, '')

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
protected path = '/rpc/Indexer/'

constructor(hostname: string, fetch: Fetch) {
this.hostname = hostname.replace(/\/*$/, '')

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
protected path = '/rpc/IndexerGateway/'

constructor(hostname: string, fetch: Fetch) {
this.hostname = hostname.replace(/\/*$/, '')

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
protected path = '/rpc/Admin/'

constructor(hostname: string, fetch: Fetch) {
this.hostname = hostname.replace(/\/*$/, '')

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
protected path = '/rpc/Admin/'

constructor(hostname: string, fetch: Fetch) {
this.hostname = hostname.replace(/\/*$/, '')

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
protected path = '/rpc/Relayer/'

constructor(hostname: string, fetch: Fetch) {
this.hostname = hostname.replace(/\/*$/, '')

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
protected path = '/rpc/UserData/'

constructor(hostname: string, fetch: Fetch) {
this.hostname = hostname.replace(/\/*$/, '')

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
@snyk-io
Copy link

snyk-io bot commented Jan 31, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

…in permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
@vercel
Copy link

vercel bot commented Jan 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sequence-js-docs Ready Ready Preview, Comment Jan 31, 2026 9:28am
sequence-js-web Ready Ready Preview, Comment Jan 31, 2026 9:28am

…in permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
@gemini-code-assist
Copy link

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request marks a pivotal transition to version 3 of the project, fundamentally reshaping its architecture and development workflow. The core focus is on establishing a robust monorepo structure, integrating advanced smart contract development tools like Foundry, and enhancing continuous integration and code quality. These changes lay the groundwork for future scalability and maintainability, particularly in the realm of decentralized applications and account abstraction.

Highlights

  • Monorepo Structure and Tooling Updates: The project has undergone a significant restructuring, adopting a monorepo approach with new extras/docs and extras/web applications. This includes updated .gitignore rules, new CodeSandbox tasks, and a comprehensive lefthook.yml for Git hooks to enforce code quality and build checks.
  • Foundry and Smart Contract Development Integration: Integration with Foundry for smart contract development is now central, evidenced by the addition of lib/signals-implicit-mode and lib/sequence-v3 as submodules. These submodules bring in forge-std for testing utilities and account-abstraction for ERC-4337 support, indicating a robust smart contract ecosystem.
  • CI/CD and Code Quality Enhancements: New GitHub Actions workflows for testing Go and TypeScript SDKs, along with dedicated build and test workflows for submodules, have been introduced. ESLint and Prettier configurations have been updated or moved, and a SECURITY.md file has been added, emphasizing improved code quality and security practices.
  • Version 3 Release Cycle Preparation: Multiple new changeset files (.changeset/*.md) and a pre.json configuration indicate active development and preparation for a version 3 beta release, including various patch updates and upgrades across @0xsequence packages.
  • Comprehensive Documentation for Smart Contracts: Detailed documentation files have been added within the lib/signals-implicit-mode/lib/sequence-v3/docs directory, covering advanced topics such as chained signatures, wallet configurations, payload systems, smart sessions, and signature encoding, providing in-depth technical insights into the new contract architecture.
Ignored Files
  • Ignored by pattern: .github/workflows/** (6)
    • .github/workflows/nextjs.yml
    • .github/workflows/on_pr_pnpm-format-label.yml
    • .github/workflows/pnpm-format.yml
    • .github/workflows/publish-dists.yml
    • .github/workflows/tests.yml
    • .github/workflows/web-sdk.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant migration to version 3 of the project, overhauling the repository structure into a monorepo using pnpm and Turborepo. The changes include updating build tooling, CI/CD configurations, dependencies, and adding new documentation and web applications. My review focuses on the new and updated configuration files. I've identified several issues related to outdated or placeholder configurations in .circleci/config.yml, SECURITY.md, and azure-pipelines.yml. Addressing these will help ensure the CI/CD pipelines function correctly and that project documentation, like the security policy, is accurate. The other changes appear to be standard for such a large-scale migration.

@Dargon789 Dargon789 enabled auto-merge January 31, 2026 09:17
@vercel

This comment was marked as outdated.

protected path = '/rpc/Builder/'

constructor(hostname: string, fetch: Fetch) {
this.hostname = hostname.replace(/\/*$/, '')

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High library

This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
protected path = '/rpc/IdentityInstrument/'

constructor(hostname: string, fetch: Fetch) {
this.hostname = hostname.replace(/\/*$/, '')

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High library

This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
protected path = '/rpc/Indexer/'

constructor(hostname: string, fetch: Fetch) {
this.hostname = hostname.replace(/\/*$/, '')

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High library

This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
protected path = '/rpc/IndexerGateway/'

constructor(hostname: string, fetch: Fetch) {
this.hostname = hostname.replace(/\/*$/, '')

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High library

This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
@Dargon789 Dargon789 merged commit 048f214 into codesandbox Jan 31, 2026
9 of 14 checks passed
@Dargon789 Dargon789 deleted the v3 branch January 31, 2026 09:32
@Dargon789 Dargon789 restored the v3 branch January 31, 2026 11:05
@Dargon789 Dargon789 linked an issue Feb 3, 2026 that may be closed by this pull request
@github-project-automation github-project-automation bot moved this from Todo to Done in web3-Defi-Gamefi Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[vc]: #clean-circleci-directory-#267