Skip to content

Comments

21 fixmerge branch#26

Merged
Dargon789 merged 15 commits intomasterfrom
21-fixmerge-branch
Mar 31, 2025
Merged

21 fixmerge branch#26
Dargon789 merged 15 commits intomasterfrom
21-fixmerge-branch

Conversation

@Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Mar 31, 2025

Summary by Sourcery

Update metadata RPC client and generate network names documentation

Enhancements:

  • Update metadata RPC client to exclude deprecated methods
  • Add script to generate network names documentation

Chores:

  • Update version numbers across multiple packages
  • Update changelog files


//
// Client
//

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@codesandbox
Copy link

codesandbox bot commented Mar 31, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@vercel
Copy link

vercel bot commented Mar 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sequence.js ❌ Failed (Inspect) Mar 31, 2025 10:07am

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 31, 2025

Reviewer's Guide by Sourcery

This pull request updates the webrpc-gen version, regenerates code, adds new contract types and token metadata sources, updates enums, removes the RuntimeChecks interface, adds source to TokenIndex, removes notFound from ContractInfo, adds ContractInfoOverride, updates the Task interface, adds new methods to the Metadata interface, removes deprecated methods, updates package versions, updates the indexer's rpc client, excludes deprecated methods on rpc client, adds a script to update the network names documentation, creates a template for network names documentation, and creates a network names documentation file.

Updated class diagram for Metadata

classDiagram
  class Metadata {
    runtimeStatus()
    getTask(args: GetTaskArgs)
    getTaskStatus(args: GetTaskStatusArgs)
    getContractInfo(args: GetContractInfoArgs)
    getContractInfoBatch(args: GetContractInfoBatchArgs)
    findContractInfo(args: FindContractInfoArgs)
    findContractInfoBatch(args: FindContractInfoBatchArgs)
    refreshContractInfo(args: RefreshContractInfoArgs)
    refreshContractInfoBatch(args: RefreshContractInfoBatchArgs)
    searchContractsByQuery(args: SearchContractsByQueryArgs)
    getTokenMetadata(args: GetTokenMetadataArgs)
    getTokenMetadataBatch(args: GetTokenMetadataBatchArgs)
    refreshTokenMetadata(args: RefreshTokenMetadataArgs)
    searchTokenMetadataByQuery(args: SearchTokenMetadataByQueryArgs)
    searchTokenMetadata(args: SearchTokenMetadataArgs)
    searchTokenMetadataTokenIDs(args: SearchTokenMetadataTokenIDsArgs)
    getTokenMetadataPropertyFilters(args: GetTokenMetadataPropertyFiltersArgs)
    getTokenDirectoryNetworks(args: GetTokenDirectoryNetworksArgs)
    getTokenDirectory(args: GetTokenDirectoryArgs)
    searchTokenDirectory(args: SearchTokenDirectoryArgs)
    getNiftyswapTokenQuantity(args: GetNiftyswapTokenQuantityArgs)
    getNiftyswapUnitPrices(args: GetNiftyswapUnitPricesArgs)
    getNiftyswapUnitPricesWithQuantities(args: GetNiftyswapUnitPricesWithQuantitiesArgs)
  }
Loading

Updated class diagram for Admin

classDiagram
  class Admin {
    getContractInfoOverride(args: GetContractInfoOverrideArgs)
    getContractInfoOverrides(args: GetContractInfoOverridesArgs)
    addContractInfoOverride(args: AddContractInfoOverrideArgs)
    updateContractInfoOverride(args: UpdateContractInfoOverrideArgs)
    removeContractInfoOverride(args: RemoveContractInfoOverrideArgs)
    isInTokenDirectory(args: IsInTokenDirectoryArgs)
    setTokenDirectoryFeatureIndex(args: SetTokenDirectoryFeatureIndexArgs)
    addContractToTokenDirectory(args: AddContractToTokenDirectoryArgs)
    removeContractFromTokenDirectory(args: RemoveContractFromTokenDirectoryArgs)
    refreshTokenDirectory()
  }
Loading

File-Level Changes

Change Details Files
Updates the webrpc-gen version and regenerates code.
  • Updates the webrpc-gen version from v0.24.0 to v0.25.3.
  • Regenerates the typescript code based on the updated webrpc-gen.
  • Updates WebrpcHeaderValue to reflect the new webrpc-gen and typescript generator versions.
packages/metadata/src/metadata.gen.ts
packages/indexer/src/indexer.gen.ts
packages/indexer/src/indexergw.gen.ts
packages/api/src/api.gen.ts
packages/marketplace/src/marketplace.gen.ts
Adds ERC-6909 and MISC to the ContractType enum.
  • Adds ERC6909 to the ContractType enum.
  • Adds MISC to the ContractType enum.
packages/metadata/src/metadata.gen.ts
Adds new sources for token metadata.
  • Adds FETCHER_TOKEN_DIRECTORY_ADMIN to the Source enum.
  • Adds SEQUENCE_BUILDER_DEPLOYED to the Source enum.
  • Adds SEQUENCE_BUILDER_ADMIN to the Source enum.
packages/metadata/src/metadata.gen.ts
Updates ResourceStatus enum.
  • Renames STALE to REFRESHING in the ResourceStatus enum.
packages/metadata/src/metadata.gen.ts
packages/indexer/src/indexer.gen.ts
packages/indexer/src/indexergw.gen.ts
Updates TaskStatus enum.
  • Renames COMPLETED to DONE in the TaskStatus enum.
packages/metadata/src/metadata.gen.ts
Removes RuntimeChecks interface from the schema.
  • Removes the RuntimeChecks interface.
  • Removes checks property from RuntimeStatus interface.
packages/metadata/src/metadata.gen.ts
Adds source to TokenIndex interface.
  • Removes key property from TokenIndex interface.
  • Adds source property to TokenIndex interface.
packages/metadata/src/metadata.gen.ts
Removes notFound property from ContractInfo interface.
  • Removes notFound property from ContractInfo interface.
packages/metadata/src/metadata.gen.ts
packages/indexer/src/indexer.gen.ts
packages/indexer/src/indexergw.gen.ts
Adds ContractInfoOverride and related interfaces for contract information overrides.
  • Adds ContractInfoOverride interface.
  • Adds ContractInfoExtensionsOverride interface.
  • Adds Admin service methods for managing ContractInfoOverride.
packages/metadata/src/metadata.gen.ts
Updates Task interface to include result and modifies status.
  • Removes hash property from Task interface.
  • Adds result property to Task interface.
  • Makes status property of Task interface required.
packages/metadata/src/metadata.gen.ts
Adds several new methods to the Metadata interface.
  • Adds getContractInfo and getContractInfoBatch methods.
  • Adds findContractInfo and findContractInfoBatch methods.
  • Adds refreshContractInfo and refreshContractInfoBatch methods.
  • Adds searchContractsByQuery method.
  • Adds searchTokenMetadataByQuery method.
  • Adds searchTokenMetadataTokenIDs method.
  • Adds getTokenMetadataPropertyFilters method.
  • Adds getTokenDirectoryNetworks and getTokenDirectory methods.
  • Adds searchTokenDirectory method.
packages/metadata/src/metadata.gen.ts
Removes deprecated methods from the Metadata interface.
  • Removes enqueueTokensForRefresh, getTokenRefreshStatus, getTokenRefreshResult, and cancelRefreshJob methods.
  • Removes refreshContractTokens and refreshAllContractTokens methods.
  • Removes searchTokenIDs, tokenCollectionFilters, searchContractInfo, searchContractInfoBatch, searchMetadata, searchTokens, and searchContracts methods.
  • Removes addContractToMintMonitor, removeContractFromMintMonitor, mintMonitorJobStatus, mintMonitorTriggerJob, syncContractTokens, abortContractSync, contractSyncJobStatus, directoryGetNetworks, directoryGetCollections, and directorySearchCollections methods.
packages/metadata/src/metadata.gen.ts
Updates the packages' versions in the changelogs.
  • Updates the packages' versions from 2.2.15 to 2.3.4.
packages/0xsequence/CHANGELOG.md
packages/auth/CHANGELOG.md
packages/provider/CHANGELOG.md
packages/account/CHANGELOG.md
packages/wallet/CHANGELOG.md
packages/guard/CHANGELOG.md
packages/network/CHANGELOG.md
packages/sessions/CHANGELOG.md
packages/migration/CHANGELOG.md
packages/relayer/CHANGELOG.md
packages/waas/CHANGELOG.md
packages/core/CHANGELOG.md
packages/replacer/CHANGELOG.md
packages/tests/CHANGELOG.md
packages/deployer/CHANGELOG.md
packages/react-native/CHANGELOG.md
packages/signhub/CHANGELOG.md
packages/abi/CHANGELOG.md
packages/api/CHANGELOG.md
packages/builder/CHANGELOG.md
packages/indexer/CHANGELOG.md
packages/marketplace/CHANGELOG.md
packages/metadata/CHANGELOG.md
packages/utils/CHANGELOG.md
Updates the indexer's rpc client.
  • Updates the indexer's rpc client.
packages/auth/CHANGELOG.md
packages/provider/CHANGELOG.md
packages/account/CHANGELOG.md
packages/wallet/CHANGELOG.md
packages/guard/CHANGELOG.md
packages/network/CHANGELOG.md
packages/sessions/CHANGELOG.md
packages/migration/CHANGELOG.md
packages/relayer/CHANGELOG.md
packages/waas/CHANGELOG.md
packages/core/CHANGELOG.md
packages/replacer/CHANGELOG.md
packages/tests/CHANGELOG.md
packages/deployer/CHANGELOG.md
packages/react-native/CHANGELOG.md
packages/signhub/CHANGELOG.md
packages/abi/CHANGELOG.md
packages/api/CHANGELOG.md
packages/builder/CHANGELOG.md
packages/indexer/CHANGELOG.md
packages/marketplace/CHANGELOG.md
packages/metadata/CHANGELOG.md
packages/utils/CHANGELOG.md
Excludes deprecated methods on rpc client.
  • Excludes deprecated methods on rpc client.
packages/0xsequence/CHANGELOG.md
packages/auth/CHANGELOG.md
packages/provider/CHANGELOG.md
packages/account/CHANGELOG.md
packages/wallet/CHANGELOG.md
packages/guard/CHANGELOG.md
packages/network/CHANGELOG.md
packages/sessions/CHANGELOG.md
packages/migration/CHANGELOG.md
packages/relayer/CHANGELOG.md
packages/waas/CHANGELOG.md
packages/core/CHANGELOG.md
packages/replacer/CHANGELOG.md
packages/tests/CHANGELOG.md
packages/deployer/CHANGELOG.md
packages/react-native/CHANGELOG.md
packages/signhub/CHANGELOG.md
packages/abi/CHANGELOG.md
packages/api/CHANGELOG.md
packages/builder/CHANGELOG.md
packages/indexer/CHANGELOG.md
packages/marketplace/CHANGELOG.md
packages/metadata/CHANGELOG.md
packages/utils/CHANGELOG.md
Adds a script to update the network names documentation.
  • Adds a new script to update the network names documentation.
scripts/update-network-names-doc.ts
Creates a template for network names documentation.
  • Creates a template for network names documentation.
packages/network/networkNames.template.md
Creates a network names documentation file.
  • Creates a network names documentation file.
packages/network/networkNames.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We encountered an error and are unable to review this PR. We have been notified and are working to fix it.

You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.

@Dargon789 Dargon789 merged commit 046e1ae into master Mar 31, 2025
9 of 12 checks passed
@Dargon789 Dargon789 deleted the 21-fixmerge-branch branch March 31, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix:Merge branch '0xsequence:master' into master f2761efe54451f0b5c2f50f6485c4b5e51ddb32b

4 participants