Skip to content

Comments

Update tests.yml#38

Merged
Dargon789 merged 1 commit intomasterfrom
Dargon789-patch-1
Jun 12, 2025
Merged

Update tests.yml#38
Dargon789 merged 1 commit intomasterfrom
Dargon789-patch-1

Conversation

@Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Jun 12, 2025

Summary by Sourcery

CI:

  • Add a step to launch Anvil with a Mainnet fork prior to running pnpm test

Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
@codesandbox
Copy link

codesandbox bot commented Jun 12, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@sourcery-ai
Copy link

sourcery-ai bot commented Jun 12, 2025

Reviewer's Guide

The GitHub Actions tests workflow has been updated to launch an Anvil Ethereum mainnet fork in the background before executing the test suite.

File-Level Changes

Change Details Files
Introduce an Anvil fork step prior to running tests
  • Insert a run: anvil --fork-url https://mainnet.infura.io/v3/<INFURA_PROJECT_ID> & step
  • Position the Anvil process startup before the pnpm test command
.github/workflows/tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Repository owner deleted a comment from vercel bot Jun 12, 2025
@Dargon789 Dargon789 merged commit f55cd47 into master Jun 12, 2025
10 of 12 checks passed
@Dargon789 Dargon789 deleted the Dargon789-patch-1 branch June 12, 2025 20:10
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Dargon789 - I've reviewed your changes - here's some feedback:

  • GitHub Actions won’t persist a background process across separate run steps—consider combining the anvil … & startup and pnpm test into one step or defining Anvil as a service so the fork node is available during tests.
  • Avoid hard-coding your Infura URL; pull INFURA_PROJECT_ID from GitHub Secrets and inject it via an env: declaration to keep credentials secure.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- GitHub Actions won’t persist a background process across separate `run` steps—consider combining the `anvil … &` startup and `pnpm test` into one step or defining Anvil as a service so the fork node is available during tests.
- Avoid hard-coding your Infura URL; pull `INFURA_PROJECT_ID` from GitHub Secrets and inject it via an `env:` declaration to keep credentials secure.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant