Merged
Conversation
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Reviewer's GuideThe GitHub Actions tests workflow has been updated to launch an Anvil Ethereum mainnet fork in the background before executing the test suite. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @Dargon789 - I've reviewed your changes - here's some feedback:
- GitHub Actions won’t persist a background process across separate
runsteps—consider combining theanvil … &startup andpnpm testinto one step or defining Anvil as a service so the fork node is available during tests. - Avoid hard-coding your Infura URL; pull
INFURA_PROJECT_IDfrom GitHub Secrets and inject it via anenv:declaration to keep credentials secure.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- GitHub Actions won’t persist a background process across separate `run` steps—consider combining the `anvil … &` startup and `pnpm test` into one step or defining Anvil as a service so the fork node is available during tests.
- Avoid hard-coding your Infura URL; pull `INFURA_PROJECT_ID` from GitHub Secrets and inject it via an `env:` declaration to keep credentials secure.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
CI: