Skip to content

Comments

Update tests.yml#39

Merged
Dargon789 merged 1 commit intomasterfrom
Dargon789-patch-1
Jun 12, 2025
Merged

Update tests.yml#39
Dargon789 merged 1 commit intomasterfrom
Dargon789-patch-1

Conversation

@Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Jun 12, 2025

Summary by Sourcery

Update GitHub Actions tests workflow to use official Node.js setup, enable pnpm caching and retries, streamline build job, and integrate Foundry/Anvil for on-chain testing

CI:

  • Replace custom install-dependencies step with actions/setup-node@v4, actions/cache@v4, and pnpm install with retry settings
  • Remove the install-dependencies action from the build job
  • Install Foundry nightly and launch an Arbitrum Anvil fork before running pnpm tests

Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
@codesandbox
Copy link

codesandbox bot commented Jun 12, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel

This comment was marked as outdated.

@sourcery-ai
Copy link

sourcery-ai bot commented Jun 12, 2025

Reviewer's Guide

This PR refactors the CI workflow to replace a custom install action with official setup-node and caching steps, streamline the build job, and enhance the tests job by installing Foundry and starting Anvil against a new fork URL before running pnpm tests.

File-Level Changes

Change Details Files
Overhauled dependency installation in the install job
  • Replaced custom install-dependencies action with actions/setup-node@v4
  • Added actions/cache@v4 for pnpm store caching using pnpm-lock.yaml as key
  • Configured pnpm fetch retries and factors
  • Ran pnpm install instead of custom action
.github/workflows/tests.yml
Simplified build job
  • Removed redundant custom install-dependencies step
  • Retained checkout and added direct pnpm build command
.github/workflows/tests.yml
Enhanced tests job with Foundry and updated Anvil setup
  • Kept checkout and custom dependency step
  • Installed Foundry toolchain (nightly) via foundry-rs/foundry-toolchain@v1
  • Started Anvil in background pointing to new fork URL
  • Executed pnpm test after setup
.github/workflows/tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Dargon789 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Dargon789 Dargon789 merged commit d0b0664 into master Jun 12, 2025
10 of 12 checks passed
@Dargon789 Dargon789 deleted the Dargon789-patch-1 branch June 12, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant