Skip to content

Comments

fix: update#84

Merged
Dargon789 merged 7 commits intomaster-ceb95d4from
master
Nov 14, 2025
Merged

fix: update#84
Dargon789 merged 7 commits intomaster-ceb95d4from
master

Conversation

@Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Nov 14, 2025

Summary by Sourcery

Enhance ID generation security, bump happy-dom dependency to 20.0.2, and introduce a SECURITY.md policy document

Enhancements:

  • Switch to crypto.getRandomValues for secure random ID generation

Build:

  • Upgrade happy-dom to 20.0.2 in dapp-client and wdk packages

Documentation:

  • Add SECURITY.md outlining supported versions and vulnerability reporting process

Dargon789 and others added 5 commits October 7, 2025 21:04
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Bumps the npm_and_yarn group with 1 update in the / directory: [happy-dom](https://github.com/capricorn86/happy-dom).
Bumps the npm_and_yarn group with 1 update in the /packages/wallet/dapp-client directory: [happy-dom](https://github.com/capricorn86/happy-dom).
Bumps the npm_and_yarn group with 1 update in the /packages/wallet/wdk directory: [happy-dom](https://github.com/capricorn86/happy-dom).


Updates `happy-dom` from 17.6.3 to 20.0.0
- [Release notes](https://github.com/capricorn86/happy-dom/releases)
- [Commits](capricorn86/happy-dom@v17.6.3...v20.0.0)

Updates `happy-dom` from 17.6.3 to 20.0.0
- [Release notes](https://github.com/capricorn86/happy-dom/releases)
- [Commits](capricorn86/happy-dom@v17.6.3...v20.0.0)

Updates `happy-dom` from 17.6.3 to 20.0.0
- [Release notes](https://github.com/capricorn86/happy-dom/releases)
- [Commits](capricorn86/happy-dom@v17.6.3...v20.0.0)

---
updated-dependencies:
- dependency-name: happy-dom
  dependency-version: 20.0.0
  dependency-type: direct:development
  dependency-group: npm_and_yarn
- dependency-name: happy-dom
  dependency-version: 20.0.0
  dependency-type: direct:development
  dependency-group: npm_and_yarn
- dependency-name: happy-dom
  dependency-version: 20.0.0
  dependency-type: direct:development
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps the npm_and_yarn group with 1 update in the / directory: [happy-dom](https://github.com/capricorn86/happy-dom).


Updates `happy-dom` from 20.0.0 to 20.0.2
- [Release notes](https://github.com/capricorn86/happy-dom/releases)
- [Commits](capricorn86/happy-dom@v20.0.0...v20.0.2)

---
updated-dependencies:
- dependency-name: happy-dom
  dependency-version: 20.0.2
  dependency-type: direct:development
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Create SECURITY.md for security policy

Add a security policy document outlining supported versions and vulnerability reporting.

Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>

* Update SECURITY.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>

* Update SECURITY.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>

---------

Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
@codesandbox
Copy link

codesandbox bot commented Nov 14, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sourcery-ai
Copy link

sourcery-ai bot commented Nov 14, 2025

Reviewer's Guide

Implements cryptographically secure ID generation, upgrades happy-dom to v20.0.2 in wallet packages, and adds a SECURITY.md with the project’s security support policy and reporting process.

Class diagram for updated DappTransport.generateId() method

classDiagram
class DappTransport {
  +generateId(): string
  - Old: Math.random()
  + New: window.crypto.getRandomValues(array: Uint32Array)
}
DappTransport : +generateId() uses window.crypto.getRandomValues
Loading

File-Level Changes

Change Details Files
Switch ID generation from Math.random to crypto.getRandomValues
  • Removed Math.random-based substring generation
  • Initialized a Uint32Array and populated it with crypto.getRandomValues
  • Converted the random value to base-36 and composed the ID string
packages/wallet/dapp-client/src/DappTransport.ts
Bump happy-dom dependency to v20.0.2
  • Updated happy-dom version in dapp-client’s package.json
  • Updated happy-dom version in wdk’s package.json
packages/wallet/dapp-client/package.json
packages/wallet/wdk/package.json
Add SECURITY.md with support and reporting guidelines
  • Created SECURITY.md outlining supported versions table
  • Defined the vulnerability reporting email and expected response timeline
SECURITY.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@vercel
Copy link

vercel bot commented Nov 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sequence-js-web Ready Ready Preview Comment Nov 14, 2025 9:09am
sequence.js Ready Ready Preview Comment Nov 14, 2025 9:09am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
sequence-js-docs Skipped Skipped Nov 14, 2025 9:09am

@snyk-io
Copy link

snyk-io bot commented Nov 14, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@gemini-code-assist
Copy link

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on bolstering the project's security posture by introducing a formal security policy and enhancing the cryptographic strength of ID generation. It also includes routine dependency updates to keep the project's libraries current and secure.

Highlights

  • Security Policy: A new SECURITY.md file has been added to the repository, outlining supported versions and the process for reporting vulnerabilities.
  • Enhanced Randomness: The generateId method in DappTransport.ts has been updated to use window.crypto.getRandomValues for cryptographically secure ID generation, replacing the less secure Math.random().
  • Dependency Updates: The happy-dom dependency has been upgraded from version 17.2.2 to 20.0.2 in both dapp-client and wdk packages. The pnpm-lock.yaml file has been updated to reflect this and other related dependency changes, including @types/node and the removal of webidl-conversions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

sourcery-ai[bot]
sourcery-ai bot previously approved these changes Nov 14, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Add a fallback for environments without window.crypto (e.g. Node) so generateId still works universally.
  • Consider normalizing the random string to a fixed length (e.g. pad or truncate) to maintain consistent ID formats.
  • After bumping happy-dom in package.json, regenerate the pnpm-lock.yaml to keep your lockfile in sync.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Add a fallback for environments without window.crypto (e.g. Node) so generateId still works universally.
- Consider normalizing the random string to a fixed length (e.g. pad or truncate) to maintain consistent ID formats.
- After bumping happy-dom in package.json, regenerate the pnpm-lock.yaml to keep your lockfile in sync.

## Individual Comments

### Comment 1
<location> `SECURITY.md:3-8` </location>
<code_context>
+
+## Supported Versions
+
+Use this section to tell people about which versions of your project are
+currently being supported with security updates.
+
+| Version | Supported          |
</code_context>

<issue_to_address>
**suggestion:** Consider removing or rephrasing the template instruction about supported versions.

The sentence appears to be a template instruction and should be removed or rewritten for end users.

```suggestion
## Supported Versions

The following table lists which versions of this project currently receive security updates.

| Version | Supported          |
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances security by using crypto.getRandomValues for ID generation, bumps the happy-dom dependency, and adds a SECURITY.md file. The changes are positive, particularly the move to a cryptographically secure random number generator. I've provided a couple of suggestions for improvement: one to refine the new ID generation logic to ensure a fixed length and higher entropy, and another to populate the placeholder content in the new SECURITY.md file.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
@Dargon789 Dargon789 added bug Something isn't working documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right question Further information is requested wontfix This will not be worked on dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Nov 17, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Nov 17, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Hardhat Nov 17, 2025
@Dargon789 Dargon789 linked an issue Nov 24, 2025 that may be closed by this pull request
@Dargon789 Dargon789 linked an issue Dec 22, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right javascript Pull requests that update javascript code question Further information is requested wontfix This will not be worked on

Projects

Archived in project
Status: Done

1 participant