Skip to content

Comments

fix: update (#84)#85

Closed
Dargon789 wants to merge 0 commit intomasterfrom
master-ceb95d4
Closed

fix: update (#84)#85
Dargon789 wants to merge 0 commit intomasterfrom
master-ceb95d4

Conversation

@Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Nov 14, 2025

  • Potential fix for code scanning alert no. 84: Insecure randomness

  • Bump the npm_and_yarn group across 3 directories with 1 update

Bumps the npm_and_yarn group with 1 update in the / directory: happy-dom.
Bumps the npm_and_yarn group with 1 update in the /packages/wallet/dapp-client directory: happy-dom.
Bumps the npm_and_yarn group with 1 update in the /packages/wallet/wdk directory: happy-dom.

Updates happy-dom from 17.6.3 to 20.0.0

Updates happy-dom from 17.6.3 to 20.0.0

Updates happy-dom from 17.6.3 to 20.0.0


updated-dependencies:

  • dependency-name: happy-dom dependency-version: 20.0.0 dependency-type: direct:development dependency-group: npm_and_yarn
  • dependency-name: happy-dom dependency-version: 20.0.0 dependency-type: direct:development dependency-group: npm_and_yarn
  • dependency-name: happy-dom dependency-version: 20.0.0 dependency-type: direct:development dependency-group: npm_and_yarn ...

Bumps the npm_and_yarn group with 1 update in the / directory: happy-dom.

Updates happy-dom from 20.0.0 to 20.0.2


updated-dependencies:

  • dependency-name: happy-dom dependency-version: 20.0.2 dependency-type: direct:development dependency-group: npm_and_yarn ...

Add a security policy document outlining supported versions and vulnerability reporting.

  • Update SECURITY.md

  • Update SECURITY.md


  • Update SECURITY.md

  • Update SECURITY.md

  • Update packages/wallet/dapp-client/src/DappTransport.ts


Enhance ID generation security, bump happy-dom dependency to 20.0.2, and introduce a SECURITY.md policy document

Enhancements:

Switch to crypto.getRandomValues for secure random ID generation Build:

Upgrade happy-dom to 20.0.2 in dapp-client and wdk packages Documentation:

Add SECURITY.md outlining supported versions and vulnerability reporting process

Summary by Sourcery

Improve security by switching to a cryptographically secure ID generator, bumping happy-dom dependencies to 20.0.2, and introducing a SECURITY.md policy document

Enhancements:

  • Use crypto.getRandomValues for cryptographically secure ID generation in DappTransport

Build:

  • Upgrade happy-dom to version 20.0.2 in dapp-client and wdk packages

Documentation:

  • Add SECURITY.md outlining supported versions and vulnerability reporting policy

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@codesandbox
Copy link

codesandbox bot commented Nov 14, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@vercel
Copy link

vercel bot commented Nov 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
sequence.js Ready Ready Preview Nov 14, 2025 9:19am

@sourcery-ai
Copy link

sourcery-ai bot commented Nov 14, 2025

Reviewer's Guide

Enhance security and dependency management by migrating ID generation to the Web Crypto API, upgrading happy-dom to v20.0.2 across relevant packages, and adding a SECURITY.md policy document.

Class diagram for updated DappTransport ID generation

classDiagram
class DappTransport {
  +generateId(): string
}
DappTransport : -generateId() now uses crypto.getRandomValues for secure randomness
Loading

File-Level Changes

Change Details Files
Switch to cryptographically secure random ID generation in DappTransport
  • Replaced Math.random based ID with crypto.getRandomValues
  • Created a Uint32Array buffer for random data
  • Concatenated and trimmed random values into a 9-character string
packages/wallet/dapp-client/src/DappTransport.ts
Upgrade happy-dom dependency to version 20.0.2
  • Bumped happy-dom version in dapp-client package.json
  • Bumped happy-dom version in wdk package.json
  • Regenerated pnpm lockfile
packages/wallet/dapp-client/package.json
packages/wallet/wdk/package.json
pnpm-lock.yaml
Introduce SECURITY.md policy document for vulnerability reporting
  • Created SECURITY.md with supported versions table
  • Documented reporting process and response timeline
SECURITY.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io
Copy link

snyk-io bot commented Nov 14, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@gemini-code-assist
Copy link

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces crucial security enhancements and dependency updates to the project. It resolves a code scanning alert by implementing cryptographically secure random ID generation, upgrades the happy-dom library to its latest stable version, and establishes a formal security policy to guide vulnerability reporting and supported project versions.

Highlights

  • Enhanced ID Generation Security: The generateId function in DappTransport.ts now utilizes window.crypto.getRandomValues instead of Math.random() to produce cryptographically secure random IDs, directly addressing a potential security vulnerability related to insecure randomness.
  • Dependency Update: The happy-dom dependency has been upgraded from version 17.6.3 to 20.0.2 across multiple package.json files within the dapp-client and wdk packages, along with corresponding updates in the pnpm-lock.yaml.
  • New Security Policy Document: A SECURITY.md file has been added to the repository, which formally outlines the project's supported versions and provides clear instructions for reporting security vulnerabilities, enhancing the project's security posture.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces significant security enhancements by switching to crypto.getRandomValues for ID generation, which directly addresses a code scanning alert related to insecure randomness. Additionally, it updates the happy-dom dependency to version 20.0.2 across multiple packages and adds a comprehensive SECURITY.md policy document. These changes collectively improve the project's security posture and maintainability.

@Dargon789 Dargon789 self-assigned this Nov 14, 2025
@Dargon789 Dargon789 added bug Something isn't working documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right question Further information is requested wontfix This will not be worked on dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Nov 14, 2025
@github-project-automation github-project-automation bot moved this to Done in Hardhat Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right javascript Pull requests that update javascript code question Further information is requested wontfix This will not be worked on

Projects

Archived in project
Status: Done

1 participant