Fera rework by FalloutFalcon · Pull Request #489 · DarkPack13/SecondCity

FalloutFalcon · 2026-01-07T14:07:12Z

About The Pull Request

Part 1 of the fera rework: Most garou content minus 1-5 gifts
Requires #407, #657
Continuation of #122
Should fix #484
Fixes bloodpool part of #513

Playerfacing: Implements garou based upon the following document: https://docs.google.com/document/d/1ZhMsB3mToUq5Q7dk86YdyvcRfaPpq2sOxYeZKwCNEQU/edit?tab=t.0#heading=h.axkr5oqixflc
Codewise: Aims to overhaul fera onto the new splat framework and future proof the handling of splats to prevent stuff like corax just being a secret tribe of the garou and other extremely jank code.

Why It's Good For The Game

Better code c:

Alteast on Apoc, we already have plans for the bear and fox fera very soon, we need good bones for that.

Changelog

🆑
add: Readds garou
add: Moon phase is calculated mostly accurately based on in-game day
add: Rage gained from looking at the moon is now based on phase
add: Howl emote that can be used by dogs, dogs (garou), or dogs (gangrel)
add: Re-implements 1 gift for each auspice
fix: Blood-pool icon is properly updated when its added to you
admin: Adjustments to stats and important prefs can be properly viewed in the log viewers
balance: Makes generic helpers to represent "Heal this amount of "dots" of damage". Gives this to garou at 1 dot every "turn" (5 seconds at the time of writing)
balance: Punching basic mobs and humans now calculate damage based on strength
balance: W20 silver bullet handling. No agg damage in breed form. 5 bullets are a guaranteed loss of gnosis.
/:cl:

code/__DEFINES/~darkpack/auras.dm

code/game/say.dm

code/modules/mob/living/basic/basic_defense.dm

code/modules/mob/living/carbon/human/_species.dm

code/modules/mob/living/carbon/human/life.dm

modular_darkpack/modules/werewolf_the_apocalypse/code/splats/fera_species.dm

modular_darkpack/modules/werewolf_the_apocalypse/code/splats/pref_lore.dm

modular_darkpack/modules/werewolf_the_apocalypse/code/hud.dm

modular_darkpack/modules/werewolf_the_apocalypse/readme.md

XeonMations · 2026-02-08T13:06:22Z

On another note, please keep your random changes to their perspective PRs. You shouldn't be changing v20 to V20 in this PR, as an example.

FalloutFalcon · 2026-02-08T15:22:49Z

On another note, please keep your random changes to their perspective PRs. You shouldn't be changing v20 to V20 in this PR, as an example.

v20 and V20 was used in many parts of the code. It was a nothing burger comment syntax change not worth making its own PR for but was loosely relevant to mine as i was adding alot of new V20 and W20 references comments

…o fera-rework

chazzyjazzy

ok - im gonna need to review this like, two more times, maybe one. i gave it a read through and understood most of what was going on, but im getting the feeling that i missed something and i was exhausted enough to just hit accept but that wont happen

chazzyjazzy · 2026-02-07T10:23:56Z

code/modules/mob/living/basic/basic_defense.dm

+	// DARKPACK EDIT CHANGE START - STORYTELLER_STATS
+	// ROLL TO HIT // DARKPACK TODO
+	// var/successes = SSroll.storyteller_roll(user.st_get_stat(STAT_DEXTERITY) + user.st_get_stat(STAT_BRAWL), 6, list(user), user)
+	// ROLL TO DAMAGE
+	var/damage_output
+	if(HAS_TRAIT(user, TRAIT_PERFECT_ATTACKER))
+		damage_output = user.st_get_stat(STAT_STRENGTH)
+	else
+		damage_output = SSroll.storyteller_roll(user.st_get_stat(STAT_STRENGTH), 6, list(user), user, TRUE)
+	var/damage = (basic_mob_flags & IMMUNE_TO_FISTS) ? 0 : damage_output TTRPG_DAMAGE // DARKPACK EDIT CHANGE - STORYTELLER_STATS


Disclaimer I am drunk but shouldnt it be dexterity to see if they hit?

Like, the agility or speed or whatever if they miss

It should be! It soft requires #633 so i can make the handling a bit cleaner and make sure this doesn't spam your chat.

#633 has been merged

chazzyjazzy · 2026-02-12T20:18:46Z

modular_darkpack/master_files/code/modules/mob/living/carbon/human/_species.dm

+
+/datum/species
+	/// Used in get_generic_name to replace gender
+	var/visable_gender_override


typo, visible

chazzyjazzy · 2026-02-12T20:21:03Z

modular_darkpack/modules/werewolf_the_apocalypse/code/splats/examine_text.dm

@@ -0,0 +1,46 @@
+/datum/splat/werewolf/proc/examine_other_human(mob/living/carbon/examined)


perhaps some wyrmtaint stuff here?

wyrmtaint still isn't really possible to get because we dont have da quirk.

modular_darkpack/modules/werewolf_the_apocalypse/code/subsplats/tribes/garou.dm

chazzyjazzy · 2026-02-12T21:45:15Z

modular_darkpack/modules/werewolf_the_apocalypse/code/subsplats/tribes/_tribe.dm

+/**
+ * Gives the human a tribe, applying
+ * on_gain effects and post_gain effects if the
+ * parameter is true. Can also remove tribes
+ * with or without a replacement, and apply
+ * on_lose effects. Will have no effect the human
+ * is being given the tribe it already has.
+ *
+ * Arguments:
+ * * setting_tribe - Typepath or tribe singleton to give to the human
+ * * joining_round - If this tribe is being given at roundstart and should call on_join_round
+ */
+/mob/living/carbon/human/proc/set_fera_tribe(setting_tribe, joining_round)


why is this on human? can't it be on living?

parody with clans. no strong reason atm for either type..

chazzyjazzy · 2026-02-12T21:51:59Z

modular_darkpack/modules/werewolf_the_apocalypse/code/splats/renown.dm

+/datum/splat/werewolf/proc/auspice_rank_check()
+	return auspice.rank_requirments(renown)
+
+// Pretty iffy on this. This could likely just be moved onto the splat itself so corax and other breeds can override it.


Yes that is probably for the best but please do it another pr because this one is already so long

chazzyjazzy · 2026-02-12T21:56:00Z

modular_darkpack/modules/werewolf_the_apocalypse/code/splats/pref_lore.dm

+// DARKPACK TODO - WEREWOLF - (len lore)
+/datum/splat/werewolf/kinfolk/get_splat_description()
+	return "Lorem Ipsum"
+


Should probably get this and the other three filled out esp while waiting for reviews (since i dont think i should be the only review on this its so long), TFN has lore people who can help like Icey or Justice who have always helped me, or u can ask atla who made the doc

the "len" mentioned in the comment is atlamillia.

chazzyjazzy · 2026-02-12T22:00:17Z

modular_darkpack/modules/werewolf_the_apocalypse/code/splats/transformation.dm

+/datum/splat/werewolf/shifter/proc/get_breed_form_species()
+	return breed_form?.breed_species
+	/*
+	if(!owner?.dna)
+		return
+	return GLOB.breed_forms_list[owner.dna.features[FEATURE_FERA_BREED]]
+	*/


can probably delete that comment since get_breed_form_species seems like its doing its job, the early return if dna doesnt exist may be helpful tho

yep! this used to be how xeon's code handled breeds but i ditched that.

chazzyjazzy · 2026-02-12T22:01:33Z

modular_darkpack/modules/werewolf_the_apocalypse/code/splats/is_werewolf_helpers.dm

+/**
+ * If the character is any kind of fera or kinfolk creature, named after the game line
+ */
+/proc/iswerewolfsplat(mob/character)


shouldnt all these args in this file be mob/living since splats can only exist on mob/living

get_splat notibly exists on /mob/ atm...

parody with /proc/isvampiresplat(mob/character) which likely only exists because of its previous form as a define.
It would mean reworking all of those as well for sanity.

…s/tribes/garou.dm Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>

…CityF into fera-rework

…o fera-rework

XeonMations added 30 commits October 16, 2025 19:43

Update _transformation.dm

3976745

Update todo.md

5ee24fe

Update garou_species.dm

14a3cb2

aaaaaa

f83cead

RAHHHHHHHHHHH

4987b9c

transformations completed!

6e06f78

what is THAT

56dfa7c

Update _transformation.dm

8c88f8d

Update _transformation.dm

386a5a4

Create readme.md

753547b

crinos

13f99aa

icons.

40694c6

Update _transformation.dm

bada574

Update fera_update_icons.dm

1a5a233

Update _transformation.dm

4c1faab

Update _transformation.dm

4d79036

stupid fucking werewolves and their shapeshifting

96a9602

aaaa

a72e1a1

Update crinos.dm

2f920c8

STUPID FUCKING WOLVES

d3047e6

Update _transformation.dm

5ead7a3

skip_animation = TRUE

86b5e37

Update _shapeshift.dm

7abe00a

Merge branch 'master' into garou

d6da228

lupus

3c9f137

RAHHH

523c250

remove alert

b124484

Update lupus.dm

93b7171

Update fera_update_icons.dm

792b461

Update fera_update_icons.dm

40495e0

dwinters99 mentioned this pull request Feb 8, 2026

some kinds of wounds aren't healed by dog healing #649

Closed

XeonMations requested changes Feb 8, 2026

View reviewed changes

reviews

f78360e

github-actions bot requested a review from XeonMations February 8, 2026 15:22

FalloutFalcon and others added 14 commits February 8, 2026 09:35

reverts the species screenshot ignore thing

0a93e67

yea

7fee236

veil breaching forms

20bea27

fix

1a9c1d0

fix...

571861a

kinfolk cant make out howl info

d7ae5be

wolves are wolves

08ff709

spaces in some define names

45e2304

acctually looked at the gifts winter wrote.

2999dd8

Merge branch 'master' of https://github.com/DarkPack13/SecondCity int…

36554b9

…o fera-rework

Merge branch 'master' of https://github.com/DarkPack13/SecondCity int…

4431f0a

…o fera-rework

wounds heal first

3505916

no while dead.

a8b9814

Merge branch 'master' into fera-rework

25db34c

chazzyjazzy requested changes Feb 12, 2026

View reviewed changes

FalloutFalcon and others added 3 commits February 13, 2026 09:53

Update modular_darkpack/modules/werewolf_the_apocalypse/code/subsplat…

1c46f4b

…s/tribes/garou.dm Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>

some review

a3b1fe7

Merge branch 'fera-rework' of https://github.com/FalloutFalcon/Second…

f4979bf

…CityF into fera-rework

FalloutFalcon requested a review from chazzyjazzy February 13, 2026 15:59

FalloutFalcon added 5 commits February 14, 2026 13:04

Merge branch 'master' of https://github.com/DarkPack13/SecondCity int…

7fa69fe

…o fera-rework

quick fixes for my dice pr

04fefa5

stuff

a71f6fd

yea

b013f08

yea

fd209aa

		@@ -0,0 +1,46 @@
		/datum/splat/werewolf/proc/examine_other_human(mob/living/carbon/examined)

Conversation

FalloutFalcon commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

About The Pull Request

Why It's Good For The Game

Changelog

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

XeonMations commented Feb 8, 2026

Uh oh!

FalloutFalcon commented Feb 8, 2026

Uh oh!

chazzyjazzy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FalloutFalcon Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

FalloutFalcon commented Jan 7, 2026 •

edited

Loading

FalloutFalcon Feb 13, 2026 •

edited

Loading