Conversation
|
I also followed the same basic structure as #514 I should say |
|
opening for review cuz all im waiting for now is sprites from that animal bomby |
|
i edited ur changelog to credit baron |
Oh thanks I forgot that mb |
code/modules/admin/verbs/ert.dm
Outdated
| ertemplate = new ertemplate | ||
| else | ||
| ertemplate = new /datum/ert/centcom_official | ||
| ertemplate = new /datum/ert/darkpack/swat // DARKPACK EDIT CHANGE - Original : ertemplate = new /datum/ert/centcom_official |
There was a problem hiding this comment.
worlds biggest nitpick:
I dont think that's the correct comment syntax c:
Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
|
ping me for a review once the other ert pr is in. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~7 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the /tg/station Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself. |
| @@ -1,3 +1,4 @@ | |||
| // should i delete this since summon-ert verb handles alot of this | |||
There was a problem hiding this comment.
Yea this file really shouldn't exist. It should be moved to the ert code file at the very least.

About The Pull Request
This PR reimplements NG and Swat to be used with the Summon-ERT verb
before you ask, yes NG is very fucking powerful, if they need to be summoned, SWAT should probably go first and die
it adds multiple roles allowed for SWAT and NG, including
SWAT
NG
i also made it so that these guys finally spawn with police keys
Why It's Good For The Game
human stuff, reimplemented ERTs to work with modern /tg/ verb, consequence for breaking the masquerade muhahaha
Changelog
🆑 chazzyjazzy, INFARED_BARON
add: reimplements SWAT and NG ERTs with new roles
/:cl: