Conversation
|
fixes #484 tho fera rework does as well lol. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
FalloutFalcon
left a comment
There was a problem hiding this comment.
Why is this pr trying to move guestbook/generic names down to the living level when anything outside of humans cant be expected to have a unique name to start.
real_name is a variable on the base mob level, so anything can have a unique name to start. One use case is fera wolves. |
fera wolves are humans lmao. But what im saying is if multiple mobs have the same real_name (most non-humans) then if you try and guestbook one it guestbooks all of them. |
the system only works if that mob has a mind. also whAT DO YOU MEAN FERA WOLVES ARE HUMANS.................. |
About The Pull Request
Fixed names not updating when they should be.
Why It's Good For The Game
bugfix good
Changelog
🆑
fix: Fixed some guestbook related bugs
/:cl: