Skip to content

Various guestbook fixes#612

Draft
XeonMations wants to merge 2 commits intoDarkPack13:masterfrom
XeonMations:guestbook-fixes
Draft

Various guestbook fixes#612
XeonMations wants to merge 2 commits intoDarkPack13:masterfrom
XeonMations:guestbook-fixes

Conversation

@XeonMations
Copy link
Collaborator

@XeonMations XeonMations commented Jan 31, 2026

@FalloutFalcon
Copy link
Member

fixes #484 tho fera rework does as well lol.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2026

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale label Feb 8, 2026
@XeonMations XeonMations removed the Stale label Feb 8, 2026
Copy link
Member

@FalloutFalcon FalloutFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this pr trying to move guestbook/generic names down to the living level when anything outside of humans cant be expected to have a unique name to start.

@XeonMations
Copy link
Collaborator Author

Why is this pr trying to move guestbook/generic names down to the living level when anything outside of humans cant be expected to have a unique name to start.

real_name is a variable on the base mob level, so anything can have a unique name to start. One use case is fera wolves.

@FalloutFalcon
Copy link
Member

Why is this pr trying to move guestbook/generic names down to the living level when anything outside of humans cant be expected to have a unique name to start.

real_name is a variable on the base mob level, so anything can have a unique name to start. One use case is fera wolves.

fera wolves are humans lmao. But what im saying is if multiple mobs have the same real_name (most non-humans) then if you try and guestbook one it guestbooks all of them.

@XeonMations
Copy link
Collaborator Author

Why is this pr trying to move guestbook/generic names down to the living level when anything outside of humans cant be expected to have a unique name to start.

real_name is a variable on the base mob level, so anything can have a unique name to start. One use case is fera wolves.

fera wolves are humans lmao. But what im saying is if multiple mobs have the same real_name (most non-humans) then if you try and guestbook one it guestbooks all of them.

the system only works if that mob has a mind.

also whAT DO YOU MEAN FERA WOLVES ARE HUMANS..................

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants