Open
Conversation
Contributor
|
Linter failure is pool cue missing worn icon state |
chazzyjazzy
approved these changes
Feb 15, 2026
Contributor
chazzyjazzy
left a comment
chazzyjazzy
left a comment
There was a problem hiding this comment.
really solid coding, this should probably be the gold standard as an intro to byond coding
Comment on lines
161
to
167
| /obj/structure/table/wood/billiard/proc/sink_ball(mob/living/user, target_ball_type, accuracy_result, amount_to_hit_result, obj/item/pool_ball/sunk_ball) | ||
| if(!sunk_ball) | ||
| sunk_ball = random_ball(target_ball_type, accuracy_result) | ||
|
|
||
| if(!sunk_ball) | ||
| //user.visible_message(span_warning("[user] MISSED"), span_warning("You missed")) | ||
| return |
Contributor
There was a problem hiding this comment.
correct me if im wrong but 165 166 and 167 will only ever run if there are literally zero balls on the table so the comment can probably be deleted but the conditional should most likely remain?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Functioning Pool!
Tables now spawn with a full set of balls and some pool cues. Attacking the table with a cue lets you choose a ball and then rolls your stats to see what you hit.
2026-02-15.09-44-05.mp4
Why It's Good For The Game
excellent barrp material.
A fun little use for streetwise as its missing a way to express it at the moment
Changelog
🆑
add: Pool tables has balls and cue's that creates a little 8-Ball mini-game.
/:cl: