Added time and file size options for FileWriter#151
Open
RobbieLePommie wants to merge 1 commit intoDarkRiftNetworking:masterfrom
Open
Added time and file size options for FileWriter#151RobbieLePommie wants to merge 1 commit intoDarkRiftNetworking:masterfrom
RobbieLePommie wants to merge 1 commit intoDarkRiftNetworking:masterfrom
Conversation
Example usage: <settings file="Logs/{0:yyyy-MM-dd}/{0:HH-mm-ss tt}.txt" maxsize="10" maxtime="86400" />
Contributor
|
Going to close and reopen to trigger tests to run (I had to change an organization setting). |
JamJar00
approved these changes
Aug 15, 2023
| // Get the maximum size (in MB, convert to bytes) | ||
| try | ||
| { | ||
| int logMaxSizeMB = int.Parse(logWriterLoadData.Settings["maxSize"] ?? "100"); |
Member
There was a problem hiding this comment.
Would be good to have the property named 'maxSizeMb' so it's absolutely clear what units it uses
| // Get the maximum time before rotation (in seconds) | ||
| try | ||
| { | ||
| LogMaxTimeSeconds = int.Parse(logWriterLoadData.Settings["maxTime"] ?? "86400"); |
Member
There was a problem hiding this comment.
Would be good to have the property named 'maxTimeSeconds' so it's absolutely clear what units it uses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example usage: