Skip to content

Fix async-metrics integration-test flake (blank log line) #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Strech merged 1 commit into from
Aug 5, 2026
Merged

Fix async-metrics integration-test flake (blank log line) #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion integration_tests/snapshots/logs/appsec-request_ruby32.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
Expand Down
1 change: 0 additions & 1 deletion integration_tests/snapshots/logs/appsec-request_ruby33.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
Expand Down
1 change: 0 additions & 1 deletion integration_tests/snapshots/logs/appsec-request_ruby34.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
Expand Down
1 change: 0 additions & 1 deletion integration_tests/snapshots/logs/appsec-request_ruby40.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
Expand Down
1 change: 0 additions & 1 deletion integration_tests/snapshots/logs/async-metrics_ruby32.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
Expand Down
1 change: 0 additions & 1 deletion integration_tests/snapshots/logs/async-metrics_ruby33.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
Expand Down
1 change: 0 additions & 1 deletion integration_tests/snapshots/logs/async-metrics_ruby34.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
Expand Down
1 change: 0 additions & 1 deletion integration_tests/snapshots/logs/async-metrics_ruby40.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
Expand Down
1 change: 0 additions & 1 deletion integration_tests/snapshots/logs/http-requests_ruby32.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
Expand Down
1 change: 0 additions & 1 deletion integration_tests/snapshots/logs/http-requests_ruby33.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
Expand Down
1 change: 0 additions & 1 deletion integration_tests/snapshots/logs/http-requests_ruby34.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
Expand Down
1 change: 0 additions & 1 deletion integration_tests/snapshots/logs/http-requests_ruby40.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
Expand Down
1 change: 0 additions & 1 deletion integration_tests/snapshots/logs/process-input-traced_ruby32.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
Expand Down
1 change: 0 additions & 1 deletion integration_tests/snapshots/logs/process-input-traced_ruby33.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
Expand Down
1 change: 0 additions & 1 deletion integration_tests/snapshots/logs/process-input-traced_ruby34.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
Expand Down
1 change: 0 additions & 1 deletion integration_tests/snapshots/logs/process-input-traced_ruby40.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
Expand Down
1 change: 0 additions & 1 deletion integration_tests/snapshots/logs/sync-metrics_ruby32.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
Expand Down
1 change: 0 additions & 1 deletion integration_tests/snapshots/logs/sync-metrics_ruby33.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
Expand Down
1 change: 0 additions & 1 deletion integration_tests/snapshots/logs/sync-metrics_ruby34.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
Expand Down
1 change: 0 additions & 1 deletion integration_tests/snapshots/logs/sync-metrics_ruby40.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
END Duration: XXXX ms Memory Used: XXXX MB
Expand Down
3 changes: 3 additions & 0 deletions scripts/run_integration_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,9 @@ for handler_name in "${LAMBDA_HANDLERS[@]}"; do
perl -p -e 's/(D, \[)( )?[a-zA-Z0-9\.\:\s\-\#]+/\1XXXX/g' |
# Filter out INIT runtime logs
perl -p -e "s/INIT_START.*//g" |
# NOTE: Async metric flush emits a non-deterministic empty log line.
# We drop blank lines so the comparison doesn't flake on it
sed '/^$/d' |
sort
)

Expand Down