-
Notifications
You must be signed in to change notification settings - Fork 75
Support non-ascii GraphQL headers #3041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1cde01 to
1f03bde
Compare
|
🎯 Code Coverage 🔗 Commit SHA: a29addc | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3041 +/- ##
===========================================
- Coverage 71.23% 71.12% -0.11%
===========================================
Files 864 864
Lines 31604 31612 +8
Branches 5324 5327 +3
===========================================
- Hits 22510 22482 -28
- Misses 7582 7606 +24
- Partials 1512 1524 +12
🚀 New features to boost your workflow:
|
1f03bde to
48cb364
Compare
ambushwork
reviewed
Dec 9, 2025
...s/dd-sdk-android-okhttp/src/test/kotlin/com/datadog/android/okhttp/DatadogInterceptorTest.kt
Show resolved
Hide resolved
ambushwork
previously approved these changes
Dec 9, 2025
Member
|
Well done! |
ambushwork
previously approved these changes
Dec 10, 2025
0xnm
previously approved these changes
Dec 10, 2025
...-sdk-android-apollo/src/test/java/com/datadog/android/apollo/DatadogApolloInterceptorTest.kt
Outdated
Show resolved
Hide resolved
b924e5f to
a29addc
Compare
ambushwork
approved these changes
Dec 10, 2025
0xnm
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support GraphQL headers that are non-ascii by encoding payloads to base64 in the DatadogApolloInterceptor and decoding them in the DatadogInterceptor.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)