RFC: Drop usage of MJIT headers for Ruby 2.6 to 3.1 - #6135
Draft
ivoanjo wants to merge 5 commits into
Draft
Conversation
This pairs with unreleased changes in the `datadog-ruby_core_source` gem. I've checked all versions between 2.6.0 and 2.6.10 and all of them pass the profiler test suite without the mjit headers.
This pairs with unreleased changes in the `datadog-ruby_core_source` gem. I've checked all versions between 2.7.0 and 2.7.8 and all of them pass the profiler test suite without the mjit headers.
This pairs with unreleased changes in the `datadog-ruby_core_source` gem. I've checked all versions between 3.0.0 and 3.0.7 and all of them pass the profiler test suite without the mjit headers.
This pairs with unreleased changes in the `datadog-ruby_core_source` gem. I've checked all versions between 3.1.0 and 3.1.7 and all of them pass the profiler test suite without the mjit headers.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR pairs with DataDog/datadog-ruby_core_source#29 and switches Ruby 2.6 to 3.1 over to using vendored headers instead of the MJIT header.
Motivation:
We've been considering dropping our use of the MJIT headers, and just use the "vendored headers" approach for all Rubies. I've been using this branch to test it out.
Change log entry
None.
Additional Notes:
I've tested this change will all stable releases from Ruby 2.6.0 to 3.1.7. I've ran out of time before testing with the 3.2 series.
I did not yet clean up all the support code for the MJIT header.
This of course will need to be paired with a new release of the headers gem.
How to test the change?
This should actually pass CI as-is! And yes, if you check the logs during the building of the profiling extension, you'll see the headers are coming from the vendored copy, not the mjit header.