Skip to content

feat(capabilities)!: trait architecture http#1555

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 64 commits intomainfrom
jwiriath/capability-traits-architecture
Mar 31, 2026
Merged

feat(capabilities)!: trait architecture http#1555
gh-worker-dd-mergequeue-cf854d[bot] merged 64 commits intomainfrom
jwiriath/capability-traits-architecture

Conversation

@Aaalibaba42
Copy link
Copy Markdown
Contributor

What does this PR do?

Add capability trait architecture, and few native implementations.

Motivation

Ongoing effort to make libdatadog wasm compatible.

Additional Notes

In the long run, several other parts of the codebase ought to use these capabilities via the provided public structure, so that it can automagically choose the correct underlying implementation when compiling or not to wasm.

How to test the change?

I should add some tests...

@Aaalibaba42 Aaalibaba42 requested a review from a team as a code owner February 11, 2026 14:13
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 11, 2026

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

  • Base Branch: origin/main
  • PR Branch: origin/jwiriath/capability-traits-architecture

Summary by Rule

Rule Base Branch PR Branch Change
expect_used 3 3 No change (0%)
todo 2 2 No change (0%)
unwrap_used 18 18 No change (0%)
Total 23 23 No change (0%)

Annotation Counts by File

File Base Branch PR Branch Change
datadog-sidecar/src/service/agent_info.rs 4 4 No change (0%)
datadog-sidecar/src/service/tracing/trace_flusher.rs 1 1 No change (0%)
libdd-common/src/lib.rs 3 3 No change (0%)
libdd-data-pipeline/src/stats_exporter.rs 1 1 No change (0%)
libdd-data-pipeline/src/telemetry/mod.rs 1 1 No change (0%)
libdd-data-pipeline/src/trace_exporter/error.rs 1 1 No change (0%)
libdd-data-pipeline/src/trace_exporter/mod.rs 2 2 No change (0%)
libdd-telemetry/src/worker/http_client.rs 3 3 No change (0%)
libdd-trace-utils/src/send_data/mod.rs 5 5 No change (0%)
libdd-trace-utils/src/trace_utils.rs 2 2 No change (0%)

Annotation Stats by Crate

Crate Base Branch PR Branch Change
clippy-annotation-reporter 5 5 No change (0%)
datadog-ffe-ffi 1 1 No change (0%)
datadog-ipc 20 20 No change (0%)
datadog-live-debugger 6 6 No change (0%)
datadog-live-debugger-ffi 10 10 No change (0%)
datadog-profiling-replayer 4 4 No change (0%)
datadog-remote-config 3 3 No change (0%)
datadog-sidecar 55 55 No change (0%)
libdd-common 10 10 No change (0%)
libdd-common-ffi 12 12 No change (0%)
libdd-data-pipeline 5 5 No change (0%)
libdd-ddsketch 2 2 No change (0%)
libdd-dogstatsd-client 1 1 No change (0%)
libdd-profiling 13 13 No change (0%)
libdd-telemetry 19 19 No change (0%)
libdd-tinybytes 4 4 No change (0%)
libdd-trace-normalization 2 2 No change (0%)
libdd-trace-obfuscation 8 8 No change (0%)
libdd-trace-utils 15 15 No change (0%)
Total 195 195 No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 68.58345% with 224 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.52%. Comparing base (29678bd) to head (8be3832).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1555      +/-   ##
==========================================
+ Coverage   71.27%   71.52%   +0.24%     
==========================================
  Files         423      426       +3     
  Lines       66609    67026     +417     
==========================================
+ Hits        47476    47939     +463     
+ Misses      19133    19087      -46     
Components Coverage Δ
libdd-crashtracker 65.84% <ø> (+0.61%) ⬆️
libdd-crashtracker-ffi 34.09% <ø> (-0.39%) ⬇️
libdd-alloc 98.77% <ø> (ø)
libdd-data-pipeline 86.45% <75.18%> (-0.60%) ⬇️
libdd-data-pipeline-ffi 73.71% <ø> (+0.80%) ⬆️
libdd-common 79.70% <51.66%> (-0.49%) ⬇️
libdd-common-ffi 73.87% <ø> (ø)
libdd-telemetry 62.48% <0.00%> (ø)
libdd-telemetry-ffi 16.75% <ø> (ø)
libdd-dogstatsd-client 82.64% <ø> (ø)
datadog-ipc 72.56% <ø> (+2.24%) ⬆️
libdd-profiling 82.04% <ø> (+0.41%) ⬆️
libdd-profiling-ffi 64.94% <ø> (ø)
datadog-sidecar 31.35% <80.00%> (+1.17%) ⬆️
datdog-sidecar-ffi 11.84% <ø> (+5.32%) ⬆️
spawn-worker 54.69% <ø> (ø)
libdd-tinybytes 93.16% <ø> (ø)
libdd-trace-normalization 81.71% <ø> (ø)
libdd-trace-obfuscation 87.24% <ø> (ø)
libdd-trace-protobuf 68.25% <ø> (ø)
libdd-trace-utils 88.73% <69.23%> (+<0.01%) ⬆️
datadog-tracer-flare 86.88% <ø> (ø)
libdd-log 74.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Aaalibaba42 Aaalibaba42 force-pushed the jwiriath/capability-traits-architecture branch from 91daca7 to b727c1c Compare February 12, 2026 12:46
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts bot commented Feb 12, 2026

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.76 MB 8.76 MB +0% (+24 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 101.93 MB 101.95 MB +.02% (+28.61 KB) 🔍
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 118.83 MB 118.86 MB +.02% (+25.93 KB) 🔍
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.36 MB 11.36 MB -0% (-840 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 27.38 MB 27.39 MB +.02% (+7.00 KB) 🔍
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 80.69 KB 80.69 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 187.11 MB 187.69 MB +.31% (+600.00 KB) 🔍
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 925.19 MB 923.66 MB --.16% (-1.53 MB) 💪
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 9.06 MB 9.06 MB --.06% (-6.50 KB) 💪
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 80.69 KB 80.69 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 26.99 MB 26.98 MB --.02% (-8.00 KB) 💪
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 61.30 MB 61.29 MB --.01% (-9.59 KB) 💪
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 23.24 MB 23.23 MB --.02% (-6.00 KB) 💪
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 81.94 KB 81.94 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 191.65 MB 192.16 MB +.26% (+520.00 KB) 🔍
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 910.20 MB 908.86 MB --.14% (-1.34 MB) 💪
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.90 MB 6.90 MB --.07% (-5.00 KB) 💪
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 81.94 KB 81.94 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 29.11 MB 29.10 MB --.02% (-8.00 KB) 💪
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 57.67 MB 57.66 MB --.01% (-6.37 KB) 💪
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 88.77 MB 88.80 MB +.04% (+36.46 KB) 🔍
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 10.32 MB 10.32 MB --.03% (-3.97 KB) 💪
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 111.54 MB 111.57 MB +.02% (+28.53 KB) 🔍
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 12.07 MB 12.07 MB -0% (-552 B) 👌

@Aaalibaba42 Aaalibaba42 force-pushed the jwiriath/capability-traits-architecture branch from b727c1c to 624bdac Compare February 12, 2026 16:18
@Aaalibaba42 Aaalibaba42 marked this pull request as draft February 13, 2026 12:40
@Aaalibaba42 Aaalibaba42 force-pushed the jwiriath/capability-traits-architecture branch from a7a3941 to 3941878 Compare February 18, 2026 20:44
@datadog-official
Copy link
Copy Markdown

datadog-official bot commented Feb 18, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 68.58%
Overall Coverage: 71.52% (+0.10%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8be3832 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@Aaalibaba42 Aaalibaba42 force-pushed the jwiriath/capability-traits-architecture branch 2 times, most recently from c0843b5 to 280cf5d Compare February 19, 2026 14:16
@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Feb 19, 2026

Benchmarks

Comparison

Benchmark execution time: 2026-03-30 22:59:17

Comparing candidate commit 5a95934 in PR branch jwiriath/capability-traits-architecture with baseline commit 15860bb in branch main.

Found 0 performance improvements and 14 performance regressions! Performance is the same for 48 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:credit_card/is_card_number/ 378282246310005

  • 🟥 execution_time [+5.458µs; +5.567µs] or [+8.068%; +8.229%]
  • 🟥 throughput [-1123535.639op/s; -1103016.650op/s] or [-7.601%; -7.463%]

scenario:credit_card/is_card_number/378282246310005

  • 🟥 execution_time [+4.992µs; +5.088µs] or [+7.712%; +7.859%]
  • 🟥 throughput [-1125308.192op/s; -1105625.528op/s] or [-7.285%; -7.157%]

scenario:credit_card/is_card_number/37828224631000521389798

  • 🟥 execution_time [+7.327µs; +7.360µs] or [+16.279%; +16.353%]
  • 🟥 throughput [-3124423.430op/s; -3108817.652op/s] or [-14.063%; -13.993%]

scenario:credit_card/is_card_number_no_luhn/ 3782-8224-6310-005

  • 🟥 execution_time [+3.835µs; +3.964µs] or [+6.342%; +6.556%]
  • 🟥 throughput [-1019663.962op/s; -985379.455op/s] or [-6.165%; -5.958%]

scenario:credit_card/is_card_number_no_luhn/ 378282246310005

  • 🟥 execution_time [+4.295µs; +4.354µs] or [+7.993%; +8.103%]
  • 🟥 throughput [-1395262.227op/s; -1377003.600op/s] or [-7.497%; -7.399%]

scenario:credit_card/is_card_number_no_luhn/378282246310005

  • 🟥 execution_time [+4.591µs; +4.665µs] or [+9.127%; +9.274%]
  • 🟥 throughput [-1686874.627op/s; -1662190.464op/s] or [-8.486%; -8.361%]

scenario:credit_card/is_card_number_no_luhn/37828224631000521389798

  • 🟥 execution_time [+7.305µs; +7.333µs] or [+16.226%; +16.287%]
  • 🟥 throughput [-3112288.411op/s; -3099388.334op/s] or [-14.013%; -13.954%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a95934 1774910513 jwiriath/capability-traits-architecture
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 160.594µs 161.880µs ± 0.259µs 161.873µs ± 0.157µs 162.045µs 162.313µs 162.548µs 162.662µs 0.49% -0.262 2.681 0.16% 0.018µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [161.844µs; 161.916µs] or [-0.022%; +0.022%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a95934 1774910513 jwiriath/capability-traits-architecture
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 206.099µs 206.813µs ± 0.448µs 206.751µs ± 0.306µs 207.073µs 207.675µs 208.148µs 208.579µs 0.88% 0.929 1.050 0.22% 0.032µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4794357.689op/s 4835302.297op/s ± 10447.006op/s 4836726.494op/s ± 7153.301op/s 4843433.556op/s 4848142.835op/s 4851074.326op/s 4852042.218op/s 0.32% -0.915 1.002 0.22% 738.715op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.561µs 18.664µs ± 0.058µs 18.662µs ± 0.035µs 18.697µs 18.744µs 18.860µs 18.864µs 1.08% 0.921 1.965 0.31% 0.004µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 53010240.410op/s 53580094.979op/s ± 166138.041op/s 53583449.980op/s ± 100521.569op/s 53689278.081op/s 53837166.597op/s 53871847.522op/s 53875398.986op/s 0.54% -0.892 1.886 0.31% 11747.734op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.591µs 10.848µs ± 0.072µs 10.844µs ± 0.046µs 10.894µs 10.968µs 11.028µs 11.047µs 1.87% -0.075 0.878 0.66% 0.005µs 1 200
normalization/normalize_name/normalize_name/good throughput 90520687.432op/s 92187331.608op/s ± 614063.315op/s 92217445.993op/s ± 391805.530op/s 92567664.576op/s 93127818.981op/s 93949057.672op/s 94420743.156op/s 2.39% 0.133 0.947 0.66% 43420.833op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [206.751µs; 206.875µs] or [-0.030%; +0.030%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4833854.442op/s; 4836750.151op/s] or [-0.030%; +0.030%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.656µs; 18.672µs] or [-0.043%; +0.043%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53557069.844op/s; 53603120.114op/s] or [-0.043%; +0.043%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.838µs; 10.858µs] or [-0.092%; +0.092%] None None None
normalization/normalize_name/normalize_name/good throughput [92102228.339op/s; 92272434.878op/s] or [-0.092%; +0.092%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a95934 1774910513 jwiriath/capability-traits-architecture
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 254.981ns 263.286ns ± 12.406ns 257.872ns ± 1.455ns 260.966ns 290.038ns 310.490ns 313.120ns 21.42% 2.397 5.141 4.70% 0.877ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [261.567ns; 265.006ns] or [-0.653%; +0.653%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a95934 1774910513 jwiriath/capability-traits-architecture
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 50.747ms 51.074ms ± 1.138ms 50.918ms ± 0.045ms 50.977ms 51.123ms 56.011ms 63.401ms 24.52% 8.872 83.389 2.22% 0.081ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [50.916ms; 51.231ms] or [-0.309%; +0.309%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a95934 1774910513 jwiriath/capability-traits-architecture
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_frames_x1000 execution_time 4.189ms 4.194ms ± 0.003ms 4.194ms ± 0.001ms 4.196ms 4.199ms 4.202ms 4.211ms 0.41% 1.634 7.242 0.06% 0.000ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_frames_x1000 execution_time [4.194ms; 4.195ms] or [-0.009%; +0.009%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a95934 1774910513 jwiriath/capability-traits-architecture
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2598 execution_time 3.402ms 3.437ms ± 0.025ms 3.430ms ± 0.012ms 3.445ms 3.488ms 3.507ms 3.515ms 2.47% 1.170 0.644 0.72% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2598 execution_time [3.434ms; 3.440ms] or [-0.101%; +0.101%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a95934 1774910513 jwiriath/capability-traits-architecture
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 534.659µs 535.869µs ± 0.966µs 535.696µs ± 0.458µs 536.270µs 536.983µs 538.661µs 544.794µs 1.70% 4.554 36.190 0.18% 0.068µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1835557.381op/s 1866133.180op/s ± 3338.106op/s 1866731.307op/s ± 1595.384op/s 1868088.810op/s 1869324.734op/s 1869929.193op/s 1870351.832op/s 0.19% -4.462 35.025 0.18% 236.040op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 380.258µs 381.049µs ± 0.398µs 380.970µs ± 0.247µs 381.295µs 381.791µs 382.112µs 382.569µs 0.42% 0.770 0.519 0.10% 0.028µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2613910.230op/s 2624339.028op/s ± 2738.878op/s 2624879.049op/s ± 1699.741op/s 2626233.630op/s 2628271.190op/s 2628777.528op/s 2629794.659op/s 0.19% -0.764 0.504 0.10% 193.668op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 189.788µs 190.364µs ± 0.343µs 190.296µs ± 0.209µs 190.551µs 191.009µs 191.319µs 191.702µs 0.74% 1.020 1.362 0.18% 0.024µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5216423.387op/s 5253114.091op/s ± 9439.765op/s 5254973.332op/s ± 5770.111op/s 5260110.084op/s 5265127.060op/s 5268863.370op/s 5269049.844op/s 0.27% -1.007 1.322 0.18% 667.492op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.800µs 37.894µs ± 0.057µs 37.887µs ± 0.033µs 37.921µs 37.998µs 38.039µs 38.202µs 0.83% 1.500 4.272 0.15% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26176590.729op/s 26389402.965op/s ± 39302.528op/s 26394457.101op/s ± 23023.545op/s 26417126.588op/s 26432638.943op/s 26449224.226op/s 26455022.264op/s 0.23% -1.482 4.165 0.15% 2779.108op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.810µs 45.953µs ± 0.082µs 45.930µs ± 0.051µs 46.001µs 46.091µs 46.153µs 46.322µs 0.85% 1.185 2.244 0.18% 0.006µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21587796.189op/s 21761584.660op/s ± 38694.016op/s 21772305.008op/s ± 24179.823op/s 21789386.112op/s 21807676.340op/s 21817982.767op/s 21829330.399op/s 0.26% -1.170 2.173 0.18% 2736.080op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [535.735µs; 536.003µs] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1865670.550op/s; 1866595.809op/s] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [380.994µs; 381.104µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2623959.446op/s; 2624718.610op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [190.316µs; 190.411µs] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5251805.831op/s; 5254422.352op/s] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.886µs; 37.902µs] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26383956.013op/s; 26394849.918op/s] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.941µs; 45.964µs] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21756222.041op/s; 21766947.278op/s] or [-0.025%; +0.025%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a95934 1774910513 jwiriath/capability-traits-architecture
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 292.667µs 293.700µs ± 0.571µs 293.648µs ± 0.196µs 293.846µs 294.212µs 295.569µs 298.399µs 1.62% 4.871 34.546 0.19% 0.040µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [293.621µs; 293.779µs] or [-0.027%; +0.027%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a95934 1774910513 jwiriath/capability-traits-architecture
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 5.256µs 5.438µs ± 0.036µs 5.437µs ± 0.024µs 5.462µs 5.487µs 5.519µs 5.576µs 2.54% -0.311 2.781 0.67% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [5.433µs; 5.443µs] or [-0.093%; +0.093%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a95934 1774910513 jwiriath/capability-traits-architecture
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.939µs 5.010µs ± 0.044µs 5.013µs ± 0.052µs 5.036µs 5.072µs 5.075µs 5.077µs 1.28% -0.027 -1.282 0.87% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.004µs; 5.016µs] or [-0.120%; +0.120%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a95934 1774910513 jwiriath/capability-traits-architecture
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_serialize_compressed_pprof_timestamped_x1000 execution_time 901.145µs 904.856µs ± 2.731µs 904.412µs ± 1.062µs 905.494µs 908.250µs 912.887µs 928.306µs 2.64% 4.695 33.638 0.30% 0.193µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_serialize_compressed_pprof_timestamped_x1000 execution_time [904.478µs; 905.235µs] or [-0.042%; +0.042%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a95934 1774910513 jwiriath/capability-traits-architecture
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 14.909µs 15.459µs ± 0.269µs 15.458µs ± 0.162µs 15.621µs 15.881µs 16.341µs 16.486µs 6.65% 0.549 1.329 1.73% 0.019µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [15.422µs; 15.497µs] or [-0.241%; +0.241%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a95934 1774910513 jwiriath/capability-traits-architecture
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample2_frames_x1000 execution_time 735.309µs 736.432µs ± 0.549µs 736.347µs ± 0.250µs 736.658µs 737.532µs 738.293µs 738.860µs 0.34% 1.341 3.147 0.07% 0.039µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample2_frames_x1000 execution_time [736.356µs; 736.508µs] or [-0.010%; +0.010%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a95934 1774910513 jwiriath/capability-traits-architecture
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 14.882ms 14.915ms ± 0.020ms 14.912ms ± 0.011ms 14.924ms 14.951ms 14.968ms 15.010ms 0.66% 1.130 2.392 0.13% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [14.912ms; 14.918ms] or [-0.018%; +0.018%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a95934 1774910513 jwiriath/capability-traits-architecture
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 144.576µs 146.799µs ± 1.894µs 146.443µs ± 0.480µs 147.014µs 148.865µs 154.322µs 165.232µs 12.83% 5.969 48.604 1.29% 0.134µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [146.537µs; 147.062µs] or [-0.179%; +0.179%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a95934 1774910513 jwiriath/capability-traits-architecture
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 190.128ns 192.912ns ± 2.054ns 192.761ns ± 1.431ns 193.905ns 196.698ns 198.322ns 200.243ns 3.88% 0.855 0.564 1.06% 0.145ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [192.627ns; 193.197ns] or [-0.148%; +0.148%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a95934 1774910513 jwiriath/capability-traits-architecture
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.198ms 14.267ms ± 0.030ms 14.264ms ± 0.015ms 14.279ms 14.305ms 14.414ms 14.432ms 1.17% 2.368 9.962 0.21% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.262ms; 14.271ms] or [-0.029%; +0.029%] None None None

Group 18

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a95934 1774910513 jwiriath/capability-traits-architecture
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_timestamped_x1000 execution_time 4.203ms 4.209ms ± 0.009ms 4.208ms ± 0.001ms 4.209ms 4.213ms 4.216ms 4.329ms 2.88% 12.262 161.191 0.21% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_timestamped_x1000 execution_time [4.208ms; 4.210ms] or [-0.029%; +0.029%] None None None

Group 19

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a95934 1774910513 jwiriath/capability-traits-architecture
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.299µs 2.379µs ± 0.020µs 2.383µs ± 0.005µs 2.390µs 2.397µs 2.402µs 2.403µs 0.83% -2.497 6.247 0.85% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.376µs; 2.382µs] or [-0.118%; +0.118%] None None None

Group 20

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a95934 1774910513 jwiriath/capability-traits-architecture
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 34.017µs 34.544µs ± 0.939µs 34.099µs ± 0.037µs 34.227µs 36.539µs 36.598µs 37.793µs 10.83% 1.719 1.141 2.71% 0.066µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.414µs; 34.675µs] or [-0.377%; +0.377%] None None None

Group 21

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a95934 1774910513 jwiriath/capability-traits-architecture
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.895µs 3.917µs ± 0.004µs 3.917µs ± 0.002µs 3.919µs 3.924µs 3.929µs 3.930µs 0.35% -0.060 4.355 0.10% 0.000µs 1 200
credit_card/is_card_number/ throughput 254421368.207op/s 255299965.170op/s ± 259201.761op/s 255318668.245op/s ± 160874.131op/s 255467053.750op/s 255620328.113op/s 255707838.651op/s 256717061.211op/s 0.55% 0.079 4.426 0.10% 18328.332op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 79.179µs 79.750µs ± 0.320µs 79.693µs ± 0.225µs 79.977µs 80.384µs 80.595µs 80.655µs 1.21% 0.535 -0.307 0.40% 0.023µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12398478.844op/s 12539406.238op/s ± 50254.588op/s 12548183.534op/s ± 35437.634op/s 12578153.989op/s 12610286.275op/s 12622659.401op/s 12629564.548op/s 0.65% -0.518 -0.332 0.40% 3553.536op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 72.500µs 73.169µs ± 0.379µs 73.110µs ± 0.232µs 73.364µs 73.821µs 74.310µs 74.616µs 2.06% 0.939 1.215 0.52% 0.027µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13401942.147op/s 13667260.843op/s ± 70438.995op/s 13677988.029op/s ± 43409.810op/s 13720330.446op/s 13762682.709op/s 13789272.593op/s 13793065.954op/s 0.84% -0.903 1.111 0.51% 4980.789op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.895µs 3.916µs ± 0.004µs 3.915µs ± 0.002µs 3.918µs 3.922µs 3.925µs 3.930µs 0.39% -0.134 4.290 0.10% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254470267.431op/s 255383358.687op/s ± 247958.113op/s 255451064.768op/s ± 147743.378op/s 255564922.434op/s 255660894.276op/s 255694650.576op/s 256766227.419op/s 0.51% 0.152 4.368 0.10% 17533.286op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 69.190µs 69.775µs ± 0.337µs 69.712µs ± 0.218µs 69.958µs 70.401µs 70.730µs 71.059µs 1.93% 0.873 0.697 0.48% 0.024µs 1 200
credit_card/is_card_number/378282246310005 throughput 14072860.869op/s 14332188.602op/s ± 68926.393op/s 14344792.631op/s ± 44835.124op/s 14385055.726op/s 14418979.348op/s 14441445.165op/s 14452955.629op/s 0.75% -0.845 0.615 0.48% 4873.832op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.256µs 52.353µs ± 0.054µs 52.347µs ± 0.037µs 52.385µs 52.461µs 52.490µs 52.515µs 0.32% 0.636 -0.021 0.10% 0.004µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19042261.522op/s 19101057.308op/s ± 19579.641op/s 19103399.838op/s ± 13579.809op/s 19115648.379op/s 19127605.742op/s 19133220.069op/s 19136581.369op/s 0.17% -0.631 -0.030 0.10% 1384.490op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 5.706µs 5.792µs ± 0.066µs 5.779µs ± 0.051µs 5.839µs 5.909µs 5.964µs 6.003µs 3.89% 0.621 -0.322 1.14% 0.005µs 1 200
credit_card/is_card_number/x371413321323331 throughput 166573799.931op/s 172686987.529op/s ± 1965579.709op/s 173046962.141op/s ± 1520808.336op/s 174247707.435op/s 175184443.293op/s 175208953.621op/s 175264008.479op/s 1.28% -0.578 -0.416 1.14% 138987.474op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.897µs 3.916µs ± 0.004µs 3.915µs ± 0.003µs 3.919µs 3.923µs 3.927µs 3.934µs 0.48% 0.441 2.943 0.11% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254195064.555op/s 255351135.765op/s ± 277757.472op/s 255406602.348op/s ± 183300.951op/s 255558132.984op/s 255664902.081op/s 255727152.513op/s 256637815.512op/s 0.48% -0.426 2.956 0.11% 19640.419op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 63.862µs 64.366µs ± 0.219µs 64.361µs ± 0.155µs 64.519µs 64.706µs 64.847µs 65.091µs 1.13% 0.110 -0.166 0.34% 0.015µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15363113.087op/s 15536426.953op/s ± 52784.428op/s 15537474.873op/s ± 37324.516op/s 15572245.198op/s 15618755.080op/s 15648199.809op/s 15658724.916op/s 0.78% -0.092 -0.183 0.34% 3732.423op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.469µs 58.058µs ± 0.182µs 58.028µs ± 0.094µs 58.142µs 58.402µs 58.587µs 58.751µs 1.25% 0.796 1.938 0.31% 0.013µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17021037.116op/s 17224432.741op/s ± 54009.049op/s 17233014.414op/s ± 28016.064op/s 17258147.268op/s 17292016.536op/s 17348196.621op/s 17400669.835op/s 0.97% -0.765 1.899 0.31% 3819.016op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.895µs 3.916µs ± 0.004µs 3.915µs ± 0.003µs 3.918µs 3.923µs 3.928µs 3.933µs 0.44% 0.343 3.861 0.11% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254283026.862op/s 255365124.228op/s ± 271918.139op/s 255396500.581op/s ± 171659.240op/s 255558260.898op/s 255695248.894op/s 255729697.951op/s 256725427.483op/s 0.52% -0.325 3.894 0.11% 19227.516op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.566µs 54.931µs ± 0.257µs 54.868µs ± 0.131µs 55.044µs 55.457µs 55.690µs 56.318µs 2.64% 1.900 5.228 0.47% 0.018µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17756189.373op/s 18204946.160op/s ± 84489.311op/s 18225473.767op/s ± 43698.802op/s 18263553.972op/s 18292359.222op/s 18300526.953op/s 18326389.780op/s 0.55% -1.850 4.920 0.46% 5974.296op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.252µs 52.343µs ± 0.051µs 52.332µs ± 0.036µs 52.381µs 52.427µs 52.474µs 52.509µs 0.34% 0.556 -0.345 0.10% 0.004µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19044195.627op/s 19104950.631op/s ± 18624.141op/s 19108828.912op/s ± 13280.232op/s 19119632.537op/s 19129703.982op/s 19135588.709op/s 19138067.300op/s 0.15% -0.552 -0.352 0.10% 1316.926op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 5.703µs 5.795µs ± 0.070µs 5.780µs ± 0.042µs 5.834µs 5.930µs 6.007µs 6.039µs 4.48% 0.900 0.600 1.20% 0.005µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 165598036.827op/s 172591877.527op/s ± 2052633.143op/s 173023219.486op/s ± 1261107.837op/s 174151998.204op/s 175192328.891op/s 175300606.514op/s 175336632.079op/s 1.34% -0.837 0.428 1.19% 145143.081op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.916µs; 3.918µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/ throughput [255264042.299op/s; 255335888.041op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [79.705µs; 79.794µs] or [-0.056%; +0.056%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12532441.436op/s; 12546371.041op/s] or [-0.056%; +0.056%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [73.117µs; 73.222µs] or [-0.072%; +0.072%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13657498.676op/s; 13677023.011op/s] or [-0.071%; +0.071%] None None None
credit_card/is_card_number/37828224631 execution_time [3.915µs; 3.916µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/37828224631 throughput [255348994.077op/s; 255417723.297op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/378282246310005 execution_time [69.728µs; 69.821µs] or [-0.067%; +0.067%] None None None
credit_card/is_card_number/378282246310005 throughput [14322636.066op/s; 14341741.137op/s] or [-0.067%; +0.067%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.346µs; 52.361µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19098343.758op/s; 19103770.858op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/x371413321323331 execution_time [5.782µs; 5.801µs] or [-0.159%; +0.159%] None None None
credit_card/is_card_number/x371413321323331 throughput [172414577.086op/s; 172959397.973op/s] or [-0.158%; +0.158%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.916µs; 3.917µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ throughput [255312641.251op/s; 255389630.280op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.335µs; 64.396µs] or [-0.047%; +0.047%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15529111.539op/s; 15543742.367op/s] or [-0.047%; +0.047%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [58.032µs; 58.083µs] or [-0.044%; +0.044%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17216947.606op/s; 17231917.875op/s] or [-0.043%; +0.043%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.915µs; 3.917µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255327438.990op/s; 255402809.467op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.896µs; 54.967µs] or [-0.065%; +0.065%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18193236.754op/s; 18216655.566op/s] or [-0.064%; +0.064%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.335µs; 52.350µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19102369.504op/s; 19107531.758op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [5.785µs; 5.804µs] or [-0.167%; +0.167%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [172307402.315op/s; 172876352.740op/s] or [-0.165%; +0.165%] None None None

Baseline

Omitted due to size.

@Aaalibaba42 Aaalibaba42 force-pushed the jwiriath/capability-traits-architecture branch from 16a302a to 78b3826 Compare February 23, 2026 17:26
@Aaalibaba42 Aaalibaba42 marked this pull request as ready for review February 23, 2026 17:59
@Aaalibaba42 Aaalibaba42 requested review from a team as code owners February 23, 2026 17:59
@Aaalibaba42 Aaalibaba42 force-pushed the jwiriath/capability-traits-architecture branch 3 times, most recently from 4b14313 to c299887 Compare March 9, 2026 12:52
@Aaalibaba42 Aaalibaba42 force-pushed the jwiriath/capability-traits-architecture branch from c057c87 to 7f5fc36 Compare March 30, 2026 20:40
@Aaalibaba42 Aaalibaba42 force-pushed the jwiriath/capability-traits-architecture branch from 62eaefd to 9652357 Compare March 30, 2026 22:08
@Aaalibaba42 Aaalibaba42 changed the title feat(capabilities): trait architecture http draft feat(capabilities)!: trait architecture http draft Mar 31, 2026
@Aaalibaba42 Aaalibaba42 changed the title feat(capabilities)!: trait architecture http draft feat(capabilities)!: trait architecture http Mar 31, 2026
Copy link
Copy Markdown
Contributor

@VianneyRuhlmann VianneyRuhlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a few nits

tracing = { version = "0.1", default-features = false }
serde_json = "1.0"
futures = { version = "0.3", default-features = false }
tokio = { version = "1", features = ["macros", "rt-multi-thread"] }
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, was this used somewhere or an unused feature ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think github diff is broken (?), 8fd755e added the feature back when not on wasm32, and https://github.com/DataDog/libdatadog/blob/jwiriath/capability-traits-architecture/libdd-trace-utils/Cargo.toml#L61 shows the thing correctly

Copy link
Copy Markdown
Contributor

@bantonsson bantonsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only one comment.

/// that only need HTTP should require just `H: HttpClientTrait`, not the full
/// bundle) as this lets native callers like the sidecar use `DefaultHttpClient`
/// directly without pulling in the full bundle.
pub type NativeCapabilities = DefaultHttpClient;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the reason that we don't wrap this in newtype with trait implementations is? Won't this be more of a breaking change than needed when new traits are added.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was a less violent transition in the meantime, but I agree it's just a little more confusing and will have seemed weird looking back when we change this later.

@Aaalibaba42 Aaalibaba42 force-pushed the jwiriath/capability-traits-architecture branch from 3308936 to 8be3832 Compare March 31, 2026 14:19
@Aaalibaba42
Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Mar 31, 2026

View all feedbacks in Devflow UI.

2026-03-31 15:03:19 UTC ℹ️ Start processing command /merge


2026-03-31 15:03:25 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 45m (p90).


2026-03-31 15:25:16 UTC ℹ️ MergeQueue: Readding this merge request to the queue because another merge request processed with yours failed. No action is needed from your side.


2026-03-31 16:06:25 UTC ℹ️ MergeQueue: This merge request was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants