Skip to content

chore: fix unused variable in ffi example#1825

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
kowalski/chore-fix-various-issues
Apr 1, 2026
Merged

chore: fix unused variable in ffi example#1825
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
kowalski/chore-fix-various-issues

Conversation

@KowalskiThomas
Copy link
Copy Markdown
Contributor

@KowalskiThomas KowalskiThomas commented Mar 31, 2026

What does this PR do?

This PR fixes an unused variable (c) which happens when the code is compiled with NDEBUG (which I think I accidentally did when I ran FFI tests for #1733). To work around this, I extracted the c.load from the assert and then always do std::ignore = value so that everything is always used.

@KowalskiThomas KowalskiThomas requested a review from a team as a code owner March 31, 2026 09:00
@KowalskiThomas KowalskiThomas requested a review from a team as a code owner March 31, 2026 09:00
@KowalskiThomas KowalskiThomas force-pushed the kowalski/chore-fix-various-issues branch from 2a94c52 to a717294 Compare March 31, 2026 09:01
@KowalskiThomas KowalskiThomas changed the title chore: fix various issues chore: fix unused variable in ffi example Mar 31, 2026
@datadog-datadog-prod-us1
Copy link
Copy Markdown
Contributor

datadog-datadog-prod-us1 bot commented Mar 31, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 71.31% (-0.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 85c5459 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.35%. Comparing base (15860bb) to head (a717294).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1825      +/-   ##
==========================================
+ Coverage   71.33%   71.35%   +0.02%     
==========================================
  Files         424      424              
  Lines       66685    66685              
==========================================
+ Hits        47572    47586      +14     
+ Misses      19113    19099      -14     
Components Coverage Δ
libdd-crashtracker 65.88% <ø> (-0.02%) ⬇️
libdd-crashtracker-ffi 34.47% <ø> (ø)
libdd-alloc 98.77% <ø> (ø)
libdd-data-pipeline 87.05% <ø> (ø)
libdd-data-pipeline-ffi 72.91% <ø> (ø)
libdd-common 80.19% <ø> (ø)
libdd-common-ffi 73.87% <ø> (ø)
libdd-telemetry 62.48% <ø> (ø)
libdd-telemetry-ffi 16.75% <ø> (ø)
libdd-dogstatsd-client 82.64% <ø> (ø)
datadog-ipc 72.56% <ø> (+2.24%) ⬆️
libdd-profiling 81.61% <ø> (-0.02%) ⬇️
libdd-profiling-ffi 64.94% <ø> (ø)
datadog-sidecar 30.18% <ø> (ø)
datdog-sidecar-ffi 6.52% <ø> (ø)
spawn-worker 54.69% <ø> (ø)
libdd-tinybytes 93.16% <ø> (ø)
libdd-trace-normalization 81.71% <ø> (ø)
libdd-trace-obfuscation 87.24% <ø> (ø)
libdd-trace-protobuf 68.25% <ø> (ø)
libdd-trace-utils 88.72% <ø> (ø)
datadog-tracer-flare 86.88% <ø> (ø)
libdd-log 74.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Mar 31, 2026

Benchmarks

Comparison

Benchmark execution time: 2026-03-31 09:51:51

Comparing candidate commit 85c5459 in PR branch kowalski/chore-fix-various-issues with baseline commit 15860bb in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 85c5459 1774949653 kowalski/chore-fix-various-issues
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 5.364µs 5.455µs ± 0.054µs 5.439µs ± 0.029µs 5.487µs 5.563µs 5.578µs 5.593µs 2.83% 0.767 -0.392 1.00% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [5.447µs; 5.462µs] or [-0.138%; +0.138%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 85c5459 1774949653 kowalski/chore-fix-various-issues
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 245.657ns 255.988ns ± 13.740ns 250.016ns ± 2.951ns 256.573ns 286.777ns 305.759ns 313.342ns 25.33% 2.255 4.793 5.35% 0.972ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [254.084ns; 257.892ns] or [-0.744%; +0.744%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 85c5459 1774949653 kowalski/chore-fix-various-issues
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.290µs 2.371µs ± 0.020µs 2.374µs ± 0.006µs 2.379µs 2.395µs 2.399µs 2.406µs 1.31% -2.370 6.264 0.86% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.368µs; 2.374µs] or [-0.119%; +0.119%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 85c5459 1774949653 kowalski/chore-fix-various-issues
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.898µs 3.916µs ± 0.004µs 3.915µs ± 0.003µs 3.918µs 3.923µs 3.926µs 3.926µs 0.27% 0.037 1.459 0.10% 0.000µs 1 200
credit_card/is_card_number/ throughput 254709482.593op/s 255371451.745op/s ± 254569.554op/s 255403511.834op/s ± 182605.986op/s 255568649.754op/s 255696305.994op/s 255771299.896op/s 256544418.999op/s 0.45% -0.026 1.488 0.10% 18000.786op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 76.113µs 77.798µs ± 0.641µs 77.790µs ± 0.424µs 78.212µs 78.855µs 79.103µs 79.258µs 1.89% -0.154 -0.303 0.82% 0.045µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12616998.014op/s 12854590.990op/s ± 106007.761op/s 12855189.269op/s ± 70132.624op/s 12925863.343op/s 13035705.569op/s 13108624.774op/s 13138314.219op/s 2.20% 0.196 -0.283 0.82% 7495.881op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 67.453µs 67.660µs ± 0.099µs 67.652µs ± 0.060µs 67.715µs 67.800µs 67.910µs 68.281µs 0.93% 1.500 6.961 0.15% 0.007µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 14645259.651op/s 14779818.178op/s ± 21471.361op/s 14781506.857op/s ± 13098.864op/s 14794163.333op/s 14809188.966op/s 14814493.264op/s 14825075.132op/s 0.29% -1.471 6.754 0.14% 1518.255op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.896µs 3.916µs ± 0.004µs 3.916µs ± 0.003µs 3.919µs 3.924µs 3.927µs 3.929µs 0.33% 0.091 1.941 0.11% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254537152.155op/s 255349746.679op/s ± 276769.751op/s 255379129.223op/s ± 184625.350op/s 255558682.889op/s 255684115.633op/s 255809101.041op/s 256659035.258op/s 0.50% -0.078 1.976 0.11% 19570.577op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 64.573µs 64.730µs ± 0.081µs 64.717µs ± 0.051µs 64.782µs 64.865µs 64.962µs 65.030µs 0.48% 0.729 0.428 0.12% 0.006µs 1 200
credit_card/is_card_number/378282246310005 throughput 15377562.311op/s 15448784.813op/s ± 19299.759op/s 15451857.421op/s ± 12193.885op/s 15461887.610op/s 15475106.434op/s 15483042.590op/s 15486435.431op/s 0.22% -0.722 0.410 0.12% 1364.699op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 44.734µs 44.970µs ± 0.094µs 44.970µs ± 0.064µs 45.031µs 45.126µs 45.187µs 45.244µs 0.61% 0.104 -0.341 0.21% 0.007µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 22102509.656op/s 22237028.504op/s ± 46557.986op/s 22236877.302op/s ± 31583.883op/s 22270407.639op/s 22307794.904op/s 22331761.057op/s 22354298.591op/s 0.53% -0.094 -0.347 0.21% 3292.147op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 5.695µs 5.705µs ± 0.006µs 5.703µs ± 0.004µs 5.709µs 5.717µs 5.720µs 5.727µs 0.41% 0.850 0.545 0.10% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 174607837.073op/s 175279374.014op/s ± 173344.601op/s 175331042.387op/s ± 107627.942op/s 175406296.216op/s 175509670.007op/s 175540353.014op/s 175581914.322op/s 0.14% -0.844 0.529 0.10% 12257.314op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.893µs 3.916µs ± 0.004µs 3.915µs ± 0.003µs 3.919µs 3.924µs 3.927µs 3.932µs 0.43% 0.106 3.718 0.11% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254319219.612op/s 255367789.033op/s ± 288860.501op/s 255421136.101op/s ± 166030.382op/s 255572927.032op/s 255674100.534op/s 255804047.354op/s 256894922.936op/s 0.58% -0.087 3.784 0.11% 20425.522op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 59.778µs 61.071µs ± 0.485µs 61.064µs ± 0.311µs 61.351µs 61.927µs 62.257µs 62.338µs 2.09% 0.234 -0.197 0.79% 0.034µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 16041701.424op/s 16375466.710op/s ± 129759.077op/s 16376345.507op/s ± 83430.963op/s 16472222.480op/s 16579661.211op/s 16632768.489op/s 16728499.595op/s 2.15% -0.193 -0.215 0.79% 9175.352op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 53.444µs 53.741µs ± 0.124µs 53.737µs ± 0.074µs 53.811µs 53.951µs 54.075µs 54.135µs 0.74% 0.290 0.330 0.23% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 18472186.222op/s 18607880.217op/s ± 43057.489op/s 18609305.700op/s ± 25506.048op/s 18633927.823op/s 18672907.960op/s 18700291.319op/s 18711086.319op/s 0.55% -0.275 0.313 0.23% 3044.624op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.895µs 3.916µs ± 0.004µs 3.916µs ± 0.003µs 3.919µs 3.923µs 3.926µs 3.928µs 0.31% -0.071 2.407 0.11% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254607965.541op/s 255349763.648op/s ± 272172.150op/s 255390614.395op/s ± 189287.214op/s 255553709.167op/s 255673193.201op/s 255750666.393op/s 256732751.057op/s 0.53% 0.085 2.463 0.11% 19245.477op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 50.208µs 50.333µs ± 0.065µs 50.329µs ± 0.043µs 50.377µs 50.437µs 50.497µs 50.598µs 0.54% 0.658 0.936 0.13% 0.005µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 19763617.207op/s 19867668.550op/s ± 25704.015op/s 19869395.171op/s ± 16995.269op/s 19884309.293op/s 19905773.371op/s 19914805.126op/s 19917138.698op/s 0.24% -0.648 0.906 0.13% 1817.548op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 44.791µs 45.002µs ± 0.083µs 45.000µs ± 0.052µs 45.056µs 45.132µs 45.194µs 45.229µs 0.51% -0.092 0.106 0.18% 0.006µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 22109741.255op/s 22221401.265op/s ± 40858.820op/s 22222207.830op/s ± 25855.739op/s 22245957.355op/s 22286541.638op/s 22318352.108op/s 22326157.326op/s 0.47% 0.103 0.107 0.18% 2889.155op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 5.693µs 5.704µs ± 0.005µs 5.703µs ± 0.004µs 5.708µs 5.714µs 5.716µs 5.730µs 0.47% 1.003 1.816 0.09% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 174519496.456op/s 175300458.306op/s ± 164210.610op/s 175337574.845op/s ± 108761.551op/s 175426943.322op/s 175510221.760op/s 175553510.856op/s 175649612.990op/s 0.18% -0.996 1.780 0.09% 11611.444op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.915µs; 3.916µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/ throughput [255336170.853op/s; 255406732.637op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [77.710µs; 77.887µs] or [-0.114%; +0.114%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12839899.334op/s; 12869282.646op/s] or [-0.114%; +0.114%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [67.646µs; 67.674µs] or [-0.020%; +0.020%] None None None
credit_card/is_card_number/ 378282246310005 throughput [14776842.454op/s; 14782793.902op/s] or [-0.020%; +0.020%] None None None
credit_card/is_card_number/37828224631 execution_time [3.916µs; 3.917µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/37828224631 throughput [255311389.053op/s; 255388104.304op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/378282246310005 execution_time [64.719µs; 64.741µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number/378282246310005 throughput [15446110.052op/s; 15451459.574op/s] or [-0.017%; +0.017%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [44.957µs; 44.983µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [22230576.015op/s; 22243480.993op/s] or [-0.029%; +0.029%] None None None
credit_card/is_card_number/x371413321323331 execution_time [5.704µs; 5.706µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/x371413321323331 throughput [175255350.120op/s; 175303397.909op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.915µs; 3.917µs] or [-0.016%; +0.016%] None None None
credit_card/is_card_number_no_luhn/ throughput [255327755.746op/s; 255407822.320op/s] or [-0.016%; +0.016%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [61.004µs; 61.138µs] or [-0.110%; +0.110%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [16357483.350op/s; 16393450.070op/s] or [-0.110%; +0.110%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [53.724µs; 53.758µs] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [18601912.863op/s; 18613847.571op/s] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.916µs; 3.917µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255312043.206op/s; 255387484.091op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [50.324µs; 50.342µs] or [-0.018%; +0.018%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [19864106.220op/s; 19871230.879op/s] or [-0.018%; +0.018%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [44.990µs; 45.013µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [22215738.626op/s; 22227063.905op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [5.704µs; 5.705µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [175277700.295op/s; 175323216.317op/s] or [-0.013%; +0.013%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 85c5459 1774949653 kowalski/chore-fix-various-issues
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 14.957µs 15.361µs ± 0.196µs 15.327µs ± 0.132µs 15.477µs 15.719µs 15.879µs 15.931µs 3.94% 0.621 0.148 1.28% 0.014µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [15.334µs; 15.388µs] or [-0.177%; +0.177%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 85c5459 1774949653 kowalski/chore-fix-various-issues
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.983µs 5.070µs ± 0.049µs 5.084µs ± 0.038µs 5.104µs 5.143µs 5.145µs 5.146µs 1.22% -0.149 -1.295 0.96% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.063µs; 5.077µs] or [-0.133%; +0.133%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 85c5459 1774949653 kowalski/chore-fix-various-issues
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_serialize_compressed_pprof_timestamped_x1000 execution_time 912.302µs 915.898µs ± 2.976µs 915.363µs ± 1.122µs 916.636µs 919.921µs 927.378µs 941.003µs 2.80% 4.441 30.199 0.32% 0.210µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_serialize_compressed_pprof_timestamped_x1000 execution_time [915.486µs; 916.311µs] or [-0.045%; +0.045%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 85c5459 1774949653 kowalski/chore-fix-various-issues
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 534.659µs 536.088µs ± 1.060µs 535.830µs ± 0.564µs 536.495µs 538.309µs 539.234µs 541.381µs 1.04% 1.575 3.285 0.20% 0.075µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1847126.789op/s 1865371.051op/s ± 3678.122op/s 1866262.837op/s ± 1962.822op/s 1868158.864op/s 1869357.314op/s 1870123.196op/s 1870350.803op/s 0.22% -1.558 3.196 0.20% 260.083op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 380.269µs 381.224µs ± 0.461µs 381.180µs ± 0.339µs 381.519µs 382.083µs 382.357µs 382.556µs 0.36% 0.488 -0.258 0.12% 0.033µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2613999.353op/s 2623130.501op/s ± 3170.119op/s 2623431.601op/s ± 2332.253op/s 2625693.969op/s 2627524.653op/s 2628677.460op/s 2629716.482op/s 0.24% -0.482 -0.266 0.12% 224.161op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 189.369µs 190.103µs ± 0.363µs 190.084µs ± 0.270µs 190.355µs 190.718µs 191.021µs 191.117µs 0.54% 0.352 -0.360 0.19% 0.026µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5232387.081op/s 5260330.546op/s ± 10031.753op/s 5260840.569op/s ± 7478.328op/s 5268210.686op/s 5274442.252op/s 5277628.812op/s 5280703.942op/s 0.38% -0.343 -0.372 0.19% 709.352op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.819µs 37.933µs ± 0.053µs 37.922µs ± 0.032µs 37.963µs 38.033µs 38.068µs 38.115µs 0.51% 0.740 0.250 0.14% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26236056.008op/s 26362513.182op/s ± 36843.926op/s 26369736.074op/s ± 22505.673op/s 26389602.181op/s 26410980.960op/s 26422340.902op/s 26441965.902op/s 0.27% -0.733 0.235 0.14% 2605.259op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.747µs 46.019µs ± 0.155µs 46.002µs ± 0.073µs 46.075µs 46.225µs 46.421µs 47.397µs 3.03% 3.762 30.138 0.34% 0.011µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21098554.866op/s 21730594.309op/s ± 72156.504op/s 21738080.291op/s ± 34453.538op/s 21776102.470op/s 21816172.355op/s 21845869.159op/s 21859287.878op/s 0.56% -3.585 28.107 0.33% 5102.235op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [535.942µs; 536.235µs] or [-0.027%; +0.027%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1864861.299op/s; 1865880.804op/s] or [-0.027%; +0.027%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [381.161µs; 381.288µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2622691.153op/s; 2623569.849op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [190.053µs; 190.153µs] or [-0.026%; +0.026%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5258940.242op/s; 5261720.851op/s] or [-0.026%; +0.026%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.925µs; 37.940µs] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26357406.968op/s; 26367619.396op/s] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.997µs; 46.040µs] or [-0.047%; +0.047%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21720594.112op/s; 21740594.507op/s] or [-0.046%; +0.046%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 85c5459 1774949653 kowalski/chore-fix-various-issues
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_timestamped_x1000 execution_time 4.197ms 4.203ms ± 0.008ms 4.202ms ± 0.002ms 4.204ms 4.208ms 4.212ms 4.304ms 2.41% 10.966 137.862 0.18% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_timestamped_x1000 execution_time [4.202ms; 4.204ms] or [-0.026%; +0.026%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 85c5459 1774949653 kowalski/chore-fix-various-issues
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 34.846µs 35.379µs ± 0.856µs 35.003µs ± 0.068µs 35.072µs 37.196µs 37.234µs 38.392µs 9.68% 1.725 1.184 2.41% 0.061µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [35.260µs; 35.498µs] or [-0.335%; +0.335%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 85c5459 1774949653 kowalski/chore-fix-various-issues
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2598 execution_time 3.400ms 3.440ms ± 0.019ms 3.436ms ± 0.010ms 3.449ms 3.480ms 3.493ms 3.499ms 1.84% 0.918 0.427 0.56% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2598 execution_time [3.438ms; 3.443ms] or [-0.078%; +0.078%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 85c5459 1774949653 kowalski/chore-fix-various-issues
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 158.696µs 159.902µs ± 0.379µs 159.866µs ± 0.189µs 160.076µs 160.467µs 161.548µs 161.988µs 1.33% 1.500 7.024 0.24% 0.027µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [159.849µs; 159.954µs] or [-0.033%; +0.033%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 85c5459 1774949653 kowalski/chore-fix-various-issues
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 205.094µs 205.781µs ± 0.399µs 205.728µs ± 0.294µs 206.044µs 206.492µs 206.887µs 207.021µs 0.63% 0.640 -0.001 0.19% 0.028µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4830436.660op/s 4859555.622op/s ± 9410.877op/s 4860787.703op/s ± 6949.625op/s 4867529.686op/s 4872390.063op/s 4875031.192op/s 4875813.042op/s 0.31% -0.631 -0.020 0.19% 665.450op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.572µs 18.673µs ± 0.056µs 18.666µs ± 0.025µs 18.690µs 18.791µs 18.852µs 18.916µs 1.34% 1.438 3.037 0.30% 0.004µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 52864091.349op/s 53552496.520op/s ± 160123.630op/s 53572563.614op/s ± 71017.522op/s 53643739.652op/s 53750433.060op/s 53839222.982op/s 53845823.891op/s 0.51% -1.412 2.944 0.30% 11322.450op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.530µs 10.770µs ± 0.118µs 10.757µs ± 0.075µs 10.837µs 11.002µs 11.067µs 11.167µs 3.81% 0.691 0.377 1.09% 0.008µs 1 200
normalization/normalize_name/normalize_name/good throughput 89549382.041op/s 92858027.065op/s ± 1008820.793op/s 92963018.959op/s ± 648259.060op/s 93577328.558op/s 94233230.324op/s 94661294.024op/s 94964971.699op/s 2.15% -0.630 0.258 1.08% 71334.402op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [205.726µs; 205.836µs] or [-0.027%; +0.027%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4858251.365op/s; 4860859.879op/s] or [-0.027%; +0.027%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.666µs; 18.681µs] or [-0.042%; +0.042%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53530304.925op/s; 53574688.115op/s] or [-0.041%; +0.041%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.754µs; 10.787µs] or [-0.152%; +0.152%] None None None
normalization/normalize_name/normalize_name/good throughput [92718214.206op/s; 92997839.925op/s] or [-0.151%; +0.151%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 85c5459 1774949653 kowalski/chore-fix-various-issues
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 144.481µs 146.467µs ± 1.773µs 146.193µs ± 0.519µs 146.757µs 147.953µs 153.436µs 162.010µs 10.82% 5.329 37.882 1.21% 0.125µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [146.221µs; 146.713µs] or [-0.168%; +0.168%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 85c5459 1774949653 kowalski/chore-fix-various-issues
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_frames_x1000 execution_time 4.163ms 4.169ms ± 0.003ms 4.169ms ± 0.002ms 4.171ms 4.174ms 4.177ms 4.183ms 0.33% 0.929 3.232 0.06% 0.000ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_frames_x1000 execution_time [4.169ms; 4.170ms] or [-0.009%; +0.009%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 85c5459 1774949653 kowalski/chore-fix-various-issues
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 49.227ms 49.703ms ± 1.104ms 49.564ms ± 0.052ms 49.623ms 49.732ms 52.516ms 63.123ms 27.36% 10.223 113.723 2.22% 0.078ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [49.550ms; 49.856ms] or [-0.308%; +0.308%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 85c5459 1774949653 kowalski/chore-fix-various-issues
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample2_frames_x1000 execution_time 741.863µs 742.978µs ± 0.509µs 742.903µs ± 0.275µs 743.227µs 743.961µs 744.514µs 744.830µs 0.26% 0.814 1.347 0.07% 0.036µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample2_frames_x1000 execution_time [742.907µs; 743.048µs] or [-0.009%; +0.009%] None None None

Group 18

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 85c5459 1774949653 kowalski/chore-fix-various-issues
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 14.860ms 14.892ms ± 0.017ms 14.888ms ± 0.009ms 14.900ms 14.919ms 14.939ms 14.994ms 0.71% 1.687 6.701 0.11% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [14.889ms; 14.894ms] or [-0.016%; +0.016%] None None None

Group 19

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 85c5459 1774949653 kowalski/chore-fix-various-issues
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 190.098ns 192.605ns ± 2.072ns 192.267ns ± 1.650ns 193.922ns 196.259ns 197.688ns 201.852ns 4.99% 0.967 1.099 1.07% 0.147ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [192.318ns; 192.892ns] or [-0.149%; +0.149%] None None None

Group 20

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 85c5459 1774949653 kowalski/chore-fix-various-issues
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 287.522µs 288.244µs ± 0.676µs 288.131µs ± 0.158µs 288.296µs 288.963µs 292.014µs 294.617µs 2.25% 6.109 47.252 0.23% 0.048µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [288.150µs; 288.337µs] or [-0.033%; +0.033%] None None None

Group 21

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 85c5459 1774949653 kowalski/chore-fix-various-issues
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.769ms 14.830ms ± 0.030ms 14.828ms ± 0.016ms 14.845ms 14.876ms 14.925ms 15.020ms 1.29% 1.596 7.442 0.20% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.826ms; 14.834ms] or [-0.028%; +0.028%] None None None

Baseline

Omitted due to size.

@KowalskiThomas KowalskiThomas force-pushed the kowalski/chore-fix-various-issues branch from a717294 to f62803b Compare March 31, 2026 09:26
@KowalskiThomas KowalskiThomas requested a review from a team as a code owner March 31, 2026 09:26
@KowalskiThomas KowalskiThomas force-pushed the kowalski/chore-fix-various-issues branch from f62803b to 85c5459 Compare March 31, 2026 09:34
@KowalskiThomas KowalskiThomas removed request for a team March 31, 2026 09:34
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts bot commented Mar 31, 2026

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 102.07 MB 102.07 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.76 MB 8.76 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 119.03 MB 119.03 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.36 MB 11.36 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 27.40 MB 27.40 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 80.69 KB 80.69 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 187.23 MB 187.23 MB +0% (+8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 926.11 MB 926.11 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 9.07 MB 9.07 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 80.69 KB 80.69 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 27.01 MB 27.01 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 61.33 MB 61.33 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 23.26 MB 23.26 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 81.94 KB 81.94 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 191.79 MB 191.75 MB --.02% (-40.00 KB) 💪
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 911.12 MB 911.12 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.90 MB 6.90 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 81.94 KB 81.94 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 29.12 MB 29.12 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 57.69 MB 57.69 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 88.90 MB 88.90 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 10.34 MB 10.34 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 111.70 MB 111.70 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 12.09 MB 12.09 MB 0% (0 B) 👌

Copy link
Copy Markdown
Contributor

@yannham yannham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a C++ expert, but I suppose one could also gate the whole for block with #ifdef. That being said, I'm not sure that this is any better than the proposed solution, which looks reasonable 👍

@Aaalibaba42
Copy link
Copy Markdown
Contributor

If you are at least on c++20 you can assert(std::ranges::all_of(...)) instead of the whole loop ig

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the kowalski/chore-fix-various-issues branch April 1, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants