fix(sidecar): enable test_ddog_sidecar_register_app on Windows (APMSP-2356)#1848

Draft

Leiyks wants to merge 33 commits intomainfrom

leiyks/fix-apmsp-2356-windows-pipe-race

Commits on Apr 13, 2026

fix(sidecar): retry connect on Windows to fix startup race in named-pipe IPC
Leiyks
committed
fix(clippy): add parentheses for operator precedence in mapper.rs
Leiyks
committed
fix(sidecar): address review feedback on Windows pipe retry logic
Leiyks
committed
fix(ipc): replace retry workaround with WaitNamedPipe + readiness signal
Leiyks
committed
fix(ipc): remove unnecessary cast on WaitNamedPipeA argument
Leiyks
committed
fix(ipc): apply review suggestions — handle leak, timeout msg, bounded retry, constants
Leiyks
committed
fix(sidecar): move WAIT_TIMEOUT import to winapi::shared::winerror
Leiyks
committed
fix(sidecar): store HANDLE directly in OwnedEvent instead of usize
Leiyks
committed
fix(sidecar): remove broken named-event readiness mechanism on Windows
Leiyks
committed
revert(ipc): restore original connect() fail-fast on ERROR_PIPE_BUSY
Leiyks
committed
docs(sidecar): fix misleading comment in setup_daemon_process on Windows
Leiyks
committed
fix(sidecar): remove unnecessary ReadinessWaiter type and revert return types
Leiyks
committed
fix(sidecar): restore origin/main style in entry.rs and windows.rs comment
Leiyks
committed

Commits on Apr 14, 2026