feat(sidecar): wire telemetry_extended_heartbeat_interval through SessionConfig#1882
Open
khanayan123 wants to merge 4 commits intomainfrom
Open
feat(sidecar): wire telemetry_extended_heartbeat_interval through SessionConfig#1882khanayan123 wants to merge 4 commits intomainfrom
khanayan123 wants to merge 4 commits intomainfrom
Conversation
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Contributor
📚 Documentation Check Results📦
|
Contributor
🔒 Cargo Deny Results📦
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1882 +/- ##
==========================================
- Coverage 71.63% 71.50% -0.14%
==========================================
Files 431 431
Lines 68995 69002 +7
==========================================
- Hits 49425 49340 -85
- Misses 19570 19662 +92
🚀 New features to boost your workflow:
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: a03953e | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
…sionConfig Add telemetry_extended_heartbeat_interval to the sidecar's SessionConfig and FFI so that callers (e.g. PHP) can configure the extended heartbeat interval. The telemetry worker already supports this field in its Config but the sidecar was not passing it through. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The ExtendedHeartbeat lifecycle action was wrapping the payload in Payload::AppStarted instead of Payload::AppExtendedHeartbeat, causing it to serialize as "app-started" instead of "app-extended-heartbeat". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add telemetry_extended_heartbeat_interval_millis argument (86400000ms = 24h default) to both ddog_sidecar_session_set_config calls in the sidecar FFI test. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
khanayan123
force-pushed
the
ayan.khan/wire-extended-heartbeat-sidecar
branch
from
1a43b5c to
a03953e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
telemetry_extended_heartbeat_intervalto the sidecar'sSessionConfigand FFIlayer so that callers (e.g. PHP tracer) can configure the extended heartbeat interval.
The telemetry worker already supports this field in its
Configstruct, but the sidecarwas not passing it through from
SessionConfig->modify_telemetry_config. This meantsidecar consumers could not control the cadence of
app-extended-heartbeatevents.Changes:
datadog-sidecar/src/service/mod.rs: addtelemetry_extended_heartbeat_interval: DurationtoSessionConfigdatadog-sidecar/src/service/sidecar_server.rs: setcfg.telemetry_extended_heartbeat_intervalinmodify_telemetry_configdatadog-sidecar-ffi/src/lib.rs: addtelemetry_extended_heartbeat_interval_millis: u64param toddog_sidecar_session_set_configCompanion dd-trace-php PR: DataDog/dd-trace-php#3800