-
Notifications
You must be signed in to change notification settings - Fork 12
Mirror public images to internal registry #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
pawelchcki
wants to merge
19
commits into
master
Choose a base branch
from
update_images
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
00532b0
Use mirrored images from registry.ddbuild.io for all image references
pawelchcki f088064
Rename mirrored image prefix from tests/images to mirror
pawelchcki 5803576
Use mirrored images for all Docker image references
pawelchcki d1d1d96
Add flush-on-print and verbose logging to mirror_images.py
pawelchcki 0c18a24
Merge origin/master into use_mirrored_images
pawelchcki 8e82097
Trigger CI rebuild
pawelchcki e5f314a
Rename mirrored image registry path from tests/images to mirror
pawelchcki 4d1ee54
Merge branch 'use_mirrored_images' of https://github.com/DataDog/ngin…
pawelchcki 9be1ff2
Format mirror_images.py with yapf
pawelchcki afb35ce
Skip submodules and CI matrices in mirror lint
pawelchcki 2262c2b
Merge remote-tracking branch 'origin/master' into update_images
pawelchcki db0af1d
Update mirror images and enhance lint to check GitLab CI matrices
pawelchcki 33d8240
Narrow exception handling in GitLab CI file parsing
pawelchcki e917b92
Merge remote-tracking branch 'origin/master' into update_images
pawelchcki 0cba585
Exclude example/ from mirror lint and make script runnable from any repo
pawelchcki d2959b9
Improve mirror_images.py readability and code organization
pawelchcki 49aa1d9
Reset dd-trace-cpp submodule to master and add .gitattributes
pawelchcki b176db1
Reset dd-trace-cpp submodule to origin/master (f8c3913)
pawelchcki 2e36e2a
Merge origin/master into update_images
pawelchcki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| mirror_images.lock.yaml linguist-generated=true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| lint-mirror-images: | ||
| stage: mirror-images | ||
| # Use the docker image for its pre-configured registry auth helpers. | ||
| image: registry.ddbuild.io/images/docker:27.3.1 | ||
| tags: ["arch:amd64"] | ||
| needs: [] | ||
| rules: | ||
| - when: always | ||
| script: | ||
| - curl -LsSf https://astral.sh/uv/install.sh | sh | ||
| - export PATH="$HOME/.local/bin:$PATH" | ||
| - uv run bin/mirror_images.py lint | ||
|
|
||
| mirror-images: | ||
| stage: mirror-images | ||
| # Use the docker image for its pre-configured registry auth helpers | ||
| # and crane binary for copying images. | ||
| image: registry.ddbuild.io/images/docker:27.3.1 | ||
| tags: ["arch:amd64"] | ||
| needs: [] | ||
| rules: | ||
| - when: always | ||
| script: | ||
| - curl -LsSf https://astral.sh/uv/install.sh | sh | ||
| - export PATH="$HOME/.local/bin:$PATH" | ||
|
pawelchcki marked this conversation as resolved.
|
||
| - uv run bin/mirror_images.py mirror | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| # Agent Instructions | ||
|
|
||
| `make format` to format, `make lint` to check. Rebuild formatter image after editing `Dockerfile.formatter` with `make build-formatter-image`. | ||
|
|
||
| All public Docker images must use `registry.ddbuild.io` mirrors. Managed by `bin/mirror_images.py` (subcommands: `add`, `lock`, `relock`, `mirror`, `lint`). Config: `mirror_images.yaml` / `mirror_images.lock.yaml`. Mirror prefix: `registry.ddbuild.io/ci/nginx-datadog/mirror/`. In `build_env/Dockerfile`, `MIRROR_REGISTRY` ARG is set to `""` in GHA to use public registries. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.