IDMPL-350 Improve example scripts to simplify smoke tests procedure#349
Open
xlamorlette-datadog wants to merge 16 commits intomasterfrom
Open
IDMPL-350 Improve example scripts to simplify smoke tests procedure#349xlamorlette-datadog wants to merge 16 commits intomasterfrom
xlamorlette-datadog wants to merge 16 commits intomasterfrom
Conversation
…nx and the Nginx Datadog versions
…e, and options to the run script to set the OpenResty and the Nginx Datadog versions
xlamorlette-datadog
changed the title
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: c92d146 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
pawelchcki
approved these changes
Apr 15, 2026
Contributor
pawelchcki
left a comment
pawelchcki
left a comment
There was a problem hiding this comment.
Only some shell escaping nits.
Change looks good. Hard to opine on the ergonomics of its usage without using it for a while myself.
Co-authored-by: Pawel Chojnacki <pawel.chcki@gmail.com>
Co-authored-by: Pawel Chojnacki <pawel.chcki@gmail.com>
Co-authored-by: Pawel Chojnacki <pawel.chcki@gmail.com>
Co-authored-by: Pawel Chojnacki <pawel.chcki@gmail.com>
Contributor
Author
|
@pawelchcki Thanks for your very useful comments!
I just ran a delivery: I could run the smoke tests in about two minutes, instead of twenty minutes (because, previously, one had to manually download artifacts and tweak several scripts)! |
Co-authored-by: Pawel Chojnacki <pawel.chcki@gmail.com>
Co-authored-by: Pawel Chojnacki <pawel.chcki@gmail.com>
…cing and openresty examples
Contributor
Author
|
@pawelchcki I applied your suggested changes. Then I factorized things across the two |
xlamorlette-datadog
force-pushed
the
xlamorlette/IDMPL-350-Nginx-Simplify-smoke-tests-procedure
branch
from
a751dc6 to
c92d146
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To simplify the procedure to run smoke tests (see internal documentation):
runscript, add options to dynamically set the Nginx and the Nginx Datadog versions.runscript, add options to dynamically set the OpenResty and the Nginx Datadog versions.