chore(ci): add smp experiments for tag filtering by rayz · Pull Request #1296 · DataDog/saluki

rayz · 2026-04-01T17:10:59Z

Summary

title. can't be merged yet since the experiment relies on a specific lading hash.

Change Type

Bug fix
New feature
Non-functional (chore, refactoring, docs)
Performance

How did you test this PR?

References

Copilot

Pull request overview

This PR adds new SMP (Single Machine Performance) experiments for testing tag filtering functionality in the Agent Data Plane with DogStatsD. The changes include a new template for tag filtering experiments, four new experiment definitions, supporting configuration files, and a fix to handle explicit empty generator lists in the experiment generation script.

Changes:

Add tagfilter_base template for high-cardinality, long metric/tag name DogStatsD experiments (78k contexts, 54 tags per message, distributions only)
Add four new tag filtering experiments: tagfilter_0tags (no tag filter), tagfilter_100metrics (100 metrics), tagfilter_500metrics (500 metrics), and tagfilter_500metrics_notraffic (no traffic variant)
Fix merge_generator_lists() to handle explicit empty generator lists (needed for no-traffic experiments)
Update lading version specification (with concern noted below)

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
test/smp/regression/adp/generate_experiments.py	Adds logic to handle empty generator overlays for no-traffic experiments
test/smp/regression/adp/config.yaml	Updates lading version (flagged for verification)
test/smp/regression/adp/experiments.yaml	Adds tagfilter_base template and four new tag filtering experiments
test/smp/regression/adp/shared/tagfilter_*.yaml	Generated tag filter configuration files for different cardinalities
test/smp/regression/adp/cases/tagfilter_/	Experiment-specific configuration directories

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-01T17:14:04Z

test/smp/regression/adp/config.yaml

@@ -1,5 +1,5 @@
 lading:
-  version: 0.31.2
+  version: sha-0bae8521d48563fddd7fd0589783c12d3f737afc


The lading version has been changed from a semantic version "0.31.2" to a commit SHA "sha-0bae8521d48563fddd7fd0589783c12d3f737afc". Without documentation or context indicating that this SHA exists in the lading repository, this could result in a build failure or undefined behavior when the SMP attempts to fetch this version. Verify that this commit SHA is valid and accessible in the lading repository.

Suggested change

version: sha-0bae8521d48563fddd7fd0589783c12d3f737afc

version: 0.31.2

Copilot

Pull request overview

Copilot reviewed 27 out of 31 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-01T18:23:23Z

test/smp/regression/adp/config.yaml

@@ -1,5 +1,5 @@
 lading:
-  version: 0.31.2
+  version: sha-0bae8521d48563fddd7fd0589783c12d3f737afc


The lading version is pinned to a git SHA (sha-0bae8521d48563fddd7fd0589783c12d3f737afc) rather than a released version. Per the PR description, this prevents the PR from being merged. Ensure this is intentional for experimental purposes and document what triggers the update to a stable version.

tobz · 2026-04-02T13:39:13Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

Copilot reviewed 27 out of 31 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Copilot reviewed 41 out of 47 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pr-commenter · 2026-04-03T18:41:38Z

Binary Size Analysis (Agent Data Plane)

Target: 40ae02c (baseline) vs 8396759 (comparison) diff
Analysis Type: Stripped binaries (debug symbols excluded)
Baseline Size: 26.48 MiB
Comparison Size: 26.48 MiB
Size Change: +0 B (+0.00%)
Pass/Fail Threshold: +5%
Result: PASSED ✅

Changes by Module

Module	File Size	Symbols

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

pr-commenter · 2026-04-03T18:57:06Z

Regression Detector (Agent Data Plane)

This comment was omitted because it was over 65,536 characters.Please check the Gitlab Job logs to see its output.

…form

Copilot AI review requested due to automatic review settings April 1, 2026 17:11

dd-octo-sts bot added the area/test All things testing: unit/integration, correctness, SMP regression, etc. label Apr 1, 2026

Copilot started reviewing on behalf of rayz April 1, 2026 17:11 View session

Copilot AI reviewed Apr 1, 2026

View reviewed changes

rayz force-pushed the rayz/tagfilter-implementation branch from 33eba26 to d7b994f Compare April 1, 2026 17:19

rayz force-pushed the rayz/tagfilter-smp branch from 800a027 to d4c5149 Compare April 1, 2026 17:42

rayz mentioned this pull request Apr 1, 2026

tag aggregation smp tests #1252

Closed

4 tasks

tobz mentioned this pull request Apr 1, 2026

experiment(context): amortized/deferred mutable view over tag set filtering (#1293 cherry pick) #1295

Closed

4 tasks

Copilot AI review requested due to automatic review settings April 1, 2026 18:20

Copilot started reviewing on behalf of rayz April 1, 2026 18:21 View session

Copilot AI reviewed Apr 1, 2026

View reviewed changes

tobz force-pushed the rayz/tagfilter-implementation branch from d7b994f to b376b05 Compare April 2, 2026 13:38

tobz force-pushed the rayz/tagfilter-smp branch from b7b1fb4 to 66cf0eb Compare April 2, 2026 13:38

tobz mentioned this pull request Apr 2, 2026

enhancement(agent-data-plane): add metric tag filterlist #1293

Merged

4 tasks

tobz mentioned this pull request Apr 2, 2026

experiment(tag_filterlist): try trie-based tag membership set approach #1304

Draft

4 tasks

tobz force-pushed the rayz/tagfilter-implementation branch from b376b05 to 751d3a2 Compare April 2, 2026 19:34

Copilot AI review requested due to automatic review settings April 2, 2026 19:34

tobz force-pushed the rayz/tagfilter-smp branch from 66cf0eb to 03c4224 Compare April 2, 2026 19:34

Copilot started reviewing on behalf of tobz April 2, 2026 19:35 View session

Copilot AI reviewed Apr 2, 2026

View reviewed changes

tobz force-pushed the rayz/tagfilter-smp branch from 03c4224 to e3d1eb4 Compare April 3, 2026 14:44

tobz force-pushed the rayz/tagfilter-implementation branch from 751d3a2 to 6fd3517 Compare April 3, 2026 14:44

Copilot AI review requested due to automatic review settings April 3, 2026 18:31

Copilot started reviewing on behalf of rayz April 3, 2026 18:32 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

tobz force-pushed the rayz/tagfilter-implementation branch from 6fd3517 to 35ed30b Compare April 6, 2026 16:29

tobz force-pushed the rayz/tagfilter-smp branch from 2607741 to f867a73 Compare April 6, 2026 16:29

rayz changed the base branch from rayz/tagfilter-implementation to main April 6, 2026 18:36

rayz force-pushed the rayz/tagfilter-smp branch from f867a73 to b36eee1 Compare April 6, 2026 19:05

chore(agent-data-plane): add SMP experiments for tag_filterlist trans…

8396759

…form

tobz force-pushed the rayz/tagfilter-smp branch from b36eee1 to 8396759 Compare April 10, 2026 13:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(ci): add smp experiments for tag filtering#1296

chore(ci): add smp experiments for tag filtering#1296
rayz wants to merge 1 commit intomainfrom
rayz/tagfilter-smp

rayz commented Apr 1, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

tobz commented Apr 2, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

pr-commenter bot commented Apr 3, 2026 •

edited

Loading

Changes by Module

Detailed Symbol Changes

Uh oh!

pr-commenter bot commented Apr 3, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	version: sha-0bae8521d48563fddd7fd0589783c12d3f737afc
	version: 0.31.2

Conversation

rayz commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Change Type

How did you test this PR?

References

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

tobz commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

pr-commenter bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Binary Size Analysis (Agent Data Plane)

Changes by Module

Detailed Symbol Changes

Uh oh!

pr-commenter bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector (Agent Data Plane)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rayz commented Apr 1, 2026 •

edited

Loading

tobz commented Apr 2, 2026 •

edited

Loading

pr-commenter bot commented Apr 3, 2026 •

edited

Loading

pr-commenter bot commented Apr 3, 2026 •

edited

Loading