Skip to content

test(smp): add initial Agent+ADP tagfilter benchmark harness#1327

Draft
rayz wants to merge 14 commits intomainfrom
rayz/tagfilter-agent-adp-smp
Draft

test(smp): add initial Agent+ADP tagfilter benchmark harness#1327
rayz wants to merge 14 commits intomainfrom
rayz/tagfilter-agent-adp-smp

Conversation

@rayz
Copy link
Copy Markdown
Contributor

@rayz rayz commented Apr 8, 2026

Summary

do not merge. testing converged image + tag filtering

the job to look for is run-benchmarks-agent-adp

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

How did you test this PR?

References

@dd-octo-sts dd-octo-sts bot added area/ci CI/CD, automated testing, etc. area/test All things testing: unit/integration, correctness, SMP regression, etc. labels Apr 8, 2026
@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Apr 8, 2026

Binary Size Analysis (Agent Data Plane)

Target: ddb45ed (baseline) vs ec9ca3e (comparison) diff
Analysis Type: Stripped binaries (debug symbols excluded)
Baseline Size: 26.46 MiB
Comparison Size: 26.46 MiB
Size Change: +312 B (+0.00%)
Pass/Fail Threshold: +5%
Result: PASSED ✅

Changes by Module

Module File Size Symbols
agent_data_plane::cli::run +1.29 KiB 4
[Unmapped] -945 B 1
[sections] -123 B 6
unicode_segmentation +80 B 1
agent_data_plane::components::tag_filterlist -32 B 1
core +8 B 51
figment +6 B 15
saluki_core::data_model::event +0 B 2
hickory_proto +0 B 18
rustls +0 B 12
webpki +0 B 2
saluki_context::tags::tagset +0 B 4
tonic +0 B 4
ottl::Value +0 B 2
serde_yaml +0 B 4
http +0 B 28
crossbeam_channel +0 B 16
tracing_subscriber +0 B 4
aho_corasick +0 B 60
seize +0 B 4

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW] +10.6Ki  [NEW] +10.5Ki    <saluki_core::data_model::event::Event as core::clone::Clone>::clone.9932
  [NEW] +5.52Ki  [NEW] +5.38Ki    <hickory_proto::rr::record_data::RData as core::clone::Clone>::clone.8379
  [NEW] +5.13Ki  [NEW] +5.00Ki    <hickory_proto::rr::record_data::RData as core::clone::Clone>::clone.11173
  [NEW] +4.71Ki  [NEW] +4.59Ki    <rustls::error::Error as core::clone::Clone>::clone.9910
  [NEW] +4.71Ki  [NEW] +4.59Ki    <rustls::error::Error as core::clone::Clone>::clone.11188
  [NEW] +3.83Ki  [NEW] +3.71Ki    <webpki::error::Error as core::fmt::Debug>::fmt.11366
  [NEW] +3.66Ki  [NEW] +3.54Ki    <rustls::error::Error as core::fmt::Debug>::fmt.9535
  [NEW] +3.57Ki  [NEW] +3.45Ki    <rustls::error::Error as core::fmt::Debug>::fmt.11189
  [NEW] +2.81Ki  [NEW] +2.69Ki    <figment::error::Error as core::clone::Clone>::clone.7767
  [NEW] +2.33Ki  [NEW] +2.22Ki    <figment::error::Kind as core::fmt::Debug>::fmt.10161
  +0.0%    +312  +0.1%    +948    [446 Others]
  [DEL] -2.33Ki  [DEL] -2.22Ki    <figment::error::Kind as core::fmt::Debug>::fmt.10160
  [DEL] -2.81Ki  [DEL] -2.69Ki    <figment::error::Error as core::clone::Clone>::clone.7766
  [DEL] -3.57Ki  [DEL] -3.45Ki    <rustls::error::Error as core::fmt::Debug>::fmt.11188
  [DEL] -3.66Ki  [DEL] -3.54Ki    <rustls::error::Error as core::fmt::Debug>::fmt.9534
  [DEL] -3.83Ki  [DEL] -3.71Ki    <webpki::error::Error as core::fmt::Debug>::fmt.11365
  [DEL] -4.71Ki  [DEL] -4.59Ki    <rustls::error::Error as core::clone::Clone>::clone.11187
  [DEL] -4.71Ki  [DEL] -4.59Ki    <rustls::error::Error as core::clone::Clone>::clone.9909
  [DEL] -5.13Ki  [DEL] -5.00Ki    <hickory_proto::rr::record_data::RData as core::clone::Clone>::clone.11172
  [DEL] -5.52Ki  [DEL] -5.38Ki    <hickory_proto::rr::record_data::RData as core::clone::Clone>::clone.8378
  [DEL] -10.6Ki  [DEL] -10.5Ki    <saluki_core::data_model::event::Event as core::clone::Clone>::clone.9931
  +0.0%    +312  +0.0%    +948    TOTAL

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Apr 8, 2026

Regression Detector (Agent Data Plane)

Regression Detector Results

Run ID: 9938f772-1c65-4455-b6fd-90637bdb8d34

Baseline: ddb45ed
Comparison: ec9ca3e
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_logs_5mb_memory memory utilization +12.01 [+11.45, +12.57] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_cpu % cpu utilization +0.00 [-4.97, +4.97] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_throughput ingress throughput -0.01 [-0.13, +0.12] 1 (metrics) (profiles) (logs)

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
dsd_uds_512kb_3k_contexts_cpu % cpu utilization +18.24 [-43.71, +80.19] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_memory memory utilization +12.01 [+11.45, +12.57] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_throughput ingress throughput +1.80 [+1.67, +1.94] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_transform_5mb_cpu % cpu utilization +1.46 [-0.82, +3.73] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_cpu % cpu utilization +0.77 [-4.97, +6.52] 1 (metrics) (profiles) (logs)
quality_gates_rss_idle memory utilization +0.51 [+0.49, +0.54] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_medium memory utilization +0.46 [+0.27, +0.65] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_memory memory utilization +0.14 [-0.04, +0.31] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_filtering_5mb_memory memory utilization +0.12 [-0.22, +0.45] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_ultraheavy memory utilization +0.09 [-0.04, +0.22] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_memory memory utilization +0.08 [-0.10, +0.26] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_throughput ingress throughput +0.04 [-0.09, +0.17] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_throughput ingress throughput +0.00 [-0.05, +0.06] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_cpu % cpu utilization +0.00 [-4.97, +4.97] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_filtering_5mb_throughput ingress throughput +0.00 [-0.02, +0.02] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_throughput ingress throughput +0.00 [-0.01, +0.02] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_throughput ingress throughput -0.00 [-0.14, +0.14] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_transform_5mb_throughput ingress throughput -0.00 [-0.02, +0.02] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_throughput ingress throughput -0.00 [-0.02, +0.02] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_throughput ingress throughput -0.00 [-0.05, +0.05] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_throughput ingress throughput -0.01 [-0.13, +0.12] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_memory memory utilization -0.07 [-0.24, +0.10] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_memory memory utilization -0.09 [-0.25, +0.08] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_memory memory utilization -0.21 [-0.39, -0.03] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_cpu % cpu utilization -0.21 [-2.45, +2.03] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_memory memory utilization -0.22 [-0.47, +0.03] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_low memory utilization -0.39 [-0.58, -0.20] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_heavy memory utilization -0.44 [-0.57, -0.31] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_cpu % cpu utilization -0.54 [-54.52, +53.44] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_cpu % cpu utilization -0.77 [-2.15, +0.60] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_transform_5mb_memory memory utilization -0.87 [-1.13, -0.62] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_cpu % cpu utilization -1.30 [-7.43, +4.83] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_filtering_5mb_cpu % cpu utilization -1.86 [-4.31, +0.60] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_memory memory utilization -2.23 [-2.49, -1.96] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_cpu % cpu utilization -8.43 [-38.67, +21.81] 1 (metrics) (profiles) (logs)

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gates_rss_dsd_heavy memory_usage 10/10 114.75MiB ≤ 140MiB (metrics) (profiles) (logs)
quality_gates_rss_dsd_low memory_usage 10/10 34.03MiB ≤ 50MiB (metrics) (profiles) (logs)
quality_gates_rss_dsd_medium memory_usage 10/10 54.28MiB ≤ 75MiB (metrics) (profiles) (logs)
quality_gates_rss_dsd_ultraheavy memory_usage 10/10 171.09MiB ≤ 200MiB (metrics) (profiles) (logs)
quality_gates_rss_idle memory_usage 10/10 21.33MiB ≤ 40MiB (metrics) (profiles) (logs)

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Apr 8, 2026

Regression Detector (Agent + ADP Tag Filtering)

Regression Detector Results

Run ID: e9f3159f-0806-4fdf-854b-f7ebdb93fb44

Baseline: 7ed0f1b671
Comparison: ec9ca3e
Diff

Optimization Goals: ✅ Improvement(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
tagfilter_0metrics % cpu utilization -31.98 [-44.18, -19.78] 1 bounds checks dashboard

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tagfilter_500metrics_notraffic % cpu utilization +41.36 [-64.06, +146.78] 1 bounds checks dashboard
tagfilter_500metrics % cpu utilization -5.66 [-25.66, +14.34] 1 bounds checks dashboard
tagfilter_100metrics % cpu utilization -8.39 [-20.60, +3.82] 1 bounds checks dashboard
tagfilter_0metrics % cpu utilization -31.98 [-44.18, -19.78] 1 bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
tagfilter_0metrics memory_usage 10/10 484.46MiB ≤ 900MiB bounds checks dashboard
tagfilter_100metrics memory_usage 10/10 523.52MiB ≤ 900MiB bounds checks dashboard
tagfilter_500metrics memory_usage 10/10 606.82MiB ≤ 900MiB bounds checks dashboard
tagfilter_500metrics_notraffic memory_usage 10/10 489.24MiB ≤ 900MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@rayz rayz force-pushed the rayz/tagfilter-agent-adp-smp branch from 2fceea7 to ec9ca3e Compare April 9, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci CI/CD, automated testing, etc. area/test All things testing: unit/integration, correctness, SMP regression, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant