Make YAML export of queries multiline #1669
Merged
+24
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the YAML export of nodes to have queries that are multiline rather than a single string separated by newlines.
The original code was modifying the
yaml.SafeDumperclass directly, which didn't reliably apply the multiline representer. The fix creates a new subclass each time. Now queries with newlines will be exported as:Instead of:
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan
N/A