fix: Harden DATE_FORMAT and TO_TIMESTAMP DuckDB translations#2054
Merged
ferenc-csaky merged 1 commit intomainfrom May 5, 2026
Merged
fix: Harden DATE_FORMAT and TO_TIMESTAMP DuckDB translations#2054ferenc-csaky merged 1 commit intomainfrom
DATE_FORMAT and TO_TIMESTAMP DuckDB translations#2054ferenc-csaky merged 1 commit intomainfrom
Conversation
mateczagany
approved these changes
May 5, 2026
cb89a79 to
848a3f8
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2054 +/- ##
============================================
- Coverage 13.00% 12.99% -0.02%
Complexity 803 803
============================================
Files 606 606
Lines 17437 17456 +19
Branches 2102 2101 -1
============================================
Hits 2268 2268
- Misses 14967 14986 +19
Partials 202 202 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle empty strings and
NULLvalues the same way as Flink in the mentioned DuckDB translations.Instead of throwing an exception, the translated expression should return
NULLin all of these incomprehensible situations.