Skip to content

feat: Table type specific PG on conflict behavior#2055

Merged
ferenc-csaky merged 3 commits intomainfrom
feat/pg-on-conflict
May 11, 2026
Merged

feat: Table type specific PG on conflict behavior#2055
ferenc-csaky merged 3 commits intomainfrom
feat/pg-on-conflict

Conversation

@ferenc-csaky
Copy link
Copy Markdown
Collaborator

@ferenc-csaky ferenc-csaky commented May 7, 2026

Key Changes

  • Only relevant logic change in PostgresJdbcEngine
    • Ignore conflicting records for STREAM tables
    • Use the ROWTIME field as on-conflict.timestamp-column for STATE tables if there is a ROWTIME field in the schema
    • Otherwise, default on-conflict behavior
  • Refactored ConnectorConf.Context, eliminmated unused variables
  • Refactored AbstractJDBCEngine#getConnectorOptions siganture, now it takes the ContextBuilder object so it will be more flexible if we introduce variables
  • Adapted snapshots

@ferenc-csaky ferenc-csaky added this to the 0.10.3 milestone May 7, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

❌ Patch coverage is 10.52632% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.00%. Comparing base (6fbf270) to head (c664ff6).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...engine/database/relational/PostgresJdbcEngine.java 0.00% 14 Missing ⚠️
...engine/database/relational/AbstractJDBCEngine.java 33.33% 2 Missing ⚠️
...sqrl/engine/database/relational/IcebergEngine.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2055      +/-   ##
============================================
- Coverage     13.01%   13.00%   -0.02%     
  Complexity      805      805              
============================================
  Files           606      606              
  Lines         17462    17465       +3     
  Branches       2101     2102       +1     
============================================
- Hits           2273     2271       -2     
- Misses        14987    14992       +5     
  Partials        202      202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@mbroecheler mbroecheler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change for DRYness.

@ferenc-csaky ferenc-csaky force-pushed the feat/pg-on-conflict branch from 77fb8c1 to 11a58bd Compare May 11, 2026 04:57
@ferenc-csaky ferenc-csaky force-pushed the feat/pg-on-conflict branch from 11a58bd to c664ff6 Compare May 11, 2026 04:58
@ferenc-csaky ferenc-csaky merged commit 114962a into main May 11, 2026
16 checks passed
@ferenc-csaky ferenc-csaky deleted the feat/pg-on-conflict branch May 11, 2026 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants