docs: fix CHANGELOG lens-proposal drift (no delete_lens kind added — pattern report inside)#94
Merged
Merged
Conversation
Two corrections in [Unreleased], both from a lens-capability audit: - The lenses entry claimed add_lens/update_lens proposals work "over the hosted MCP server — vault_propose". False today: the cloud vault_propose kind allowlist has no lens kinds (cloud fix queued separately). Reworded to what is true — the kinds exist in the local proposal store and CLI; hosted-MCP propose support is pending. - The vault import-story-bank entry still said "no lens proposal kind exists yet", stale since the lens kinds landed in this same Unreleased section. Replaced with the accurate reason (the importer does not stage lens proposals). No delete_lens proposal kind is added: no delete_* proposal kind exists for any entity (in code or the vault-v1 $defs/proposal enum) — deletion is deliberately CLI-only (vault lens remove), so adding one unilaterally would invent a new contract pattern. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
claude-dataviking
requested review from
openclaw-dv and
the-data-viking
as code owners
July 15, 2026 23:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two CHANGELOG corrections from the lens-capability audit, both in
[Unreleased]:add_lens/update_lensproposals are authored "over the hosted MCP server —vault_propose". That is not true today: the cloudvault_proposekind allowlist contains no lens kinds (a cloud-side fix is queued separately). Reworded to what is true — the kinds exist in the local proposal store and CLI (traitprint proposals add); hosted-MCP propose support is pending.vault import-story-bankentry still said "no lens proposal kind exists yet" — superseded by the lens entry in the same Unreleased section. Replaced with the accurate reason: the importer does not stage lens proposals.What was deliberately NOT done:
delete_lensproposal kindThe audit also flagged that
PROPOSAL_KINDShas nodelete_lenswhileVaultStore.remove_lensandvault lens removeexist. Before adding one, I checked whether delete proposal kinds are a pattern for any entity type:src/traitprint/proposals.pyPROPOSAL_KINDS: onlyadd_*/update_*plusupdate_profile— zerodelete_*kinds for any entity.docs/schema/vault-v1/vault-v1.schema.json$defs/proposalkind enum): same — no delete kinds.So proposal-driven deletion does not exist anywhere in the system; deletion is deliberately a local, direct-CLI-only operation. Adding
delete_lensunilaterally would invent a new contract pattern (and, per the "don't drift from cloud" constraint in CLAUDE.md, would need coordination with traitprint-cloud plus a contract revision). If proposal-driven deletion is wanted, it should be designed once for all entity types via an issue + contract revision, not bolted onto lenses alone.Gates
pytest -q: 1028 passed, 3 skippedruff check src/ tests/: cleanmypy src/: clean🤖 Generated with Claude Code