fix: remove remaining "id" variable usage#50
Merged
DavidLapous merged 1 commit intoDavidLapous:mainfrom Oct 27, 2025
Merged
Conversation
DavidLapous
approved these changes
Oct 27, 2025
Owner
DavidLapous
left a comment
DavidLapous
left a comment
There was a problem hiding this comment.
Thank you for the catch and the fixes !
The rhomboid thing is a WIP code that I forgot to finish (cf #7). I (lazily) merged it to be able to git switch to your branch., and missed the last id, my bad.
Contributor
Author
|
Thank you for integrating this so quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @DavidLapous,
I hate to bring not so good news. I got the intuition to double check whether, there was maybe
a usage of this removed "id" parameter that I forget to fix. And I found two problems:
minimal_presentationfunction will fail if a non-empty list of degrees is given.rhomboid_tiling_to_slicerfunction also has a bug.