Small C++ data structures update + slicer constructors#51
Merged
DavidLapous merged 3 commits intoDavidLapous:mainfrom Dec 19, 2025
Merged
Small C++ data structures update + slicer constructors#51DavidLapous merged 3 commits intoDavidLapous:mainfrom
DavidLapous merged 3 commits intoDavidLapous:mainfrom
Conversation
DavidLapous
approved these changes
Dec 19, 2025
Owner
DavidLapous
left a comment
DavidLapous
left a comment
There was a problem hiding this comment.
LGTM, I will link that to the python interface later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated again the C++ structures from Gudhi + added a copy constructor for Slicer with different template parameters. But I did not do any python bindings for the new constructor. @DavidLapous I will let you take care of it.