Merged
Conversation
|
GregoireW
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates all rule files in the
dblinter/rulesdirectory to consistently exclude certain schemas from their database queries by using theEXCLUDED_SCHEMAS_STRconstant. This change improves the accuracy of linting checks by ensuring that system or irrelevant schemas are not considered in rule evaluations.Schema exclusion improvements:
Added import of
EXCLUDED_SCHEMAS_STRfromdblinter/function_libraryto all rule files to standardize schema exclusion logic. [1] [2] [3] [4] [5] [6] [7] [8] [9]Updated all relevant SQL queries in rule functions (
TableWithoutPrimaryKey,TableWithoutIndex,TableWithRedundantIndex,TableWithFkNotIndexed,TableWithPotentialMissingIdx,TableWithFkMismatch,TableWithRoleNotGranted,ReservedKeyWord,TableWithUppercase) to exclude schemas listed inEXCLUDED_SCHEMAS_STR. This ensures that checks ignore tables in excluded schemas. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]These changes make the rule checks more robust and prevent false positives or unnecessary linting on tables within schemas that should be ignored.