Skip to content

fix(t-rules): exclude schemas at table level#27

Merged
GregoireW merged 1 commit intomainfrom
fix/t_rules_exclude
Nov 13, 2025
Merged

fix(t-rules): exclude schemas at table level#27
GregoireW merged 1 commit intomainfrom
fix/t_rules_exclude

Conversation

@pmpetit
Copy link
Contributor

@pmpetit pmpetit commented Nov 13, 2025

This pull request refactors the schema exclusion logic in dblinter/scan.py to improve maintainability and consistency. The hardcoded lists of excluded schemas in SQL queries have been replaced with a single constant, EXCLUDED_SCHEMAS_STR, imported from dblinter/function_library. This makes it easier to manage and update excluded schemas in one place.

Refactoring and maintainability improvements:

  • Replaced hardcoded excluded schema lists in SQL queries within perform_schema_check and perform_table_check functions with the EXCLUDED_SCHEMAS_STR constant for consistency and easier updates. [1] [2]
  • Added import of EXCLUDED_SCHEMAS_STR from dblinter/function_library to dblinter/scan.py.# PR Description

@pmpetit pmpetit force-pushed the fix/t_rules_exclude branch from d43c0c2 to 953e352 Compare November 13, 2025 15:46
@sonarqubecloud
Copy link

@pmpetit pmpetit requested a review from GregoireW November 13, 2025 15:49
@GregoireW GregoireW merged commit ca0080f into main Nov 13, 2025
5 checks passed
@GregoireW GregoireW deleted the fix/t_rules_exclude branch November 13, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants