Skip to content

fix(t-rules): delete-tablewithoutindex#28

Merged
pmpetit merged 6 commits intomainfrom
fix/rules/delete-tablewithoutindex
Nov 18, 2025
Merged

fix(t-rules): delete-tablewithoutindex#28
pmpetit merged 6 commits intomainfrom
fix/rules/delete-tablewithoutindex

Conversation

@everleene
Copy link
Collaborator

@everleene everleene commented Nov 14, 2025

PR Description

This pull request removes the "TableWithoutIndex" rule (T002) from the codebase, configuration, and tests, and introduces a new test fixture to ensure database cleanup after each test. It also makes minor improvements to the code formatting workflow and configuration.

Rule removal and related cleanup:

  • Removed the "TableWithoutIndex" rule (T002) from all configuration files (dblinter.cfg, dblinter/default_config.yaml, tests/data/good_config.yaml), the implementation (dblinter/rules/T002/TableWithoutIndex.py), and the associated tests (tests/rules/T002/test_TableWithoutIndex.py). Test assertions in tests/test_main.py that referenced this rule were also updated or removed. [1] [2] [3] [4] [5] [6] [7] [8]

Test infrastructure improvements:

  • Added a new cleanup_database fixture in tests/conftest.py to automatically clean up the database after each test, preventing test pollution and ensuring isolation between tests.

Workflow and configuration updates:

  • Updated the isort command in GitHub Actions workflows to only check the dblinter/ and tests/ directories, improving performance and relevance. (.github/workflows/build-main.yaml, .github/workflows/build-pr.yaml) [1] [2]
  • Added a black configuration to exclude dblinter.cfg from formatting. (pyproject.toml)

Test assertion fixes:

  • Adjusted test assertions in tests/test_main.py to reflect the removal of the "TableWithoutIndex" rule, ensuring tests only check for remaining relevant messages. [1] [2] [3] [4]# PR Description

Known limitations / corner cases (if any)

N/A

@CLAassistant
Copy link

CLAassistant commented Nov 14, 2025

CLA assistant check
All committers have signed the CLA.

@pmpetit pmpetit self-requested a review November 17, 2025 08:34
Copy link
Collaborator

@vincentmoreaudba vincentmoreaudba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Copy link
Contributor

@pmpetit pmpetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@pmpetit pmpetit merged commit 73f1949 into main Nov 18, 2025
5 checks passed
@pmpetit pmpetit deleted the fix/rules/delete-tablewithoutindex branch November 18, 2025 14:03
@everleene everleene changed the title delete-tablewithoutindex fix(t-rules): delete-tablewithoutindex Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants