Merged
Conversation
pmpetit
approved these changes
Nov 17, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR Description
This pull request removes the "TableWithoutIndex" rule (T002) from the codebase, configuration, and tests, and introduces a new test fixture to ensure database cleanup after each test. It also makes minor improvements to the code formatting workflow and configuration.
Rule removal and related cleanup:
dblinter.cfg,dblinter/default_config.yaml,tests/data/good_config.yaml), the implementation (dblinter/rules/T002/TableWithoutIndex.py), and the associated tests (tests/rules/T002/test_TableWithoutIndex.py). Test assertions intests/test_main.pythat referenced this rule were also updated or removed. [1] [2] [3] [4] [5] [6] [7] [8]Test infrastructure improvements:
cleanup_databasefixture intests/conftest.pyto automatically clean up the database after each test, preventing test pollution and ensuring isolation between tests.Workflow and configuration updates:
dblinter/andtests/directories, improving performance and relevance. (.github/workflows/build-main.yaml,.github/workflows/build-pr.yaml) [1] [2]blackconfiguration to excludedblinter.cfgfrom formatting. (pyproject.toml)Test assertion fixes:
tests/test_main.pyto reflect the removal of the "TableWithoutIndex" rule, ensuring tests only check for remaining relevant messages. [1] [2] [3] [4]# PR DescriptionKnown limitations / corner cases (if any)
N/A