Skip to content

fix(t-rules): reorganize table rules in relation to database rules#29

Merged
pmpetit merged 3 commits intomainfrom
fix/rules/reorganize-t-vs-b
Nov 26, 2025
Merged

fix(t-rules): reorganize table rules in relation to database rules#29
pmpetit merged 3 commits intomainfrom
fix/rules/reorganize-t-vs-b

Conversation

@everleene
Copy link
Collaborator

@everleene everleene commented Nov 25, 2025

PR Description

This pull request reorganizes and refines the table linting rules in the configuration files, improving clarity, consistency, and maintainability. The main changes include reassigning rule IDs for better ordering, splitting and renaming some rules, adjusting rule parameters and descriptions, and adding or moving certain rules to improve logical grouping.

Initial state

B rules T rules
B001/HowManyTableWithoutPrimaryKey.py T001/TableWithoutPrimaryKey.py
B002/HowManyRedudantIndex.py
B003/HowManyTableWithoutIndexOnFk.py T003/TableWithRedundantIndex.py
B004/HowManyUnusedIndex.py T004/TableWithFkNotIndexed.py
B005/UnsecuredPublicSchema.py T005/TableWithPotentialMissingIdx.py
B006/HowManyTablesWithUppercase.py T006/TableWithFkOutsideSchema.py
T007/TableWithUnusedIndex.py
T008/TableWithFkMismatch.py
T009/TableWithRoleNotGranted.py
T010/ReservedKeyWord.py
T011/TableWithUppercase.py
T012/TableWithSensibleColumn.py

Target

B rules T rules
B001/HowManyTableWithoutPrimaryKey.py T001/TableWithoutPrimaryKey.py
B002/HowManyRedudantIndex.py T003/TableWithRedundantIndex.py -> T002
B003/HowManyTableWithoutIndexOnFk.py T004/TableWithFkNotIndexed.py -> T003
B004/HowManyUnusedIndex.py T007/TableWithUnusedIndex.py -> T004
B005/UnsecuredPublicSchema.py
B006/HowManyTablesWithUppercase.py T011/TableWithUppercase.py -> T006
T006/TableWithFkOutsideSchema.py -> T007
T008/TableWithFkMismatch.py
T009/TableWithRoleNotGranted.py
T010/ReservedKeyWord.py
T005/TableWithPotentialMissingIdx.py -> T011
T012/TableWithSensibleColumn.py

These updates make the linting configuration easier to understand and maintain, while also improving the precision of the rules and their enforcement.

Known limitations / corner cases (if any)

N/A

@sonarqubecloud
Copy link

Copy link
Collaborator

@vincentmoreaudba vincentmoreaudba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pmpetit pmpetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@pmpetit pmpetit merged commit 0a6318c into main Nov 26, 2025
5 checks passed
@pmpetit pmpetit deleted the fix/rules/reorganize-t-vs-b branch November 26, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants