Open
Conversation
timtogan
requested changes
Mar 30, 2026
Comment on lines
34
to
43
| ``` | ||
| public static enum TemperatureLimit { | ||
| public static enum MotorConfig { | ||
| NEO(70), NEO_550(40); | ||
|
|
||
| public final int limit; | ||
|
|
||
| private TemperatureLimit(int limit) { | ||
| private MotorConfig(int limit) { | ||
| this.limit = limit; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| ``` | |
| public static enum TemperatureLimit { | |
| public static enum MotorConfig { | |
| NEO(70), NEO_550(40); | |
| public final int limit; | |
| private TemperatureLimit(int limit) { | |
| private MotorConfig(int limit) { | |
| this.limit = limit; | |
| } | |
| } |
public static enum MotorConfig {
NEO(70), NEO_550(40);
public final int temperatureLimitCelsius;
private MotorConfig(int temperatureLimitCelsius) {
this.temperatureLimitCelsius = temperatureLimitCelsius;
}
}
Comment on lines
+8
to
+9
| *** | ||
| <sub> We rarely use pneumatics because of their complexity and lack of versatility compared to motors. </sub> No newline at end of file |
Member
There was a problem hiding this comment.
Suggested change
| *** | |
| <sub> We rarely use pneumatics because of their complexity and lack of versatility compared to motors. </sub> | |
| *** | |
| !!! note | |
| We rarely use pneumatics because of their complexity and lack of versatility compared to motors. |
docs/section-3/basic-control.md
Outdated
| The two motor types: `kBrushless` and `kBrushed` require the controller to power the motors in different ways, and you can end up destroying the motor by using the wrong motor type. The easiest way to tell the difference is that brushless motors use three wires while brushed motors use two. Most of the motors we will use with SparkMaxes are brushless. | ||
|
|
||
| Now let us use lib199's MotorControllerFactory method. | ||
| Lib199 is a repository which contains many methods and objects we reuse over many projects and years. Now let's use lib199's MotorControllerFactory methodto create the SparkMax |
Member
There was a problem hiding this comment.
Suggested change
| Lib199 is a repository which contains many methods and objects we reuse over many projects and years. Now let's use lib199's MotorControllerFactory methodto create the SparkMax | |
| Lib199 is our custom java library which contains many methods and objects we reuse over many projects and years. Now let's use lib199's MotorControllerFactory to create a SparkMax. |
| - Quickly look through the entire site to make sure everything is correct | ||
| - Make sure whoever is presenting the presentations in section 1 are familiar with them | ||
| - You can coordinate with SenAct on maybe giving the presentation together or having a SenAct team member do the presentation | ||
| - You can coordinate with senac on maybe giving the presentation together or having a senac team member do the presentation |
Member
There was a problem hiding this comment.
Suggested change
| - You can coordinate with senac on maybe giving the presentation together or having a senac team member do the presentation | |
| - You can coordinate with SENAC on maybe giving the presentation together or having a SENAC team member do the presentation |
| # Electronics | ||
|
|
||
| We have significant overlap with SenAct training. If you want more details on SenAct components you can go through [their Electronics presentation](https://docs.google.com/presentation/d/1Y2GSd2B3aV2_6J5xKNS-_xWRiGW_daArdgr4zasUuno/edit#slide=id.g253cb92c37_0_37). Here, we will cover the parts relevant to programming. | ||
| We have significant overlap with senac training. If you want more details on senac components you can go through [their Electronics presentation](https://docs.google.com/presentation/d/1Y2GSd2B3aV2_6J5xKNS-_xWRiGW_daArdgr4zasUuno/edit#slide=id.g253cb92c37_0_37). Here, we will cover the parts relevant to programming. |
Member
There was a problem hiding this comment.
Suggested change
| We have significant overlap with senac training. If you want more details on senac components you can go through [their Electronics presentation](https://docs.google.com/presentation/d/1Y2GSd2B3aV2_6J5xKNS-_xWRiGW_daArdgr4zasUuno/edit#slide=id.g253cb92c37_0_37). Here, we will cover the parts relevant to programming. | |
| We have significant overlap with SENAC training. If you want more details on SENAC components you can go through [their Electronics presentation](https://docs.google.com/presentation/d/1Y2GSd2B3aV2_6J5xKNS-_xWRiGW_daArdgr4zasUuno/edit#slide=id.g253cb92c37_0_37). Here, we will cover the parts relevant to programming. |
| @@ -1,7 +1,9 @@ | |||
| Similar to elex, SenAct also has [a pneumatics presentation](https://docs.google.com/presentation/d/1UDH-Om2QCeOL6JKvXSvE9Xdm5i8acvCqRSJa4wcBMAM/edit#slide=id.g2573de0a58_0_73). Take some time to read through it. | |||
| Similar to elex, Senac also has [a pneumatics presentation](https://docs.google.com/presentation/d/1UDH-Om2QCeOL6JKvXSvE9Xdm5i8acvCqRSJa4wcBMAM/edit#slide=id.g2573de0a58_0_73). Take some time to read through it. | |||
Member
There was a problem hiding this comment.
Suggested change
| Similar to elex, Senac also has [a pneumatics presentation](https://docs.google.com/presentation/d/1UDH-Om2QCeOL6JKvXSvE9Xdm5i8acvCqRSJa4wcBMAM/edit#slide=id.g2573de0a58_0_73). Take some time to read through it. | |
| Similar to elex, SENAC also has [a pneumatics presentation](https://docs.google.com/presentation/d/1UDH-Om2QCeOL6JKvXSvE9Xdm5i8acvCqRSJa4wcBMAM/edit#slide=id.g2573de0a58_0_73). Take some time to read through it. |
Comment on lines
+14
to
15
| - Browse files (including on the Roborio) | ||
| - Installing anything you could think of |
Member
There was a problem hiding this comment.
Suggested change
| - Browse files (including on the Roborio) | |
| - Installing anything you could think of | |
| - Browse files (including on the Roborio and systemcore) | |
| - Installing anything you could think of |
|
|
||
| You do not have to remember the specific types of motors used and will not risk destroying the motor. If you were to look at the [`createSparkMax` in lib199](https://github.com/DeepBlueRobotics/lib199/blob/master/src/main/java/org/carlmontrobotics/lib199/MotorControllerFactory.java), there are a lot of features implemented to check for motor types, debugging, simulation, etc. | ||
| The method also asks for a temperature limit. In lib199, we have defined our temperature limits as enums. You just need to know the type of motor used, then you can put in "TemperatureLimit.[insert motor type]" as the parameter. The two types are `NEO` and `NEO_550`. | ||
| The method also asks for a motor configuration. In lib199. All You need to know is the type of motor used, then you can put in "MotorConfig.[insert motor type]" as the parameter. The two types are `SPARK_MAX` and `SPARK_FLEX`. |
Member
There was a problem hiding this comment.
- there is more than 2 MotorConfigs
- Motor config is a motor type not a motor controller type. Spark max/flex is a motor controller type, neo neo_550 neo_2 etc are motor types.
Comment on lines
+68
to
69
| SparkMax motor = MotorControllerFactory.createSparkMax(1); | ||
| RelativeEncoder encoder = motor.getEncoder(); |
| Think of this as a "ritual" of public defacement in order to initiate your learning of Github. | ||
|
|
||
| Now stage and commit your changes with the message `add [your name]`, and then push your changes to make the branch public. Refer to the [Git tutorial](https://guides.github.com/introduction/git-handbook/) and [VS Code tutorial](https://code.visualstudio.com/docs/editor/versioncontrol) if needed. | ||
| Now stage and commit your changes with the message `added [your name] to intro files`, and then push your changes to make the branch public. Refer to the [Git tutorial](https://guides.github.com/introduction/git-handbook/) and [VS Code tutorial](https://code.visualstudio.com/docs/editor/versioncontrol) if needed. |
Member
There was a problem hiding this comment.
as noted by the note at the bottom, commit names are written in simple present tense by convention.
Suggested change
| Now stage and commit your changes with the message `added [your name] to intro files`, and then push your changes to make the branch public. Refer to the [Git tutorial](https://guides.github.com/introduction/git-handbook/) and [VS Code tutorial](https://code.visualstudio.com/docs/editor/versioncontrol) if needed. | |
| Now stage and commit your changes with the message `add [your name] to intro files`, and then push your changes to make the branch public. Refer to the [Git tutorial](https://guides.github.com/introduction/git-handbook/) and [VS Code tutorial](https://code.visualstudio.com/docs/editor/versioncontrol) if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.