inject x-defang-llm on model services, convert fixup snapshots to YAML#2152
Merged
Conversation
Switches TestFixup from json.MarshalIndent to yaml.Marshal so that compose extensions (x-defang-llm, etc.) are included in snapshots — extensions have json:"-" in compose-go's types and were invisible to the JSON-based snapshots. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
📝 WalkthroughWalkthroughCompose fixup generation now serializes fixtures as YAML, and generated model services receive ChangesCompose fixup YAML migration
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
lionello
reviewed
Jun 24, 2026
lionello
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x-defang-llm: trueon services derived from the composemodels:top-level block (in addition to the existingx-defang-llmextension path)TestFixupsnapshots from JSON to YAML so that compose extensions (x-defang-llm, etc.) are visible in snapshots — compose-go tagsExtensionsasjson:"-", making all extension changes invisible to the previous JSON-based snapshotsBlocks DefangLabs/samples#647
Test plan
TestFixuppasses and the regenerated snapshots showx-defang-llm: trueon model servicesx-defang-llmappears correctly on services generated frommodels:entries in a real compose fileSummary by CodeRabbit
New Features
x-defang-llmmetadata.Bug Fixes