Skip to content

Support loading sites via yaml, make defined enrollment top level#352

Merged
nbrownus merged 4 commits intomainfrom
yaml-import
Feb 19, 2026
Merged

Support loading sites via yaml, make defined enrollment top level#352
nbrownus merged 4 commits intomainfrom
yaml-import

Conversation

@nbrownus
Copy link
Contributor

@nbrownus nbrownus commented Feb 18, 2026

This changes the + button on the top left. Tapping it will now pop a modal bottom sheet with a few options for creating a site.

From scratch - this is the old style type it all in and save
From file - this opens a file picker and allows you to select a nebula config.yaml file. Any applicable configuration will be imported into a new site.
Enroll with defined.net - this is the old enrollment screen that you used to get to from the settings screen.

Screenshot 2026-02-17 at 9 45 48 PM

Things to test

iOS:

  • Saving a site from scratch still works, no funky stuff when toggling the site or refreshing site details.
  • Saving a site from file, same story regarding asserting no funky stuff.
  • Enroll with defined.net code still works.
  • Deep linking enrollment with defined still works.

Android:

  • Saving a site from scratch still works, no funky stuff when toggling the site or refreshing site details.
  • Saving a site from file, same story regarding asserting no funky stuff.
  • Enroll with defined.net code still works.
  • Deep linking enrollment with defined still works.

Closes #135
Possible closes #152

@nbrownus nbrownus marked this pull request as ready for review February 18, 2026 15:39
}

final site = Site();
var lighthouses = _fromYamlLighthouse(site, yaml);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we don't currently do firewall really on mobile, do you wanna explicitly reject it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a slight desire towards leaving it at ignored. At best it would be a type of warning saying "we ignored a thing you can't set by hand anyway" which doesn't seem super helpful and also open up questions around announcing ignoring other things we don't care about.

JackDoan
JackDoan previously approved these changes Feb 18, 2026
Copy link
Contributor

@JackDoan JackDoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some notes, overall lgtm

@nbrownus nbrownus merged commit 800d837 into main Feb 19, 2026
6 checks passed
@nbrownus nbrownus deleted the yaml-import branch February 19, 2026 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow import of private key from key file on Android Feature request: Allow loading of a fully-formed config.yml file

3 participants

Comments