Support loading sites via yaml, make defined enrollment top level#352
Merged
Support loading sites via yaml, make defined enrollment top level#352
Conversation
jasikpark
reviewed
Feb 18, 2026
jasikpark
reviewed
Feb 18, 2026
JackDoan
reviewed
Feb 18, 2026
| } | ||
|
|
||
| final site = Site(); | ||
| var lighthouses = _fromYamlLighthouse(site, yaml); |
Contributor
There was a problem hiding this comment.
I know we don't currently do firewall really on mobile, do you wanna explicitly reject it here?
Contributor
Author
There was a problem hiding this comment.
I have a slight desire towards leaving it at ignored. At best it would be a type of warning saying "we ignored a thing you can't set by hand anyway" which doesn't seem super helpful and also open up questions around announcing ignoring other things we don't care about.
JackDoan
reviewed
Feb 18, 2026
JackDoan
previously approved these changes
Feb 18, 2026
Contributor
JackDoan
left a comment
There was a problem hiding this comment.
some notes, overall lgtm
JackDoan
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the
+button on the top left. Tapping it will now pop a modal bottom sheet with a few options for creating a site.From scratch - this is the old style type it all in and save
From file - this opens a file picker and allows you to select a nebula config.yaml file. Any applicable configuration will be imported into a new site.
Enroll with defined.net - this is the old enrollment screen that you used to get to from the settings screen.
Things to test
iOS:
Android:
Closes #135
Possible closes #152