Fix crash when recipe output is module and another crash when player opens equipment grid#1
Open
lesacar wants to merge 1 commit intoDeltaFA:mainfrom
Open
Conversation
…opens equipment grid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i've been making my own mod and wanted to add custom recipes that give quality without the rng grind, but noticed no matter if I used qrc_legendary_speed-module-3 or any variation of it or adding "quality = 'legendary" to the { ingredients } table, I just couldn't get it to work, either nothing would happen or I would get a crash, the issue was this mod checks data.raw.item[ITEM_NAME], but modules are their own separate thing in data.raw.module[ITEM_NAME], and they inherit all the item properties, so the fix was simple, and another issue I found was randomly putting my portable fission reactor in my armor but as soon as I opened the armor grid I got a crash, the fix was to just check that player.opened is not the grid since it's missing a key that other "openable" things have. I have not extensively tested this, but it shouldn't take long to test the original mod and my version with adding a custom module quality recipe and just opening the armor grid, if you don't want to create a sample mod to test quality module crafting you can also use my mod