Numpy 2.0 support #259
Merged
Numpy 2.0 support #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Alright, the current test failures all come from the test_burn.py tests, and the problem is that the mapbox_earcut wheel has to be rebuilt for numpy 2.0. See: skogler/mapbox_earcut_python#15 Unfortunately, the PR has been open for a while... |
Collaborator
Author
|
I've added numpy < 2 (ironically) so it'll pass the tests and I can work on py39 compat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes seem limited. Numba celltree seems to be up and running.
Still running into a some issues.