Skip to content

Replace browser methods with custom modals, tech debt cleanup, improvements#510

Merged
ussaama merged 1 commit into
testingfrom
fixes-and-improvements-3-apr
Apr 3, 2026
Merged

Replace browser methods with custom modals, tech debt cleanup, improvements#510
ussaama merged 1 commit into
testingfrom
fixes-and-improvements-3-apr

Conversation

@ussaama
Copy link
Copy Markdown
Contributor

@ussaama ussaama commented Apr 3, 2026

…cleanup on avatar/logo removal

  • Replace all window.confirm() calls with ConfirmModal across 12 components: ChatAccordion (delete chat), ConversationDangerZone (delete conversation), ProjectDangerZone (delete project — now 2-step confirmation), ProjectPortalEditor (disable anonymization, delete custom topic), ProjectTagsInput (delete tag), LanguagePicker (change language during chat), ProjectConversationOverview (regenerate summary), ProjectLibrary (generate library), ProjectReportRoute (delete report), TemplatesModal (delete template), AccountSettingsCard (remove avatar), WhitelabelLogoCard (remove logo)
  • Replace window.prompt() with InputModal in ChatAccordion (rename chat)
  • Replace window.alert() / native alert() with toast notifications: PermissionErrorModal (microphone denied), VerifyEmail (invalid token), useCopyToRichText (clipboard failure)
  • Add reusable ConfirmModal and InputModal components to common/
  • Align template edit view buttons: Delete as subtle red button + Save as primary, in a right-aligned Group (matching ConfirmModal layout)
  • Backend: delete orphaned Directus files when removing avatar or whitelabel logo (previously files were left behind)
  • Backend: wrap blocking Directus calls in run_in_thread_pool for async safety
  • Fix MarkdownWYSIWYG toolbar position to use CSS variable instead of hardcoded sticky, and set it from report editor context
  • Minor formatting cleanups (line length, import ordering)
  • Doc updates for future references

…cleanup on avatar/logo removal

- Replace all window.confirm() calls with ConfirmModal across 12 components:
  ChatAccordion (delete chat), ConversationDangerZone (delete conversation),
  ProjectDangerZone (delete project — now 2-step confirmation), ProjectPortalEditor
  (disable anonymization, delete custom topic), ProjectTagsInput (delete tag),
  LanguagePicker (change language during chat), ProjectConversationOverview
  (regenerate summary), ProjectLibrary (generate library), ProjectReportRoute
  (delete report), TemplatesModal (delete template), AccountSettingsCard
  (remove avatar), WhitelabelLogoCard (remove logo)
- Replace window.prompt() with InputModal in ChatAccordion (rename chat)
- Replace window.alert() / native alert() with toast notifications:
  PermissionErrorModal (microphone denied), VerifyEmail (invalid token),
  useCopyToRichText (clipboard failure)
- Add reusable ConfirmModal and InputModal components to common/
- Align template edit view buttons: Delete as subtle red button + Save as
  primary, in a right-aligned Group (matching ConfirmModal layout)
- Backend: delete orphaned Directus files when removing avatar or whitelabel
  logo (previously files were left behind)
- Backend: wrap blocking Directus calls in run_in_thread_pool for async safety
- Fix MarkdownWYSIWYG toolbar position to use CSS variable instead of
  hardcoded sticky, and set it from report editor context
- Minor formatting cleanups (line length, import ordering)
- Doc updates for future references
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 3, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d1af37a3-ad0d-4fcb-91b5-426d71006166

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fixes-and-improvements-3-apr

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ussaama ussaama merged commit 23a0ee7 into testing Apr 3, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant