Replace browser methods with custom modals, tech debt cleanup, improvements#510
Merged
Conversation
…cleanup on avatar/logo removal - Replace all window.confirm() calls with ConfirmModal across 12 components: ChatAccordion (delete chat), ConversationDangerZone (delete conversation), ProjectDangerZone (delete project — now 2-step confirmation), ProjectPortalEditor (disable anonymization, delete custom topic), ProjectTagsInput (delete tag), LanguagePicker (change language during chat), ProjectConversationOverview (regenerate summary), ProjectLibrary (generate library), ProjectReportRoute (delete report), TemplatesModal (delete template), AccountSettingsCard (remove avatar), WhitelabelLogoCard (remove logo) - Replace window.prompt() with InputModal in ChatAccordion (rename chat) - Replace window.alert() / native alert() with toast notifications: PermissionErrorModal (microphone denied), VerifyEmail (invalid token), useCopyToRichText (clipboard failure) - Add reusable ConfirmModal and InputModal components to common/ - Align template edit view buttons: Delete as subtle red button + Save as primary, in a right-aligned Group (matching ConfirmModal layout) - Backend: delete orphaned Directus files when removing avatar or whitelabel logo (previously files were left behind) - Backend: wrap blocking Directus calls in run_in_thread_pool for async safety - Fix MarkdownWYSIWYG toolbar position to use CSS variable instead of hardcoded sticky, and set it from report editor context - Minor formatting cleanups (line length, import ordering) - Doc updates for future references
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cleanup on avatar/logo removal