Skip to content

docs(github-pr-workflow): require system-consequence section in every PR#84

Merged
spashii merged 1 commit into
mainfrom
sam/pr-description-system-consequence
May 25, 2026
Merged

docs(github-pr-workflow): require system-consequence section in every PR#84
spashii merged 1 commit into
mainfrom
sam/pr-description-system-consequence

Conversation

@spashii
Copy link
Copy Markdown
Member

@spashii spashii commented May 25, 2026

What this changes

  • every PR (Sam's repo or any work repo) now opens with a concrete "What this changes" section — one line per observable change, lead with consequence, cite artifact at end-of-line — src/skills/github-pr-workflow/skill.md
  • reviewers can read those lines alone and decide whether to approve without opening the diff
  • future readers searching git log / PR history find what each PR did in operator-level prose, not by diffing files
  • the rule applies to all repos Sam opens PRs in (sam, echo, anything else) — not just dembrane/sam
  • exception carved out for typo fixes and one-line doc edits

Why this fits Sam's mission

The README's first motivation — writing requirements is at (almost) the same abstraction level as writing code — lands here. The PR description is where the new requirement, the new capability, the new constraint gets written in operator-level prose so the next person (or future-Sam reading git log) finds the what changed without having to reconstruct it from the diff.

This PR is itself the first artifact under the new rule. The "What this changes" section above is the format.

Confidence

High. Docs-only change to one skill file. No runtime behavior; existing 181 tests pass unchanged.

Every PR (Sam's repo or any work repo) now opens with a concrete
account of what changes in the running system because of this PR.
One line per observable change, consequence-first, artifact at
end-of-line. Reviewers can decide without opening the diff; future
readers searching `git log` find what each PR did in prose, not by
diffing files.

Ties to the README's first motivation — writing requirements at
the same abstraction level as code lands HERE: the PR description
is where the new requirement / capability / constraint gets stated
in operator-level prose.

Skip only for typo fixes and one-line doc edits.
@spashii spashii merged commit 2271907 into main May 25, 2026
2 checks passed
@spashii spashii deleted the sam/pr-description-system-consequence branch May 25, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant