Align capability bundle terminology#25
Conversation
There was a problem hiding this comment.
Code Review
This pull request performs a comprehensive renaming of the 'Skill' system to 'Capability Bundles' throughout the codebase, including source files, headers, build configurations, and documentation. It introduces the new capability framework while maintaining a compatibility shim in ec_skill.h for existing integrations. The review feedback suggests improving the robustness of the initialization process by having ec_capability_init return an error code to signal failures such as tool registration overflows or system prompt buffer truncations.
| * Iterates EC_CAPABILITY_TABLE, registers every tool with ec_tool, and builds | ||
| * the combined system prompt. Call once at startup before the agent loop. | ||
| */ | ||
| void ec_capability_init(void); |
There was a problem hiding this comment.
The ec_capability_init function currently returns void, but it performs several operations that could fail, such as registering tools (which can fail if the registry is full) and building the system prompt (which can fail if the buffer overflows). Consider returning an error code (e.g., int) to allow the caller to handle initialization failures gracefully, especially in an embedded context where silent truncation of the system prompt or missing tools can lead to confusing behavior.
011fa5c to
6709cb5
Compare
Summary
Verification