Skip to content

Align capability bundle terminology#25

Merged
DemonGiggle merged 1 commit into
test/improve-coveragefrom
refactor/capability-terminology
May 16, 2026
Merged

Align capability bundle terminology#25
DemonGiggle merged 1 commit into
test/improve-coveragefrom
refactor/capability-terminology

Conversation

@DemonGiggle
Copy link
Copy Markdown
Owner

@DemonGiggle DemonGiggle commented May 16, 2026

Summary

  • rename the public capability-bundle API from ec_skill_* to ec_capability_* terminology
  • rename implementation files to ec_capability.c and ec_capability_table.c
  • remove the unreleased ec_skill.h compatibility shim so the codebase uses the correct terminology cleanly
  • update docs, comments, tests, and config naming so model-callable functions are "tools" and compile-time tool/context/policy groups are "capability bundles"

Verification

  • cmake -S . -B build-posix -DEC_PLATFORM=POSIX -DEC_ENABLE_TLS=OFF
  • cmake --build build-posix
  • ctest --test-dir build-posix --output-on-failure
  • cmake -S . -B build-host-sim -DEC_PLATFORM=POSIX -DEC_HOST_SIM=ON -DEC_ENABLE_TLS=OFF
  • cmake --build build-host-sim
  • ctest --test-dir build-host-sim --output-on-failure
  • cmake -S . -B build-baremetal -DEC_PLATFORM=BAREMETAL -DEC_ENABLE_TLS=OFF
  • cmake --build build-baremetal
  • cmake -S . -B build-baremetal-tls -DEC_PLATFORM=BAREMETAL -DEC_ENABLE_TLS=ON
  • cmake --build build-baremetal-tls

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a comprehensive renaming of the 'Skill' system to 'Capability Bundles' throughout the codebase, including source files, headers, build configurations, and documentation. It introduces the new capability framework while maintaining a compatibility shim in ec_skill.h for existing integrations. The review feedback suggests improving the robustness of the initialization process by having ec_capability_init return an error code to signal failures such as tool registration overflows or system prompt buffer truncations.

Comment thread include/ec_capability.h
* Iterates EC_CAPABILITY_TABLE, registers every tool with ec_tool, and builds
* the combined system prompt. Call once at startup before the agent loop.
*/
void ec_capability_init(void);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The ec_capability_init function currently returns void, but it performs several operations that could fail, such as registering tools (which can fail if the registry is full) and building the system prompt (which can fail if the buffer overflows). Consider returning an error code (e.g., int) to allow the caller to handle initialization failures gracefully, especially in an embedded context where silent truncation of the system prompt or missing tools can lead to confusing behavior.

@DemonGiggle DemonGiggle force-pushed the refactor/capability-terminology branch from 011fa5c to 6709cb5 Compare May 16, 2026 03:22
@DemonGiggle DemonGiggle merged commit 8720769 into test/improve-coverage May 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant