Skip to content

Isolate test root preference persistence#76

Merged
DemonGiggle merged 1 commit into
mainfrom
fix/test-root-preference-isolation
May 10, 2026
Merged

Isolate test root preference persistence#76
DemonGiggle merged 1 commit into
mainfrom
fix/test-root-preference-isolation

Conversation

@DemonGiggle
Copy link
Copy Markdown
Owner

Summary

  • keep production root switching behavior writing the preferred-root marker
  • add app/runtime options so tests can switch root dirs without persisting the global preferred root
  • update app and web tests to use the non-persisting test app path

Tests

  • go test ./...

@DemonGiggle DemonGiggle merged commit eadc486 into main May 10, 2026
7 checks passed
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ability to control whether the preferred root path is persisted when initializing the application or switching runtimes. It refactors the initialization logic by introducing NewAppWithOptions and SwitchRuntimeWithOptions, along with corresponding options structs. The App struct now includes a persistPreferredRoot field to maintain this state. Numerous tests across the codebase have been updated to use these new constructors, and new test cases verify that persistence can be successfully skipped. I have no feedback to provide as there were no review comments to evaluate.

@DemonGiggle DemonGiggle deleted the fix/test-root-preference-isolation branch May 10, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants