fix: update eval reason serialization #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
suthar26
commented
Jan 21, 2026
suthar26
commented
- update serialization to return a proper map
- add tests for the eval reason testing
- add eval reason to the example app to test it with anon user, targeted user and not targeted user
There was a problem hiding this comment.
Pull request overview
This PR fixes the eval reason serialization in the DevCycle Flutter SDK by ensuring platform channel data is properly converted to maps before deserialization. The changes address type compatibility issues between native platforms (iOS/Android) and Flutter's Dart code.
Changes:
- Updated Android plugin to serialize EvalReason objects to proper Map format using a new
evalReasonToMaphelper method - Modified Dart code to explicitly convert platform channel maps to
Map<String, dynamic>before deserialization - Added comprehensive test coverage for eval reason serialization/deserialization on both Dart and Kotlin sides
- Updated Android build configuration (AGP 8.7.0, Kotlin 2.1.0, Gradle 8.9, compileSdk 35)
- Enhanced example app to display EvalReason information for testing
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/dvc_variable.dart | Added explicit Map conversion for eval field from platform channel |
| test/variable_test.dart | Added comprehensive tests for eval reason handling with various scenarios |
| test/eval_reason_test.dart | New test file with dedicated DevCycleEvalReason deserialization tests |
| android/src/main/kotlin/.../DevCycleFlutterClientSdkPlugin.kt | Added evalReasonToMap method to properly serialize EvalReason objects |
| android/src/test/kotlin/.../DevCycleFlutterClientSdkPluginTest.kt | New unit tests for EvalReason serialization (contains critical bugs) |
| example/lib/main.dart | Added UI components to display and test EvalReason information |
| example/android/settings.gradle | Updated Android Gradle Plugin to 8.7.0 and Kotlin to 2.1.0 |
| example/android/gradle/wrapper/gradle-wrapper.properties | Updated Gradle wrapper to version 8.9 |
| example/android/app/build.gradle | Updated compileSdk and targetSdk to 35, dependency versions updated |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...c/test/kotlin/com/devcycle/devcycle_flutter_client_sdk/DevCycleFlutterClientSdkPluginTest.kt
Outdated
Show resolved
Hide resolved
...c/test/kotlin/com/devcycle/devcycle_flutter_client_sdk/DevCycleFlutterClientSdkPluginTest.kt
Outdated
Show resolved
Hide resolved
...c/test/kotlin/com/devcycle/devcycle_flutter_client_sdk/DevCycleFlutterClientSdkPluginTest.kt
Outdated
Show resolved
Hide resolved
...c/test/kotlin/com/devcycle/devcycle_flutter_client_sdk/DevCycleFlutterClientSdkPluginTest.kt
Outdated
Show resolved
Hide resolved
...c/test/kotlin/com/devcycle/devcycle_flutter_client_sdk/DevCycleFlutterClientSdkPluginTest.kt
Outdated
Show resolved
Hide resolved
...c/test/kotlin/com/devcycle/devcycle_flutter_client_sdk/DevCycleFlutterClientSdkPluginTest.kt
Outdated
Show resolved
Hide resolved
| eval: map['eval'] != null | ||
| ? DevCycleEvalReason.fromCodec(map['eval']) | ||
| ? DevCycleEvalReason.fromCodec( | ||
| Map<String, dynamic>.from(map['eval'])) |
Contributor
There was a problem hiding this comment.
good choice with the dynamic
kaushalkapasi
approved these changes
Jan 21, 2026
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...c/test/kotlin/com/devcycle/devcycle_flutter_client_sdk/DevCycleFlutterClientSdkPluginTest.kt
Outdated
Show resolved
Hide resolved
...d/src/main/kotlin/com/devcycle/devcycle_flutter_client_sdk/DevCycleFlutterClientSdkPlugin.kt
Show resolved
Hide resolved
...c/test/kotlin/com/devcycle/devcycle_flutter_client_sdk/DevCycleFlutterClientSdkPluginTest.kt
Outdated
Show resolved
Hide resolved
...c/test/kotlin/com/devcycle/devcycle_flutter_client_sdk/DevCycleFlutterClientSdkPluginTest.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.