PivotGrid - Unskip and mock XMLA store tests#32711
Open
Tucchhaa wants to merge 5 commits intoDevExpress:26_1from
Open
PivotGrid - Unskip and mock XMLA store tests#32711Tucchhaa wants to merge 5 commits intoDevExpress:26_1from
Tucchhaa wants to merge 5 commits intoDevExpress:26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the XMLA store tests for the PivotGrid component by removing the dependency on an intranet environment and replacing actual server calls with mocked requests. The changes enable these tests to run in any environment by stubbing the sendRequest method and validating the generated XMLA queries instead of executing them against a live server.
Changes:
- Converted XMLA store tests from integration tests to unit tests using stubs
- Removed intranet environment checks and related infrastructure
- Deleted the
pivotGridTestSettings.jsfile containing the internal server URL
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| store.xmla.tests.js | Replaced live XMLA store requests with mocked sendRequest stubs; tests now validate query generation instead of actual server responses |
| dataSource_bundled.tests.js | Removed XMLA store integration tests that required intranet access |
| RunSuite.cshtml | Removed window.INTRANET global variable declaration |
| RunFlags.cs | Removed IsIntranet property from run flags |
| Program.cs | Removed IsIntranet() method and its DNS-based intranet detection logic |
| BaseRunViewModel.cs | Removed IsIntranet property from view model |
| MainController.cs | Removed assignment of IsIntranet property to view models |
| pivotGridTestSettings.js | Deleted file containing internal XMLA server URL |
packages/devextreme/testing/tests/DevExpress.ui.widgets.pivotGrid/store.xmla.tests.js
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets.pivotGrid/store.xmla.tests.js
Show resolved
Hide resolved
sjbur
approved these changes
Feb 27, 2026
This reverts commit a1f56c4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.