chore(devextreme): replace gulp js-bundles-debug with native nx targets#32712
Open
chaosmirage wants to merge 3 commits into26_1from
Open
chore(devextreme): replace gulp js-bundles-debug with native nx targets#32712chaosmirage wants to merge 3 commits into26_1from
chaosmirage wants to merge 3 commits into26_1from
Conversation
a2590e7 to
cd74a5d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the Gulp-based js-bundles-debug task with native Nx targets using a new custom bundle executor in the devextreme-nx-infra-plugin package. This continues the ongoing migration from Gulp to Nx for build orchestration in the DevExtreme monorepo.
Changes:
- Adds a new
bundleexecutor to the nx-infra-plugin that wraps webpack bundling with support for debug and production modes - Splits the
bundle:debugtarget into two sub-targets (bundle:debug:buildandbundle:debug:headers) for better caching and modularity - Updates the bundle:debug target to use native Nx executors instead of calling Gulp directly
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/nx-infra-plugin/src/executors/bundle/schema.ts | TypeScript schema defining the bundle executor options including entries, source/output directories, mode, and webpack config path |
| packages/nx-infra-plugin/src/executors/bundle/schema.json | JSON Schema validation for the bundle executor options |
| packages/nx-infra-plugin/src/executors/bundle/executor.ts | Main executor implementation that loads webpack dynamically, builds entry maps, creates webpack configuration with debug/production modes, and handles BUILD_INTERNAL_PACKAGE environment variable |
| packages/nx-infra-plugin/src/executors/bundle/executor.e2e.spec.ts | E2E test verifying the executor can bundle multiple entries in debug mode and produces the expected output files |
| packages/nx-infra-plugin/package.json | Adds webpack as an optional peer dependency and dev dependency to support the new bundle executor |
| packages/nx-infra-plugin/executors.json | Registers the new bundle executor in the plugin's executor manifest |
| packages/devextreme/project.json | Replaces gulp js-bundles-debug command with new bundle:debug:build and bundle:debug:headers targets, updates inputs/outputs to match new build structure |
| pnpm-lock.yaml | Updates webpack and related dependencies, primarily upgrading enhanced-resolve, es-module-lexer, and watchpack versions |
| .github/copilot-instructions.md | Updates documentation to reflect that bundle creation now uses the devextreme-nx-infra-plugin:bundle executor |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.