AI Assistant: localization leftovers#33664
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces placeholder/“TODO” AI Assistant error strings in the DataGrid AI Assistant flow with localized message keys, and updates the related Jest/integration tests accordingly. It also adds the new message keys to the localization message bundles for multiple locales.
Changes:
- Added new DataGrid AI Assistant message keys for “request/execution in progress”, “unexpected error”, and “invalid response” across locale JSON files.
- Updated
AIAssistantControllerto usemessageLocalization.format(...)for several error paths instead of hardcoded placeholder strings. - Updated unit + integration tests to assert the new user-visible error texts and new rejection behavior for “request in progress”.
Reviewed changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/js/localization/messages/ar.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/bg.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/ca.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/cs.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/da.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/de.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/el.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/en.json | Adds new AI Assistant error-related message keys (source strings). |
| packages/devextreme/js/localization/messages/es.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/fa.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/fi.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/fr.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/hu.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/it.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/ja.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/ko.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/lt.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/lv.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/nb.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/nl.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/pl.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/pt.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/ro.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/ru.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/sl.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/sv.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/tr.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/uk.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/vi.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/zh-tw.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/localization/messages/zh.json | Adds new AI Assistant error-related message keys. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_controller.ts | Uses localized message keys for multiple error paths and changes rejection behavior for “request already in progress”. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/ai_assistant_view_controller.integration.test.ts | Updates UI assertions to the new localized error text behavior. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/ai_assistant_controller.test.ts | Updates unit tests for new localized error strings and new rejection behavior. |
dmirgaev
changed the title
dmirgaev
force-pushed
the
26_1__locale_leftovers
branch
from
e4e2e1c to
121adba
Compare
arman-boyakhchyan
approved these changes
May 21, 2026
anna-shakhova
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.