Skip to content

[jules] enhance: Add skeleton loading state for HomeScreen groups#313

Open
Devasy wants to merge 1 commit intomainfrom
mobile-skeleton-loading-3671660779610084956
Open

[jules] enhance: Add skeleton loading state for HomeScreen groups#313
Devasy wants to merge 1 commit intomainfrom
mobile-skeleton-loading-3671660779610084956

Conversation

@Devasy
Copy link
Copy Markdown
Owner

@Devasy Devasy commented Apr 4, 2026

Implemented a complete skeleton loading system for the HomeScreen groups list in the mobile application. This replaces the generic full-screen activity indicator with an animated, structure-aware loading state that mimics the actual content layout, significantly reducing layout shift and improving perceived performance. The implementation includes a core pulsing Skeleton component and a composite GroupListSkeleton built with React Native Paper cards. Accessibility has been considered by keeping noise minimal (via container-level ARIA roles instead of element-level).


PR created automatically by Jules for task 3671660779610084956 started by @Devasy23

Summary by CodeRabbit

Release Notes

  • New Features
    • Enhanced home screen loading experience with animated skeleton placeholders that match group card layouts, reducing visual jarring and providing smoother transitions while content loads.

- Created reusable `Skeleton` UI primitive with `Animated.loop`.
- Created `GroupListSkeleton` to match actual group card layout.
- Replaced generic `ActivityIndicator` in `HomeScreen` with skeleton loading.
- Optimized accessibility by adding `accessibilityRole="progressbar"` to the skeleton container.

Co-authored-by: Devasy23 <110348311+Devasy23@users.noreply.github.com>
@Devasy Devasy requested a review from vrajpatelll as a code owner April 4, 2026 20:12
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 4, 2026

Deploy Preview for split-but-wiser canceled.

Name Link
🔨 Latest commit 52c8eba
🔍 Latest deploy log https://app.netlify.com/projects/split-but-wiser/deploys/69d170c083823e0008b8b212

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 4, 2026

Walkthrough

This pull request implements mobile skeleton loading states by replacing the generic ActivityIndicator in HomeScreen with animated skeleton layouts. A reusable Skeleton primitive component and a GroupListSkeleton component are added, both with accessibility attributes to reduce layout shift and improve the loading experience.

Changes

Cohort / File(s) Summary
Documentation Updates
.Jules/changelog.md, .Jules/todo.md
Recorded completion of skeleton loading feature with implementation details, affected files, and completion metadata (2026-04-04).
Skeleton Components
mobile/components/ui/Skeleton.js, mobile/components/skeletons/GroupListSkeleton.js
Added reusable Skeleton component with looping fade animation using Animated API; created GroupListSkeleton that renders stacked placeholder group cards with accessibility attributes (role="progressbar", container-level labeling).
HomeScreen Integration
mobile/screens/HomeScreen.js
Replaced ActivityIndicator loader with GroupListSkeleton component during data fetching; removed ActivityIndicator import.

Possibly related PRs

  • [Mobile] Complete Accessibility Audit #269 — Modifies mobile skeleton loading UI and accessibility with accessibilityRole="progressbar" attributes on HomeScreen skeletons, directly aligned with the accessibility improvements introduced in this PR.

Suggested reviewers

  • vrajpatelll
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately summarizes the main change: adding skeleton loading states to replace activity indicators on the HomeScreen groups list.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@9404621). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #313   +/-   ##
=======================================
  Coverage        ?   74.43%           
=======================================
  Files           ?       17           
  Lines           ?     1635           
  Branches        ?      144           
=======================================
  Hits            ?     1217           
  Misses          ?      367           
  Partials        ?       51           
Components Coverage Δ
Authentication System 76.80% <ø> (?)
Expense Management 69.58% <ø> (?)
Group Management 76.68% <ø> (?)
User Management 97.16% <ø> (?)
Backend Core 69.41% <ø> (?)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.Jules/todo.md:
- Around line 60-64: Remove the duplicated metadata block for the completed task
"- [x] **[ux]** Complete skeleton loading for HomeScreen groups" so only a
single canonical detail block remains; find the two overlapping detail sections
that list "Completed: 2026-04-04", "Files: `mobile/components/ui/Skeleton.js`,
`mobile/components/skeletons/GroupListSkeleton.js`,
`mobile/screens/HomeScreen.js`", "Context: Replaced ActivityIndicator with
pulsing skeleton group cards" and "Impact: Better loading experience, less
jarring", delete the redundant one and ensure the remaining block contains all
four metadata lines exactly once.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2c0a808c-7077-44ad-93af-573d77eb02db

📥 Commits

Reviewing files that changed from the base of the PR and between 9404621 and 52c8eba.

📒 Files selected for processing (5)
  • .Jules/changelog.md
  • .Jules/todo.md
  • mobile/components/skeletons/GroupListSkeleton.js
  • mobile/components/ui/Skeleton.js
  • mobile/screens/HomeScreen.js

Comment on lines +60 to +64
- [x] **[ux]** Complete skeleton loading for HomeScreen groups
- Completed: 2026-04-04
- Files: `mobile/components/ui/Skeleton.js`, `mobile/components/skeletons/GroupListSkeleton.js`, `mobile/screens/HomeScreen.js`
- Context: Replaced ActivityIndicator with pulsing skeleton group cards
- Impact: Better loading experience, less jarring
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove duplicated metadata for the completed task entry.

This task now has two overlapping detail blocks; keep a single canonical block to prevent future inconsistency.

🧹 Proposed cleanup
 - [x] **[ux]** Complete skeleton loading for HomeScreen groups
   - Completed: 2026-04-04
   - Files: `mobile/components/ui/Skeleton.js`, `mobile/components/skeletons/GroupListSkeleton.js`, `mobile/screens/HomeScreen.js`
   - Context: Replaced ActivityIndicator with pulsing skeleton group cards
   - Impact: Better loading experience, less jarring
-  - File: `mobile/screens/HomeScreen.js`
-  - Context: Replace ActivityIndicator with skeleton group cards
-  - Impact: Better loading experience, less jarring
-  - Size: ~40 lines
-  - Added: 2026-01-01
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.Jules/todo.md around lines 60 - 64, Remove the duplicated metadata block
for the completed task "- [x] **[ux]** Complete skeleton loading for HomeScreen
groups" so only a single canonical detail block remains; find the two
overlapping detail sections that list "Completed: 2026-04-04", "Files:
`mobile/components/ui/Skeleton.js`,
`mobile/components/skeletons/GroupListSkeleton.js`,
`mobile/screens/HomeScreen.js`", "Context: Replaced ActivityIndicator with
pulsing skeleton group cards" and "Impact: Better loading experience, less
jarring", delete the redundant one and ensure the remaining block contains all
four metadata lines exactly once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant